From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jesse Barton <jessebarton95@gmail.com>
Cc: valdis.kletnieks@vt.edu, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues.
Date: Tue, 1 Oct 2019 16:17:17 +0300 [thread overview]
Message-ID: <20191001131717.GD22609@kadam> (raw)
In-Reply-To: <20190929002119.20689-1-jessebarton95@gmail.com>
On Sat, Sep 28, 2019 at 07:21:19PM -0500, Jesse Barton wrote:
> Fixed Coding Style issues
Which ones?
>
> Signed-off-by: Jesse Barton <jessebarton95@gmail.com>
> ---
> drivers/staging/exfat/exfat_super.c | 29 +++++++++--------------------
> 1 file changed, 9 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
> index 3c7e2b7c2195..b9656ec06144 100644
> --- a/drivers/staging/exfat/exfat_super.c
> +++ b/drivers/staging/exfat/exfat_super.c
> @@ -640,8 +640,7 @@ static int ffs_lookup_file(struct inode *inode, char *path, struct file_id_t *fi
> return ret;
> }
>
> -static int ffs_create_file(struct inode *inode, char *path, u8 mode,
> - struct file_id_t *fid)
> +static int ffs_create_file(struct inode *inode, char *path, u8 mode, struct file_id_t *fid)
I think now checkpatch will complain that the line is too long? What we
want here is:
static int ffs_create_file(struct inode *inode, char *path, u8 mode,
struct file_id_t *fid)
[tab][tab][tab][space][space][space]struct file_id_t *fid)
So they line up.
regards,
dan carpenter
next prev parent reply other threads:[~2019-10-01 13:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 0:21 [PATCH 3/3] Staging: exfat: exfat_super.c Fixed coding style issues Jesse Barton
2019-09-29 7:26 ` Greg KH
2019-10-01 13:17 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-09-29 14:52 Jesse Barton
2019-09-29 14:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001131717.GD22609@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=jessebarton95@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.