From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Maciej Fijalkowski <maciejromanfijalkowski@gmail.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
netdev@vger.kernel.org, thomas.petazzoni@bootlin.com,
ilias.apalodimas@linaro.org, mcroce@redhat.com,
brouer@redhat.com
Subject: Re: [RFC 3/4] net: mvneta: add basic XDP support
Date: Tue, 1 Oct 2019 13:30:48 +0200 [thread overview]
Message-ID: <20191001133048.108b056a@carbon> (raw)
In-Reply-To: <87zhiku3lv.fsf@toke.dk>
On Tue, 01 Oct 2019 13:06:36 +0200
Toke Høiland-Jørgensen <toke@redhat.com> wrote:
> Maciej Fijalkowski <maciejromanfijalkowski@gmail.com> writes:
>
> > On Tue, 1 Oct 2019 11:24:43 +0200
> > Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> >
> >> Add basic XDP support to mvneta driver for devices that rely on software
> >> buffer management. Currently supported verdicts are:
> >> - XDP_DROP
> >> - XDP_PASS
> >> - XDP_REDIRECT
> >
> > You're supporting XDP_ABORTED as well :P any plans for XDP_TX?
>
> Wait, if you are supporting REDIRECT but not TX, that means redirect
> only works to other, non-mvneta, devices, right? Maybe that should be
> made clear in the commit message :)
If you implemented XDP_REDIRECT, then it should be trivial to implement
XDP_TX, as you can just convert the xdp_buff to xdp_frame and call your
ndo_xdp_xmit function directly (and do the tail-flush).
Or maybe you are missing a ndo_xdp_xmit function (as Toke indirectly
points out).
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-10-01 11:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 9:24 [RFC 0/4] add basic XDP support to mvneta driver Lorenzo Bianconi
2019-10-01 9:24 ` [RFC 1/4] net: mvneta: introduce page pool API for sw buffer manager Lorenzo Bianconi
2019-10-01 14:11 ` kbuild test robot
2019-10-01 9:24 ` [RFC 2/4] net: mvneta: rely on build_skb in mvneta_rx_swbm poll routine Lorenzo Bianconi
2019-10-01 9:24 ` [RFC 3/4] net: mvneta: add basic XDP support Lorenzo Bianconi
2019-10-01 10:37 ` Matteo Croce
2019-10-01 11:02 ` Toke Høiland-Jørgensen
2019-10-01 10:52 ` Maciej Fijalkowski
2019-10-01 11:06 ` Toke Høiland-Jørgensen
2019-10-01 11:30 ` Jesper Dangaard Brouer [this message]
2019-10-01 11:47 ` Lorenzo Bianconi
2019-10-01 11:44 ` Lorenzo Bianconi
2019-10-02 3:41 ` Ilias Apalodimas
2019-10-02 8:59 ` Lorenzo Bianconi
2019-10-01 9:24 ` [RFC 4/4] net: mvneta: move header prefetch in mvneta_swbm_rx_frame Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001133048.108b056a@carbon \
--to=brouer@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=lorenzo@kernel.org \
--cc=maciejromanfijalkowski@gmail.com \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.