From: Thierry Reding <thierry.reding@gmail.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Jens Axboe <axboe@kernel.dk>,
Jonathan Hunter <jonathanh@nvidia.com>, JC Kuo <jckuo@nvidia.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-ide@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 0/3] tegra: use regulator_bulk_set_supply_names()
Date: Tue, 1 Oct 2019 15:38:07 +0200 [thread overview]
Message-ID: <20191001133807.GB3563296@ulmo> (raw)
In-Reply-To: <20191001132333.20146-1-brgl@bgdev.pl>
[-- Attachment #1: Type: text/plain, Size: 854 bytes --]
On Tue, Oct 01, 2019 at 03:23:30PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> The regulator_bulk_set_supply_names() helper was merged upstream. Use it
> in a couple tegra drivers.
>
> Bartosz Golaszewski (3):
> ahci: tegra: use regulator_bulk_set_supply_names()
> phy: tegra: use regulator_bulk_set_supply_names()
> usb: host: xhci-tegra: use regulator_bulk_set_supply_names()
>
> drivers/ata/ahci_tegra.c | 6 +++---
> drivers/phy/tegra/xusb.c | 6 +++---
> drivers/usb/host/xhci-tegra.c | 5 +++--
> 3 files changed, 9 insertions(+), 8 deletions(-)
I really don't see the point here. You've got a positive diffstat here,
which means all that churn is without benefit.
Is there some subsequent work based on this that will actually improve
things?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-10-01 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 13:23 [PATCH 0/3] tegra: use regulator_bulk_set_supply_names() Bartosz Golaszewski
2019-10-01 13:23 ` [PATCH 1/3] ahci: " Bartosz Golaszewski
2019-10-02 12:26 ` Thierry Reding
2019-10-01 13:23 ` [PATCH 2/3] phy: " Bartosz Golaszewski
2019-10-02 12:26 ` Thierry Reding
2019-10-01 13:23 ` [PATCH 3/3] usb: host: xhci-tegra: " Bartosz Golaszewski
2019-10-02 12:26 ` Thierry Reding
2019-10-01 13:38 ` Thierry Reding [this message]
2019-10-02 9:09 ` [PATCH 0/3] tegra: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001133807.GB3563296@ulmo \
--to=thierry.reding@gmail.com \
--cc=axboe@kernel.dk \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=jckuo@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kishon@ti.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.