From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Michal Kubecek <mkubecek@suse.cz>
Cc: linux-kernel@vger.kernel.org, Jiri Kosina <jikos@kernel.org>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-s390@vger.kernel.org
Subject: Re: [PATCH 5.4-rc1 BUILD FIX] s390: mark __cpacf_query() as __always_inline
Date: Wed, 2 Oct 2019 10:21:57 +0200 [thread overview]
Message-ID: <20191002082157.GA9535@osiris> (raw)
In-Reply-To: <20191002070333.GE24815@unicorn.suse.cz>
On Wed, Oct 02, 2019 at 09:03:33AM +0200, Michal Kubecek wrote:
> On Wed, Oct 02, 2019 at 08:46:05AM +0200, Heiko Carstens wrote:
> > On Tue, Oct 01, 2019 at 10:08:01PM +0200, Jiri Kosina wrote:
> > >
> > > In file included from arch/s390/kvm/kvm-s390.c:44:
> > > ./arch/s390/include/asm/cpacf.h: In function '__cpacf_query':
> > > ./arch/s390/include/asm/cpacf.h:179:2: warning: asm operand 3 probably doesn't match constraints
> > > 179 | asm volatile(
> > > | ^~~
> > > ./arch/s390/include/asm/cpacf.h:179:2: error: impossible constraint in 'asm'
> > >
> > > ...
> > >
> > > I am wondering how is it possible that none of the build-testing
> > > infrastructure we have running against linux-next caught this? Not enough
> > > non-x86 coverage?
> >
> > Well, there is plenty of s390 coverage with respect to daily builds
> > (also here). It doesn't fail for me with gcc 9.1; so you may either
> > have a different gcc version or different config options(?) so the
> > compiler decided to not inline the function.
>
> I think I found the reason: we only hit the build failure with one
> special config used for zfcpdump which has
>
> CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>
> When I switched to CONFIG_CC_OPTIMIZE_FOR_PERFORMANCE=y (which we have
> in other s390x configs and which most people probably prefer), the build
> does not fail even without the patch.
Yes, with CONFIG_CC_OPTIMIZE_FOR_SIZE=y I can see plenty of _additional_
compile failures on s390 with "defconfig". Will fix them all...
Thanks for reporting!
prev parent reply other threads:[~2019-10-02 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 20:08 [PATCH 5.4-rc1 BUILD FIX] s390: mark __cpacf_query() as __always_inline Jiri Kosina
2019-10-01 20:15 ` Jiri Kosina
2019-10-02 6:44 ` Christian Borntraeger
2019-10-02 6:46 ` Heiko Carstens
2019-10-02 6:49 ` Heiko Carstens
2019-10-02 7:03 ` Michal Kubecek
2019-10-02 8:21 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002082157.GA9535@osiris \
--to=heiko.carstens@de.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=gor@linux.ibm.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=torvalds@linux-foundation.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.