From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 853CEC35280 for ; Wed, 2 Oct 2019 12:21:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56A4F21A4A for ; Wed, 2 Oct 2019 12:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570018894; bh=Oh5/WnwBtsPLYt0+aGA3BlHAkS4SLscg5xN3ZOxxGpw=; h=From:To:Cc:Subject:Date:List-ID:From; b=Ym1Xv2UxW/uDyiOUkKaxQCwPBsHVgIaTxmA5RpeCXiBzKweK3rhWNjJsww1Z7aXuN hfHpcggrlATAdWkxAL6B4qzfPmgOoShMOEIXilYgXjTqhbt7kFK6mvoMTaJsrEmXC3 2O5ybpcNprOmk2k9nbVbaPHkwnJHee7XQ0pvApMM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725928AbfJBMVd (ORCPT ); Wed, 2 Oct 2019 08:21:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:59022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725747AbfJBMVd (ORCPT ); Wed, 2 Oct 2019 08:21:33 -0400 Received: from localhost (unknown [193.47.165.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4BBF121920; Wed, 2 Oct 2019 12:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570018892; bh=Oh5/WnwBtsPLYt0+aGA3BlHAkS4SLscg5xN3ZOxxGpw=; h=From:To:Cc:Subject:Date:From; b=NUBCRw3VGkigG9z1t/S//Rt+C0TfxPcgBa7z7yJXFfQ1sn55YtSBdJKDzmMFKsUsa q0K+wk8ENJEQJX/HgpavJNK+qLCu4MY34UwXDjgM+NRNjC7uuZvLfvsfR1U5jhcLME KRrv5to2K5imKX7IEtBOxM1Kg2NXveWlVIVGyIe4= From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Mohamad Heib , RDMA mailing list , Erez Alfasi , Jason Gunthorpe , Leon Romanovsky Subject: [PATCH rdma-rc] IB/core: Fix wrong iterating on ports Date: Wed, 2 Oct 2019 15:21:27 +0300 Message-Id: <20191002122127.17571-1-leon@kernel.org> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Mohamad Heib rdma_for_each_port is already incrementing the iterator's value it receives therefore, after the first iteration the iterator is increased by 2 which eventually causing wrong queries and possible traces. Fix the above by removing the old redundant incrementation that was used before rdma_for_each_port() macro. Fixes: ea1075edcbab ("RDMA: Add and use rdma_for_each_port") Signed-off-by: Mohamad Heib Reviewed-by: Erez Alfasi Signed-off-by: Leon Romanovsky --- drivers/infiniband/core/security.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/core/security.c b/drivers/infiniband/core/security.c index 1ab423b19f77..6eb6d2717ca5 100644 --- a/drivers/infiniband/core/security.c +++ b/drivers/infiniband/core/security.c @@ -426,7 +426,7 @@ int ib_create_qp_security(struct ib_qp *qp, struct ib_device *dev) int ret; rdma_for_each_port (dev, i) { - is_ib = rdma_protocol_ib(dev, i++); + is_ib = rdma_protocol_ib(dev, i); if (is_ib) break; } -- 2.20.1