From: Kalle Valo <kvalo@codeaurora.org>
To: Denis Efremov <efremov@linux.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Denis Efremov <efremov@linux.com>,
Pontus Fuchs <pontus.fuchs@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
David Laight <David.Laight@ACULAB.COM>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] ar5523: check NULL before memcpy() in ar5523_cmd()
Date: Wed, 2 Oct 2019 17:22:08 +0000 (UTC) [thread overview]
Message-ID: <20191002172208.78D4C6115A@smtp.codeaurora.org> (raw)
In-Reply-To: <20190930203147.10140-1-efremov@linux.com>
Denis Efremov <efremov@linux.com> wrote:
> memcpy() call with "idata == NULL && ilen == 0" results in undefined
> behavior in ar5523_cmd(). For example, NULL is passed in callchain
> "ar5523_stat_work() -> ar5523_cmd_write() -> ar5523_cmd()". This patch
> adds ilen check before memcpy() call in ar5523_cmd() to prevent an
> undefined behavior.
>
> Cc: Pontus Fuchs <pontus.fuchs@gmail.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: David Laight <David.Laight@ACULAB.COM>
> Cc: stable@vger.kernel.org
> Signed-off-by: Denis Efremov <efremov@linux.com>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
315cee426f87 ar5523: check NULL before memcpy() in ar5523_cmd()
--
https://patchwork.kernel.org/patch/11167401/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-10-02 17:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 14:02 [PATCH] ar5523: check NULL before memcpy() in ar5523_cmd() Denis Efremov
2019-09-30 15:35 ` David Laight
2019-09-30 20:31 ` [PATCH v2] " Denis Efremov
2019-10-02 17:22 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002172208.78D4C6115A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=efremov@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pontus.fuchs@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.