From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benoit Parrot <bparrot@ti.com>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
Rob Herring <robh@kernel.org>,
andriy.shevchenko@linux.intel.com, andy.shevchenko@gmail.com,
simon.budig@kernelconcepts.de, hdegoede@redhat.com,
fcooper@ti.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, kernel@pengutronix.de,
bcousson@baylibre.com, tony@atomide.com,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
ludovic.desroches@microchip.com, s.hauer@pengutronix.de,
festevam@gmail.com, linux-imx@nxp.com, shawnguo@kernel.org,
mripard@kernel.org, wens@csie.org
Subject: Re: [PATCH 2/6] dt-bindings: Input: edt-ft5x06 - add disable wakeup-source documentation
Date: Wed, 2 Oct 2019 10:30:07 -0700 [thread overview]
Message-ID: <20191002173007.GA20549@dtor-ws> (raw)
In-Reply-To: <20191002152003.ag36lrragazsdn5j@ti.com>
On Wed, Oct 02, 2019 at 10:20:03AM -0500, Benoit Parrot wrote:
> Marco Felsch <m.felsch@pengutronix.de> wrote on Wed [2019-Oct-02 15:00:18 +0200]:
> > Hi,
> >
> > all of you using a edt,* touchscreen and currently the driver marks
> > the touchscreen as wakeup source. To keep backward compatibility I added
> > a workaround binding (see below) but Dmitry prefer to use the normal
> > "wakeup-source" binding and change the affected device-tree's
> > (discussion below). Can you give me your ack/nack for Dmitry's solution?
>
> So, if I understand this correctly, currently the driver always assume it
> is a wakeup source regardless if the "wakeup-source" DT property being
> present or not. And the proposed change now is to fix the driver so that it
> will assume a wakeup source role only if the DT property is present?
Yes, that is correct.
>
> If that is the case then ACK from my side for the AM43x devices.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-10-02 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190917155808.27818-1-m.felsch@pengutronix.de>
[not found] ` <20190917155808.27818-3-m.felsch@pengutronix.de>
[not found] ` <20190917170743.GO237523@dtor-ws>
[not found] ` <20190917171814.owcttekv56xgmsts@pengutronix.de>
[not found] ` <20190917172658.GQ237523@dtor-ws>
2019-09-30 23:11 ` [PATCH 2/6] dt-bindings: Input: edt-ft5x06 - add disable wakeup-source documentation Rob Herring
2019-10-02 13:00 ` Marco Felsch
2019-10-02 14:48 ` Maxime Ripard
2019-10-02 15:20 ` Benoit Parrot
2019-10-02 17:30 ` Dmitry Torokhov [this message]
2019-10-02 15:24 ` Alexandre Belloni
2019-10-14 9:14 ` Shawn Guo
[not found] ` <20190917155808.27818-6-m.felsch@pengutronix.de>
2019-09-30 23:12 ` [PATCH 5/6] dt-bindings: Input: edt-ft5x06 - add vdd supply documentation Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002173007.GA20549@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=bcousson@baylibre.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=festevam@gmail.com \
--cc=hdegoede@redhat.com \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=m.felsch@pengutronix.de \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simon.budig@kernelconcepts.de \
--cc=tony@atomide.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.