From: Pavel Machek <pavel@denx.de>
To: Dan Murphy <dmurphy@ti.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH -next 2/2] leds: add /sys/class/leds/<led>/current-trigger
Date: Wed, 2 Oct 2019 20:06:25 +0200 [thread overview]
Message-ID: <20191002180625.GB13492@amd> (raw)
In-Reply-To: <79102915-5510-40e7-b4be-073e1c85bda6@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1859 bytes --]
Hi!
> >>>diff --git a/Documentation/ABI/testing/sysfs-class-led
> >>>b/Documentation/ABI/testing/sysfs-class-led
> >>>index 5f67f7a..fdfed3f 100644
> >>>--- a/Documentation/ABI/testing/sysfs-class-led
> >>>+++ b/Documentation/ABI/testing/sysfs-class-led
> >>>@@ -61,3 +61,16 @@ Description:
> >>> gpio and backlight triggers. In case of the backlight trigger,
> >>> it is useful when driving a LED which is intended to indicate
> >>> a device in a standby like state.
> >>>+
> >>>+What: /sys/class/leds/<led>/current-trigger
> >>>+Date: September 2019
> >>>+KernelVersion: 5.5
> >>>+Contact: linux-leds@vger.kernel.org
> >>>+Description:
> >>>+ Set the trigger for this LED. A trigger is a kernel based source
> >>>+ of LED events.
> >>>+ Writing the trigger name to this file will change the current
> >>>+ trigger. Trigger specific parameters can appear in
> >>>+ /sys/class/leds/<led> once a given trigger is selected. For
> >>>+ their documentation see sysfs-class-led-trigger-*.
> >>>+ Reading this file will return the current LED trigger name.
> >>Why do we need this new file can't we just update the current trigger
> >>file implementation?
> >We can't change existing ABI. It doesn't matter if it is documented
> >or not - it's in place for very long time and you can't guarantee there
> >are no users relying on triggers file show format.
>
> So if it has been in place for a very long time why do we need another ABI
> that does sorta the same thing?
>
> This seems to be a bit confusing and extra.
Agreed. Lets simply keep the existing ABI.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-10-02 18:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 15:12 [PATCH -next 0/2] leds: add substitutes for /sys/class/leds/<led>/trigger Akinobu Mita
2019-10-02 15:13 ` [PATCH -next 1/2] leds: add /sys/devices/virtual/led-trigger/ Akinobu Mita
2019-10-02 15:27 ` Greg Kroah-Hartman
2019-10-02 15:28 ` Greg Kroah-Hartman
2019-10-02 15:13 ` [PATCH -next 2/2] leds: add /sys/class/leds/<led>/current-trigger Akinobu Mita
2019-10-02 15:30 ` Greg Kroah-Hartman
2019-10-02 15:47 ` Dan Murphy
2019-10-02 17:46 ` Jacek Anaszewski
2019-10-02 17:57 ` Dan Murphy
2019-10-02 18:06 ` Pavel Machek [this message]
2019-10-02 18:03 ` [PATCH -next 0/2] leds: add substitutes for /sys/class/leds/<led>/trigger Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191002180625.GB13492@amd \
--to=pavel@denx.de \
--cc=akinobu.mita@gmail.com \
--cc=dmurphy@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.