All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patchwork <patchwork@emeril.freedesktop.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore (rev2)
Date: Wed, 02 Oct 2019 20:16:35 -0000	[thread overview]
Message-ID: <20191002201635.9784.54951@emeril.freedesktop.org> (raw)
In-Reply-To: <20191002112000.12280-1-chris@chris-wilson.co.uk>

== Series Details ==

Series: series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore (rev2)
URL   : https://patchwork.freedesktop.org/series/67483/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5ab21c1fa058 drm/i915/selftests: Exercise potential false lite-restore
0322b52184d0 dma-fence: Serialise signal enabling (dma_fence_enable_sw_signaling)
-:14: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 0fc89b6802ba ("dma-fence: Simply wrap dma_fence_signal_locked with dma_fence_signal")'
#14: 
See also 0fc89b6802ba ("dma-fence: Simply wrap dma_fence_signal_locked

total: 1 errors, 0 warnings, 0 checks, 24 lines checked
1a05d810f79f drm/mm: Pack allocated/scanned boolean into a bitfield
931f20d41378 drm/i915: Only track bound elements of the GTT
2a6d4f282fa6 drm/i915: Mark up address spaces that may need to allocate
be8578d54763 drm/i915: Pull i915_vma_pin under the vm->mutex
4404006876ec drm/i915: Push the i915_active.retire into a worker
81d85386f107 drm/i915: Coordinate i915_active with its own mutex
-:1340: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#1340: FILE: drivers/gpu/drm/i915/i915_active_types.h:49:
+	struct mutex mutex;

total: 0 errors, 0 warnings, 1 checks, 1481 lines checked
f2e5937f521c drm/i915: Move idle barrier cleanup into engine-pm
a34a2a0ff4b7 drm/i915: Drop struct_mutex from around i915_retire_requests()
34cf8af39814 drm/i915: Remove the GEM idle worker
4bc0f23154b4 drm/i915: Merge wait_for_timelines with retire_request
ee8a183e05ce drm/i915/gem: Retire directly for mmap-offset shrinking
a23c0260a779 drm/i915: Move request runtime management onto gt
-:236: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#236: 
new file mode 100644

-:241: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#241: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.c:1:
+/*

-:242: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#242: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.c:2:
+ * SPDX-License-Identifier: MIT

-:370: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#370: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.h:1:
+/*

-:371: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#371: FILE: drivers/gpu/drm/i915/gt/intel_gt_requests.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 725 lines checked
f210329ac8c8 drm/i915: Move global activity tracking from GEM to GT
f452d4758807 drm/i915: Expose engine properties via sysfs
-:68: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#68: 
new file mode 100644

-:73: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#73: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.c:1:
+/*

-:74: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#74: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.c:2:
+ * SPDX-License-Identifier: MIT

-:198: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#198: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.h:1:
+/*

-:199: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#199: FILE: drivers/gpu/drm/i915/gt/intel_engine_sysfs.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 5 warnings, 0 checks, 158 lines checked
81490be650d7 drm/i915/execlists: Force preemption
bc5ab3030d38 drm/i915: Mark up "sentinel" requests
258d11346b6a drm/i915/execlists: Cancel banned contexts on schedule-out
b6e6bd3f3585 drm/i915: Cancel non-persistent contexts on close
-:38: WARNING:BAD_SIGN_OFF: Duplicate signature
#38: 
Reviewed-by: Jon Bloomfield <jon.bloomfield@intel.com>

-:299: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#299: 
new file mode 100644

-:304: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#304: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:1:
+/*

-:305: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#305: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:2:
+ * SPDX-License-Identifier: MIT

-:366: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#366: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h:1:
+/*

-:367: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#367: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.h:2:
+ * SPDX-License-Identifier: MIT

total: 0 errors, 6 warnings, 0 checks, 332 lines checked
128a9bd55770 drm/i915: Replace hangcheck by heartbeats
-:236: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'heartbeat', this function's name, in a string
#236: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:69:
+					  "%s heartbeat not ticking\n",

-:253: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'heartbeat', this function's name, in a string
#253: FILE: drivers/gpu/drm/i915/gt/intel_engine_heartbeat.c:86:
+					      "stopped heartbeat on %s",

-:540: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#540: 
deleted file mode 100644

total: 0 errors, 3 warnings, 0 checks, 672 lines checked
42bd5709ec17 drm/i915: Remove logical HW ID
10e4db753ab1 drm/i915: Move context management under GEM
-:1061: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#1061: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:988:
+#define GEN11_MAX_CONTEXT_HW_ID (1<<11) /* exclusive */
                                   ^

total: 0 errors, 0 warnings, 1 checks, 1717 lines checked
1e0c926a87c1 drm/i915/overlay: Drop struct_mutex guard
de0dcfa1655b drm/i915: Drop struct_mutex guard from debugfs/framebuffer_info
711644d1d77a drm/i915: Remove struct_mutex guard for debugfs/opregion
024590a3e7fd drm/i915: Drop struct_mutex from suspend state save/restore
066f93946d1d drm/i915/selftests: Drop vestigal struct_mutex guards
76f85559693d drm/i915: Drop struct_mutex from around GEM initialisation
56d46847a471 drm/i915: Flush idle barriers when waiting

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2019-10-02 20:16 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 11:19 [PATCH 01/30] drm/i915/selftests: Exercise potential false lite-restore Chris Wilson
2019-10-02 11:19 ` [PATCH 02/30] dma-fence: Serialise signal enabling (dma_fence_enable_sw_signaling) Chris Wilson
2019-10-02 11:19 ` [PATCH 03/30] drm/mm: Pack allocated/scanned boolean into a bitfield Chris Wilson
2019-10-02 11:19 ` [PATCH 04/30] drm/i915: Only track bound elements of the GTT Chris Wilson
2019-10-02 11:19 ` [PATCH 05/30] drm/i915: Mark up address spaces that may need to allocate Chris Wilson
2019-10-02 15:47   ` Tvrtko Ursulin
2019-10-02 11:19 ` [PATCH 06/30] drm/i915: Pull i915_vma_pin under the vm->mutex Chris Wilson
2019-10-02 11:19 ` [PATCH 07/30] drm/i915: Push the i915_active.retire into a worker Chris Wilson
2019-10-02 11:19 ` [PATCH 08/30] drm/i915: Coordinate i915_active with its own mutex Chris Wilson
2019-10-02 15:49   ` Tvrtko Ursulin
2019-10-02 11:19 ` [PATCH 09/30] drm/i915: Move idle barrier cleanup into engine-pm Chris Wilson
2019-10-02 11:19 ` [PATCH 10/30] drm/i915: Drop struct_mutex from around i915_retire_requests() Chris Wilson
2019-10-02 11:19 ` [PATCH 11/30] drm/i915: Remove the GEM idle worker Chris Wilson
2019-10-02 11:19 ` [PATCH 12/30] drm/i915: Merge wait_for_timelines with retire_request Chris Wilson
2019-10-02 11:19 ` [PATCH 13/30] drm/i915/gem: Retire directly for mmap-offset shrinking Chris Wilson
2019-10-02 15:53   ` Tvrtko Ursulin
2019-10-02 11:19 ` [PATCH 14/30] drm/i915: Move request runtime management onto gt Chris Wilson
2019-10-02 15:58   ` Tvrtko Ursulin
2019-10-02 11:19 ` [PATCH 15/30] drm/i915: Move global activity tracking from GEM to GT Chris Wilson
2019-10-02 11:19 ` [PATCH 16/30] drm/i915: Expose engine properties via sysfs Chris Wilson
2019-10-02 11:19 ` [PATCH 17/30] drm/i915/execlists: Force preemption Chris Wilson
2019-10-02 11:19 ` [PATCH 18/30] drm/i915: Mark up "sentinel" requests Chris Wilson
2019-10-02 11:19 ` [PATCH 19/30] drm/i915/execlists: Cancel banned contexts on schedule-out Chris Wilson
2019-10-02 11:19 ` [PATCH 20/30] drm/i915: Cancel non-persistent contexts on close Chris Wilson
2019-10-02 13:52   ` Bloomfield, Jon
2019-10-02 14:05     ` Chris Wilson
2019-10-02 14:23     ` Chris Wilson
2019-10-02 14:40       ` Bloomfield, Jon
2019-10-02 14:23   ` [PATCH v2] " Chris Wilson
2019-10-02 14:36     ` Bloomfield, Jon
2019-10-02 11:19 ` [PATCH 21/30] drm/i915: Replace hangcheck by heartbeats Chris Wilson
2019-10-02 13:55   ` Bloomfield, Jon
2019-10-02 14:28     ` Chris Wilson
2019-10-02 11:19 ` [PATCH 22/30] drm/i915: Remove logical HW ID Chris Wilson
2019-10-02 16:07   ` Tvrtko Ursulin
2019-10-02 11:19 ` [PATCH 23/30] drm/i915: Move context management under GEM Chris Wilson
2019-10-02 11:19 ` [PATCH 24/30] drm/i915/overlay: Drop struct_mutex guard Chris Wilson
2019-10-02 11:19 ` [PATCH 25/30] drm/i915: Drop struct_mutex guard from debugfs/framebuffer_info Chris Wilson
2019-10-02 11:19 ` [PATCH 26/30] drm/i915: Remove struct_mutex guard for debugfs/opregion Chris Wilson
2019-10-02 11:19 ` [PATCH 27/30] drm/i915: Drop struct_mutex from suspend state save/restore Chris Wilson
2019-10-02 11:19 ` [PATCH 28/30] drm/i915/selftests: Drop vestigal struct_mutex guards Chris Wilson
2019-10-02 11:19 ` [PATCH 29/30] drm/i915: Drop struct_mutex from around GEM initialisation Chris Wilson
2019-10-02 11:20 ` [PATCH 30/30] drm/i915: Flush idle barriers when waiting Chris Wilson
2019-10-02 13:21 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore Patchwork
2019-10-02 13:34 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-10-02 13:46 ` ✗ Fi.CI.BAT: failure " Patchwork
2019-10-02 13:49   ` Chris Wilson
2019-10-02 20:16 ` Patchwork [this message]
2019-10-02 20:29 ` ✗ Fi.CI.SPARSE: warning for series starting with [01/30] drm/i915/selftests: Exercise potential false lite-restore (rev2) Patchwork
2019-10-02 20:41 ` ✗ Fi.CI.BAT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191002201635.9784.54951@emeril.freedesktop.org \
    --to=patchwork@emeril.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.