All of lore.kernel.org
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd: host: fix seg fault at "host info"
Date: Thu, 3 Oct 2019 15:04:25 +0900	[thread overview]
Message-ID: <20191003060424.GI18778@linaro.org> (raw)
In-Reply-To: <20190822074739.8846-1-takahiro.akashi@linaro.org>

Ping,

This patch has not been merged yet.

-Takahiro Akashi

On Thu, Aug 22, 2019 at 04:47:39PM +0900, AKASHI Takahiro wrote:
> With the patch below applied, host_block_dev structure was switched
> to be placed in platdata rather than priv. The command "host info"
> must be aligned with this change. Otherwise, we will see "Segmentation
> Fault."
> 
> Fixes: 8f994c860d91 ("sandbox: blk: Switch to use platdata_auto_alloc_size for the driver data")
> Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> ---
>  cmd/host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cmd/host.c b/cmd/host.c
> index f7d3eae5b1ad..98c4d2a099e9 100644
> --- a/cmd/host.c
> +++ b/cmd/host.c
> @@ -89,7 +89,7 @@ static int do_host_info(cmd_tbl_t *cmdtp, int flag, int argc,
>  		struct host_block_dev *host_dev;
>  
>  #ifdef CONFIG_BLK
> -		host_dev = dev_get_priv(blk_dev->bdev);
> +		host_dev = dev_get_platdata(blk_dev->bdev);
>  #else
>  		host_dev = blk_dev->priv;
>  #endif
> -- 
> 2.21.0
> 

  parent reply	other threads:[~2019-10-03  6:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-22  7:47 [U-Boot] [PATCH] cmd: host: fix seg fault at "host info" AKASHI Takahiro
2019-08-27  1:12 ` Bin Meng
2019-08-27  2:54 ` Heinrich Schuchardt
2019-10-03  6:04 ` AKASHI Takahiro [this message]
2019-10-03  7:27   ` Bin Meng
2019-10-06 22:03 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191003060424.GI18778@linaro.org \
    --to=takahiro.akashi@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.