From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Saiyam Doshi <saiyamdoshi.in@gmail.com>,
devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: exfat: use bdev_sync function directly where needed
Date: Thu, 3 Oct 2019 14:46:54 +0300 [thread overview]
Message-ID: <20191003114654.GT22609@kadam> (raw)
In-Reply-To: <9938.1570043055@turing-police>
I replied to your other thread and I added Saiyam Doshi to the CC list
there. Just to be clear this patch is a good cleanup and doesn't affect
runtime at all.
In the other thread, I suggested that we leave fs_sync() as a marker
even though it's dead code. But looking at it now, I think that it's
not really useful. Future auditors should look for places which call
fs_set_vol_flags(sb, VOL_CLEAN); instead. That's exactly the places
which call fs_sync().
regards,
dan carpenter
next prev parent reply other threads:[~2019-10-03 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 15:17 [PATCH] staging: exfat: use bdev_sync function directly where needed Saiyam Doshi
2019-10-02 19:04 ` Valdis Klētnieks
2019-10-03 11:46 ` Dan Carpenter [this message]
2019-10-03 11:48 ` Dan Carpenter
2019-10-03 11:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191003114654.GT22609@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saiyamdoshi.in@gmail.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.