All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: neilb@suse.de, guoqing.jiang@cloud.ionos.com,
	songliubraving@fb.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] md/raid0: avoid RAID0 data corruption due to layout" failed to apply to 5.3-stable tree
Date: Thu, 3 Oct 2019 08:45:36 -0400	[thread overview]
Message-ID: <20191003124536.GU17454@sasha-vm> (raw)
In-Reply-To: <1570089215120157@kroah.com>

On Thu, Oct 03, 2019 at 09:53:35AM +0200, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.3-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From c84a1372df929033cb1a0441fb57bd3932f39ac9 Mon Sep 17 00:00:00 2001
>From: NeilBrown <neilb@suse.de>
>Date: Mon, 9 Sep 2019 16:30:02 +1000
>Subject: [PATCH] md/raid0: avoid RAID0 data corruption due to layout
> confusion.
>
>If the drives in a RAID0 are not all the same size, the array is
>divided into zones.
>The first zone covers all drives, to the size of the smallest.
>The second zone covers all drives larger than the smallest, up to
>the size of the second smallest - etc.
>
>A change in Linux 3.14 unintentionally changed the layout for the
>second and subsequent zones.  All the correct data is still stored, but
>each chunk may be assigned to a different device than in pre-3.14 kernels.
>This can lead to data corruption.
>
>It is not possible to determine what layout to use - it depends which
>kernel the data was written by.
>So we add a module parameter to allow the old (0) or new (1) layout to be
>specified, and refused to assemble an affected array if that parameter is
>not set.
>
>Fixes: 20d0189b1012 ("block: Introduce new bio_split()")
>cc: stable@vger.kernel.org (3.14+)
>Acked-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
>Signed-off-by: NeilBrown <neilb@suse.de>
>Signed-off-by: Song Liu <songliubraving@fb.com>

Had to adjust context slightly due to missing 62f7b1989c02f ("md
raid0/linear: Mark array as 'broken' and fail BIOs if a member is
gone)" in 5.3-4.14.

On 4.9 and 4.4 we need a more complex backport which I didn't attempt
due to missing be306c2989804 ("md: define mddev flags, recovery flags
and r1bio state bits using enums") and a few fixes of that.

Queued up for 5.3-4.14.

--
Thanks,
Sasha

      reply	other threads:[~2019-10-03 12:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03  7:53 FAILED: patch "[PATCH] md/raid0: avoid RAID0 data corruption due to layout" failed to apply to 5.3-stable tree gregkh
2019-10-03 12:45 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191003124536.GU17454@sasha-vm \
    --to=sashal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=guoqing.jiang@cloud.ionos.com \
    --cc=neilb@suse.de \
    --cc=songliubraving@fb.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.