All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	jolsa@kernel.org, linux-kernel@vger.kernel.org,
	Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf script: Allow --time with --reltime
Date: Thu, 3 Oct 2019 11:12:26 -0300	[thread overview]
Message-ID: <20191003141226.GC18973@kernel.org> (raw)
In-Reply-To: <20191003101827.GA23291@krava>

Em Thu, Oct 03, 2019 at 12:18:27PM +0200, Jiri Olsa escreveu:
> On Wed, Oct 02, 2019 at 09:46:42AM -0700, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> > 
> > The original --reltime patch forbid --time with --reltime.
> > 
> > But it turns out --time doesn't really care about --reltime, because
> > the relative time is only used at final output, while
> > the time filtering always works earlier on absolute time.
> > 
> > So just remove the check and allow combining the two options.
> > 
> > Fixes: 90b10f47c0ee ("perf script: Support relative time")
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied.

- Arnaldo

  reply	other threads:[~2019-10-03 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 16:46 [PATCH] perf script: Allow --time with --reltime Andi Kleen
2019-10-03 10:18 ` Jiri Olsa
2019-10-03 14:12   ` Arnaldo Carvalho de Melo [this message]
2019-10-15  5:31 ` [tip: perf/core] " tip-bot2 for Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191003141226.GC18973@kernel.org \
    --to=arnaldo.melo@gmail.com \
    --cc=ak@linux.intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.