From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E06FDC10F14 for ; Thu, 3 Oct 2019 17:27:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBE9320830 for ; Thu, 3 Oct 2019 17:27:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388583AbfJCQOX (ORCPT ); Thu, 3 Oct 2019 12:14:23 -0400 Received: from bout01.mta.xmission.com ([166.70.11.15]:50250 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388575AbfJCQOW (ORCPT ); Thu, 3 Oct 2019 12:14:22 -0400 Received: from mx01.mta.xmission.com ([166.70.13.211]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1iG3Dz-0007yB-3W; Thu, 03 Oct 2019 09:41:03 -0600 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1iG3Dw-0003hb-Uu; Thu, 03 Oct 2019 09:41:03 -0600 Received: from hacktheplanet (c-68-50-34-150.hsd1.in.comcast.net [68.50.34.150]) by plesk14.xmission.com (Postfix) with ESMTPSA id 47CDD1266F5; Thu, 3 Oct 2019 15:40:59 +0000 (UTC) Date: Thu, 3 Oct 2019 11:40:53 -0400 From: Scott Bauer To: Randy Dunlap Cc: "linux-block@vger.kernel.org" , LKML , axboe , Scott Bauer , jonathan.derrick@intel.com, revanth.rajashekar@intel.com Message-ID: <20191003154053.GA2450@hacktheplanet> References: <82f70133-7242-d113-f041-9b89694685c0@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <82f70133-7242-d113-f041-9b89694685c0@infradead.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1iG3Dw-0003hb-Uu;;;mid=<20191003154053.GA2450@hacktheplanet>;;;hst=mx01.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me Subject: Re: [PATCH 2/2] block: sed-opal: fix sparse warning: convert __be64 data X-SA-Exim-Version: 4.2.1 (built Mon, 03 Jun 2019 09:49:16 -0600) X-SA-Exim-Scanned: Yes (on mx01.mta.xmission.com) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Oct 02, 2019 at 07:23:15PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > sparse warns about incorrect type when using __be64 data. > It is not being converted to CPU-endian but it should be. > > Fixes these sparse warnings: > > ../block/sed-opal.c:375:20: warning: incorrect type in assignment (different base types) > ../block/sed-opal.c:375:20: expected unsigned long long [usertype] align > ../block/sed-opal.c:375:20: got restricted __be64 const [usertype] alignment_granularity > ../block/sed-opal.c:376:25: warning: incorrect type in assignment (different base types) > ../block/sed-opal.c:376:25: expected unsigned long long [usertype] lowest_lba > ../block/sed-opal.c:376:25: got restricted __be64 const [usertype] lowest_aligned_lba > > Fixes: 455a7b238cd6 ("block: Add Sed-opal library") > Signed-off-by: Randy Dunlap > Cc: Scott Bauer > Cc: Rafael Antognolli > Cc: Jens Axboe > Cc: linux-block@vger.kernel.org + Jon and Revanth, These look fine. They're currently unused, but may be useful in the future for sysfs or what ever else we add in.