From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============0130903230659697640=="
MIME-Version: 1.0
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kbuild-all@lists.01.org
Subject: Re: [linux-stable-rc:linux-4.19.y 7762/7788] include/linux/spinlock.h:384:9: sparse: sparse: context imbalance in 'flush_end_io' - unexpected unlock
Date: Fri, 04 Oct 2019 10:03:09 +0200
Message-ID: <20191004080309.GA27510@kroah.com>
In-Reply-To: <d9eb220f-517f-6f19-6423-7399153428c9@kernel.dk>
List-Id: <oe-kbuild-all.lists.linux.dev>

--===============0130903230659697640==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 03, 2019 at 08:33:38PM -0600, Jens Axboe wrote:
> On 10/3/19 8:20 PM, kbuild test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-st=
able-rc.git linux-4.19.y
> > head:   45830aebf3fc94937285ed325fdb97043f6b6108
> > commit: 9afbbbbab3cd79e3aa14edd4c6269e89eab79343 [7762/7788] block: fix=
 null pointer dereference in blk_mq_rq_timed_out()
> > reproduce:
> >          # apt-get install sparse
> >          # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty
> >          git checkout 9afbbbbab3cd79e3aa14edd4c6269e89eab79343
> >          make ARCH=3Dx86_64 allmodconfig
> >          make C=3D1 CF=3D'-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> > =

> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> > =

> > =

> > sparse warnings: (new ones prefixed by >>)
> > =

> >>> include/linux/spinlock.h:384:9: sparse: sparse: context imbalance in =
'flush_end_io' - unexpected unlock
> > =

> > vim +/flush_end_io +384 include/linux/spinlock.h
> > =

> > c2f21ce2e31286 Thomas Gleixner 2009-12-02  381
> > 3490565b633c70 Denys Vlasenko  2015-07-13  382  static __always_inline =
void spin_unlock_irqrestore(spinlock_t *lock, unsigned long flags)
> > c2f21ce2e31286 Thomas Gleixner 2009-12-02  383  {
> > c2f21ce2e31286 Thomas Gleixner 2009-12-02 @384  	raw_spin_unlock_irqres=
tore(&lock->rlock, flags);
> > c2f21ce2e31286 Thomas Gleixner 2009-12-02  385  }
> > c2f21ce2e31286 Thomas Gleixner 2009-12-02  386
> =

> This report looks bogus - both for mainline, and I checked that the 4.19
> backport is correct too.

Thanks for testing and verifying that this is sane.

greg k-h
--===============0130903230659697640==--