All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pascal Terjan <pterjan@google.com>
Cc: Jiri Slaby <jslaby@suse.com>,
	linux-serial@vger.kernel.org, linux-m68k@lists.linux-m68k.org
Subject: Re: [PATCH] Remove every trace of SERIAL_MAGIC
Date: Fri, 4 Oct 2019 15:22:56 +0200	[thread overview]
Message-ID: <20191004132256.GA715053@kroah.com> (raw)
In-Reply-To: <20191004132001.99027-1-pterjan@google.com>

On Fri, Oct 04, 2019 at 02:20:01PM +0100, Pascal Terjan wrote:
> The only code mentioning it doesn't build (and hasn't at least since git)
> and doesn't include the header defining it.
> 
> This means removing support for checking magic in amiserial.c
> (SERIAL_PARANOIA_CHECK option), which was checking a magic field which
> doesn't currently exist in the struct.
> 
> Signed-off-by: Pascal Terjan <pterjan@google.com>
> ---
>  Documentation/process/magic-number.rst        |  1 -
>  .../it_IT/process/magic-number.rst            |  1 -
>  .../zh_CN/process/magic-number.rst            |  1 -
>  drivers/net/wan/z85230.h                      |  2 -
>  drivers/tty/amiserial.c                       | 81 +------------------
>  5 files changed, 1 insertion(+), 85 deletions(-)

What changed from the first version?

Always version your patches and properly put what changed below the ---
line.  Like the documentation says to do :)

v3 please?

thanks,

greg k-h

  reply	other threads:[~2019-10-04 13:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27 20:55 [PATCH] Remove every trace of SERIAL_MAGIC Pascal Terjan
2019-10-04 12:45 ` Greg Kroah-Hartman
2019-10-04 13:20   ` Pascal Terjan
2019-10-04 13:22     ` Greg Kroah-Hartman [this message]
2019-11-04 19:35       ` [PATCH v3] " Pascal Terjan
2019-11-05  8:42         ` Geert Uytterhoeven
2019-11-05 19:27           ` [PATCH v4] " Pascal Terjan
2019-10-04 13:29     ` [PATCH] " John Paul Adrian Glaubitz
     [not found]       ` <CAANdO=LB1=i6qKt+J6yBXg9EaPJ66yZ_bkd96hftKkcR0Ee06w@mail.gmail.com>
2019-10-04 13:36         ` John Paul Adrian Glaubitz
2019-10-04 13:37       ` Pascal Terjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191004132256.GA715053@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=pterjan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.