All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] uacme: fix c99 detection on microblazeel, powerpc
Date: Fri, 4 Oct 2019 13:45:00 +0200	[thread overview]
Message-ID: <20191004134500.520a3437@windsurf> (raw)
In-Reply-To: <20191004095315.g6arwc7yy46c4o6u@einstein.dilieto.eu>

Hello Nicola,

On Fri, 4 Oct 2019 11:53:15 +0200
Nicola Di Lieto <nicola.dilieto@gmail.com> wrote:

> Fixes:
> 
> microblazeel http://autobuild.buildroot.net/results/bc715a2f53f72630ae13e3d226e6a029915c4ee4
> powerpc      http://autobuild.buildroot.net/results/07d5e454ffd11527d70268681fe15e9de77379e4
> 
> Signed-off-by: Nicola Di Lieto <nicola.dilieto@gmail.com>
> ---
>  package/uacme/uacme.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/uacme/uacme.mk b/package/uacme/uacme.mk
> index 999cc36..c920a90 100644
> --- a/package/uacme/uacme.mk
> +++ b/package/uacme/uacme.mk
> @@ -13,6 +13,10 @@ UACME_LICENSE = GPL-3.0+
>  UACME_LICENSE_FILES = COPYING
>  UACME_DEPENDENCIES = libcurl
>  
> +ifneq (,$(filter $(ARCH),microblazeel powerpc))
> +UACME_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'
> +endif

This is not correct: as I told you privately, this issue is not at all
related to Microblaze or PowerPC architectures, but it's related to the
toolchain lacking wide-char support, and the AC_PROG_CC_C99 macro
testing C99 support using wide-char, even if in the end the package
doesn't need wchar support. You can try yourself: build an ARM
configuration without wide-char support, and you should get the same
problem.

So, the commit title should be:

	package/uacme: fix c99 detection on !wchar toolchains

and the code should be just:

UACME_CONF_ENV = ac_cv_prog_cc_c99='-std=gnu99'

i.e, unconditional.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-10-04 11:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-04  9:53 [Buildroot] [PATCH 1/1] uacme: fix c99 detection on microblazeel, powerpc Nicola Di Lieto
2019-10-04 11:45 ` Thomas Petazzoni [this message]
2019-10-04 13:27   ` Nicola Di Lieto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191004134500.520a3437@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.