From: Kalle Valo <kvalo@codeaurora.org>
To: <yhchuang@realtek.com>
Cc: <linux-wireless@vger.kernel.org>, <briannorris@chromium.org>
Subject: Re: [PATCH 01/14] rtw88: check firmware leave lps successfully
Date: Fri, 4 Oct 2019 13:45:40 +0000 (UTC) [thread overview]
Message-ID: <20191004134540.5303761A41@smtp.codeaurora.org> (raw)
In-Reply-To: <20191002063531.18135-2-yhchuang@realtek.com>
<yhchuang@realtek.com> wrote:
> From: Chin-Yen Lee <timlee@realtek.com>
>
> Driver needs to wait for firmware to restore hardware setting
> to active mode after leaving lps.
>
> After getting H2C from driver for leaving lps, firmware will
> issue null packet without PS bit to inform AP driver is active,
> and then restore REG_TCR Register if AP has receiced null packet.
>
> But the transmission of null packet may cost much more time
> in noisy environment. If driver does not wait for firmware,
> null packet with PS bit could be sent due to incorrect REG_TCR setting.
> And AP will be confused.
>
> In our test, 100ms is enough for firmware to send null packet
> to AP. If REG_TCR Register is still wrong after 100ms, we will
> modify it directly, force the PS bit to be cleared
>
> Signed-off-by: Chin-Yen Lee <timlee@realtek.com>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
14 patches applied to wireless-drivers-next.git, thanks.
3a2dd6b7cadf rtw88: check firmware leave lps successfully
942e2a5d39a9 rtw88: allows to set RTS in TX descriptor
3745d3e550d1 rtw88: add driver TX queue support
46ebb1743f33 rtw88: take over rate control from mac80211
699c7730cf23 rtw88: report tx rate to mac80211 stack
127eef1d46f8 rtw88: add TX-AMSDU support
1131ad7fe575 rtw88: flush hardware tx queues
c3594559f49c rtw88: fix beaconing mode rsvd_page memory violation issue
0649ff58a0f6 rtw88: Don't set RX_FLAG_DECRYPTED if packet has no encryption
bf06c7ec4508 rtw88: configure TX queue EDCA parameters
bc3696e0a436 rtw88: raise firmware version debug level
cc20a7139836 rtw88: use struct rtw_fw_hdr to access firmware header
4f5bb7ff8b8d rtw88: fix NSS of hw_cap
f4268729eb1e rtw88: fix error handling when setup efuse info
--
https://patchwork.kernel.org/patch/11170463/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-04 13:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 6:35 [PATCH 00/14] rtw88: add software TX queue support yhchuang
2019-10-02 6:35 ` [PATCH 01/14] rtw88: check firmware leave lps successfully yhchuang
2019-10-04 13:45 ` Kalle Valo [this message]
2019-10-02 6:35 ` [PATCH 02/14] rtw88: allows to set RTS in TX descriptor yhchuang
2019-10-02 6:35 ` [PATCH 03/14] rtw88: add driver TX queue support yhchuang
2019-10-02 6:35 ` [PATCH 04/14] rtw88: take over rate control from mac80211 yhchuang
2019-10-02 6:35 ` [PATCH 05/14] rtw88: report tx rate to mac80211 stack yhchuang
2019-10-02 6:35 ` [PATCH 06/14] rtw88: add TX-AMSDU support yhchuang
2019-10-02 6:35 ` [PATCH 07/14] rtw88: flush hardware tx queues yhchuang
2019-10-02 6:35 ` [PATCH 08/14] rtw88: fix beaconing mode rsvd_page memory violation issue yhchuang
2019-10-02 6:35 ` [PATCH 09/14] rtw88: Don't set RX_FLAG_DECRYPTED if packet has no encryption yhchuang
2019-10-02 6:35 ` [PATCH 10/14] rtw88: configure TX queue EDCA parameters yhchuang
2019-10-02 6:35 ` [PATCH 11/14] rtw88: raise firmware version debug level yhchuang
2019-10-02 6:35 ` [PATCH 12/14] rtw88: use struct rtw_fw_hdr to access firmware header yhchuang
2019-10-02 6:35 ` [PATCH 13/14] rtw88: fix NSS of hw_cap yhchuang
2019-10-02 6:35 ` [PATCH 14/14] rtw88: fix error handling when setup efuse info yhchuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004134540.5303761A41@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.