From: Kalle Valo <kvalo@codeaurora.org>
To: Denis Efremov <efremov@linux.com>
Cc: linux-wireless@vger.kernel.org, Denis Efremov <efremov@linux.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Amitkumar Karwar <amitkarwar@gmail.com>,
Siva Rebbagondla <siva8118@gmail.com>
Subject: Re: [PATCH] rsi: fix potential null dereference in rsi_probe()
Date: Fri, 4 Oct 2019 13:47:36 +0000 (UTC) [thread overview]
Message-ID: <20191004134736.2D517619F4@smtp.codeaurora.org> (raw)
In-Reply-To: <20191002171811.23993-1-efremov@linux.com>
Denis Efremov <efremov@linux.com> wrote:
> The id pointer can be NULL in rsi_probe(). It is checked everywhere except
> for the else branch in the idProduct condition. The patch adds NULL check
> before the id dereference in the rsi_dbg() call.
>
> Fixes: 54fdb318c111 ("rsi: add new device model for 9116")
> Cc: Amitkumar Karwar <amitkarwar@gmail.com>
> Cc: Siva Rebbagondla <siva8118@gmail.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Signed-off-by: Denis Efremov <efremov@linux.com>
Patch applied to wireless-drivers-next.git, thanks.
f170d44bc4ec rsi: fix potential null dereference in rsi_probe()
--
https://patchwork.kernel.org/patch/11171695/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-04 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 17:18 [PATCH] rsi: fix potential null dereference in rsi_probe() Denis Efremov
2019-10-04 13:47 ` Kalle Valo [this message]
2019-10-04 14:49 ` Johan Hovold
2019-10-06 8:22 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004134736.2D517619F4@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=amitkarwar@gmail.com \
--cc=efremov@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=siva8118@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.