From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH] mfd: mt6397: fix probe after changing mt6397-core Date: Fri, 4 Oct 2019 16:20:01 +0100 Message-ID: <20191004152001.GS18429@dell> References: <20191003185323.24646-1-frank-w@public-files.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20191003185323.24646-1-frank-w@public-files.de> Sender: linux-kernel-owner@vger.kernel.org To: Frank Wunderlich Cc: Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Hsin-Hsiung Wang List-Id: linux-mediatek@lists.infradead.org On Thu, 03 Oct 2019, Frank Wunderlich wrote: > Part 3 from this series [1] was not merged due to wrong splitting > and breaks mt6323 pmic on bananapi-r2 > > dmesg prints this line and at least switch is not initialized on bananapi-r2 > > mt6397 1000d000.pwrap:mt6323: unsupported chip: 0x0 > > this patch contains only the probe-changes and chip_data structs > from original part 3 by Hsin-Hsiung Wang > > Fixes: a4872e80ce7d2a1844328176dbf279d0a2b89bdb mfd: mt6397: Extract IRQ related code from core driver > > [1] https://patchwork.kernel.org/project/linux-mediatek/list/?series=164155 > > Signed-off-by: Frank Wunderlich > --- > drivers/mfd/mt6397-core.c | 64 ++++++++++++++++++++++++--------------- > 1 file changed, 40 insertions(+), 24 deletions(-) > > diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c > index 310dae26ddff..b2c325ead1c8 100644 > --- a/drivers/mfd/mt6397-core.c > +++ b/drivers/mfd/mt6397-core.c > @@ -129,11 +129,27 @@ static int mt6397_irq_resume(struct device *dev) > static SIMPLE_DEV_PM_OPS(mt6397_pm_ops, mt6397_irq_suspend, > mt6397_irq_resume); > > +struct chip_data { > + u32 cid_addr; > + u32 cid_shift; > +}; > + > +static const struct chip_data mt6323_core = { > + .cid_addr = MT6323_CID, > + .cid_shift = 0, > +}; > + > +static const struct chip_data mt6397_core = { > + .cid_addr = MT6397_CID, > + .cid_shift = 0, > +}; Will there be other devices which have a !0 CID shift? -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 441B2C47404 for ; Fri, 4 Oct 2019 15:20:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15137207FF for ; Fri, 4 Oct 2019 15:20:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SbDW/uUY"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wG0VPxdd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15137207FF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cLNWerIYc3vZIloqtcU9HJ4RE7/0QfdhY1hsAdMMg9U=; b=SbDW/uUY5Smtfk WSTiNZVBdIVS5+wPg/L/2fzCuGZfwHFICu03Qu3HYsyhRReAxj+76iS/EfD6AbsEBLgcotN8G5WVC goLoQz1MjKpfklrud61XJbBEztgRpdQ9/UFRBwujP7znsRN1DXxXWci+EVh5e2HujnNarzCLgew9M myjtvt9CYunCo/yFgc87rV54+mDd3w3lfCGVHLizd8kWi8VonSCskcGcM3mmdnwFGK1260sb0BI3/ ojEdPGbgjk90AxI27mTNwjzxRkrPr7n3zIDWnq502GVDNsnJc+8wmyKMEd9Yo21mXtMXD/F0UfoXS Av780hlCu1krnf7VHUDQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGPNK-0002nW-KO; Fri, 04 Oct 2019 15:20:10 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGPNE-0001wf-PV for linux-arm-kernel@lists.infradead.org; Fri, 04 Oct 2019 15:20:06 +0000 Received: by mail-wm1-x342.google.com with SMTP id a6so6230703wma.5 for ; Fri, 04 Oct 2019 08:20:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=bDywciZgx2XBGKysVl4djWbACpcmiGhqyGWzjzvget0=; b=wG0VPxddvftgOPz6T+sh3Kvv8RV2sb78no+PMklHkJL91sU4fZPTyyaMJ3b31wBzej VS5o5TugsO5A4Zgn99Csy0O4H3yFh3IkiDvOl4jyYUXKx8wfkGUO+R6E1ryfnDowdWGb 5QgUfu5g4roLTjGyhmh/9FLlGNFfzyJKcy5ZlWIEMWnOVotjdnlSw9IhPXCwD3W2mlCh B++WBkCAtDVLHGQfARaI9j3d9vp5e2IExBnXFh3eiWWpUrpdnHal7b2VvQ53/IyGZqu2 xNlMyHy8WfjkwiR3ib0uLFl1PHZNmq6paAbCVWGRvaSTkybjLNiGrG9OshVHYsonJVli 2SNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=bDywciZgx2XBGKysVl4djWbACpcmiGhqyGWzjzvget0=; b=qXaemaMJw/QfDdmWFdFTXP7Teq1SWmu0QbR3R23vZNTx/x92ihn08GinVRoqWZxr+9 GbUHB2xDHVsfseYKuilxF4A14LyQGoptBf8b7J1AF/Ry77+avoLlfDdIFlFsNpoJ6UwT oAlqJujZctvp9PTW+3G5fBUDCL8kXZuq5nSsVav+aCRsQUSkN4g/9i1JkatWdLZhBiBk Qr12RKGUhVPBL/GJygUFcze4k/YnmEBRhEX/4NJradKpYgpoKtnAwG/+3zT4l4Sb1shZ /lOT9kMFf1isiyrXpBJ78J3SX6niK34GbmWS5/jBxQ3aa6AZVkoVMFPSo3Ir2zDCFFxx zZ2w== X-Gm-Message-State: APjAAAVuadG2m09rtCYCSHduSsb55CPj2kNIYjm4ZfiBOW1B7jI0lJko kRwArSyPuRvT1oD4R0SXl97+Iw== X-Google-Smtp-Source: APXvYqxyD6R17KEDZ64D+fBYHZNEsDDN6y+McbrzItzC/6eM7CB0KbH4SCq9b8P2XLWzF4La+9P++A== X-Received: by 2002:a1c:a853:: with SMTP id r80mr11007913wme.140.1570202402906; Fri, 04 Oct 2019 08:20:02 -0700 (PDT) Received: from dell ([2.27.167.122]) by smtp.gmail.com with ESMTPSA id y8sm7689041wrm.64.2019.10.04.08.20.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Oct 2019 08:20:02 -0700 (PDT) Date: Fri, 4 Oct 2019 16:20:01 +0100 From: Lee Jones To: Frank Wunderlich Subject: Re: [PATCH] mfd: mt6397: fix probe after changing mt6397-core Message-ID: <20191004152001.GS18429@dell> References: <20191003185323.24646-1-frank-w@public-files.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191003185323.24646-1-frank-w@public-files.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191004_082004_841142_4A3E8980 X-CRM114-Status: GOOD ( 16.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Matthias Brugger , Hsin-Hsiung Wang , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwMyBPY3QgMjAxOSwgRnJhbmsgV3VuZGVybGljaCB3cm90ZToKCj4gUGFydCAzIGZy b20gdGhpcyBzZXJpZXMgWzFdIHdhcyBub3QgbWVyZ2VkIGR1ZSB0byB3cm9uZyBzcGxpdHRpbmcK PiBhbmQgYnJlYWtzIG10NjMyMyBwbWljIG9uIGJhbmFuYXBpLXIyCj4gCj4gZG1lc2cgcHJpbnRz IHRoaXMgbGluZSBhbmQgYXQgbGVhc3Qgc3dpdGNoIGlzIG5vdCBpbml0aWFsaXplZCBvbiBiYW5h bmFwaS1yMgo+IAo+IG10NjM5NyAxMDAwZDAwMC5wd3JhcDptdDYzMjM6IHVuc3VwcG9ydGVkIGNo aXA6IDB4MAo+IAo+IHRoaXMgcGF0Y2ggY29udGFpbnMgb25seSB0aGUgcHJvYmUtY2hhbmdlcyBh bmQgY2hpcF9kYXRhIHN0cnVjdHMKPiBmcm9tIG9yaWdpbmFsIHBhcnQgMyBieSBIc2luLUhzaXVu ZyBXYW5nCj4gCj4gRml4ZXM6IGE0ODcyZTgwY2U3ZDJhMTg0NDMyODE3NmRiZjI3OWQwYTJiODli ZGIgbWZkOiBtdDYzOTc6IEV4dHJhY3QgSVJRIHJlbGF0ZWQgY29kZSBmcm9tIGNvcmUgZHJpdmVy Cj4gCj4gWzFdIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC9saW51eC1tZWRp YXRlay9saXN0Lz9zZXJpZXM9MTY0MTU1Cj4gCj4gU2lnbmVkLW9mZi1ieTogRnJhbmsgV3VuZGVy bGljaCA8ZnJhbmstd0BwdWJsaWMtZmlsZXMuZGU+Cj4gLS0tCj4gIGRyaXZlcnMvbWZkL210NjM5 Ny1jb3JlLmMgfCA2NCArKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0KPiAg MSBmaWxlIGNoYW5nZWQsIDQwIGluc2VydGlvbnMoKyksIDI0IGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL21mZC9tdDYzOTctY29yZS5jIGIvZHJpdmVycy9tZmQvbXQ2Mzk3 LWNvcmUuYwo+IGluZGV4IDMxMGRhZTI2ZGRmZi4uYjJjMzI1ZWFkMWM4IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvbWZkL210NjM5Ny1jb3JlLmMKPiArKysgYi9kcml2ZXJzL21mZC9tdDYzOTctY29y ZS5jCj4gQEAgLTEyOSwxMSArMTI5LDI3IEBAIHN0YXRpYyBpbnQgbXQ2Mzk3X2lycV9yZXN1bWUo c3RydWN0IGRldmljZSAqZGV2KQo+ICBzdGF0aWMgU0lNUExFX0RFVl9QTV9PUFMobXQ2Mzk3X3Bt X29wcywgbXQ2Mzk3X2lycV9zdXNwZW5kLAo+ICAJCQltdDYzOTdfaXJxX3Jlc3VtZSk7Cj4gIAo+ ICtzdHJ1Y3QgY2hpcF9kYXRhIHsKPiArCXUzMiBjaWRfYWRkcjsKPiArCXUzMiBjaWRfc2hpZnQ7 Cj4gK307Cj4gKwo+ICtzdGF0aWMgY29uc3Qgc3RydWN0IGNoaXBfZGF0YSBtdDYzMjNfY29yZSA9 IHsKPiArCS5jaWRfYWRkciA9IE1UNjMyM19DSUQsCj4gKwkuY2lkX3NoaWZ0ID0gMCwKPiArfTsK PiArCj4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgY2hpcF9kYXRhIG10NjM5N19jb3JlID0gewo+ICsJ LmNpZF9hZGRyID0gTVQ2Mzk3X0NJRCwKPiArCS5jaWRfc2hpZnQgPSAwLAo+ICt9OwoKV2lsbCB0 aGVyZSBiZSBvdGhlciBkZXZpY2VzIHdoaWNoIGhhdmUgYSAhMCBDSUQgc2hpZnQ/CgotLSAKTGVl IEpvbmVzIFvmnY7nkLzmlq9dCkxpbmFybyBTZXJ2aWNlcyBUZWNobmljYWwgTGVhZApMaW5hcm8u b3JnIOKUgiBPcGVuIHNvdXJjZSBzb2Z0d2FyZSBmb3IgQVJNIFNvQ3MKRm9sbG93IExpbmFybzog RmFjZWJvb2sgfCBUd2l0dGVyIHwgQmxvZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=