From: Jesper Dangaard Brouer <brouer@redhat.com>
To: "Daniel T. Lee" <danieltimlee@gmail.com>
Cc: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
brouer@redhat.com
Subject: Re: [v4 1/4] samples: pktgen: make variable consistent with option
Date: Fri, 4 Oct 2019 15:41:12 +0200 [thread overview]
Message-ID: <20191004154112.7dda5cff@carbon> (raw)
In-Reply-To: <CAEKGpzj9WGepw4LPJeFhbtONYJyvLcO_ChnMRrEB5-BVTfKqMQ@mail.gmail.com>
On Fri, 4 Oct 2019 22:28:26 +0900
"Daniel T. Lee" <danieltimlee@gmail.com> wrote:
> On Fri, Oct 4, 2019 at 9:52 PM Jesper Dangaard Brouer <brouer@redhat.com> wrote:
> >
> >
> > On Fri, 4 Oct 2019 10:32:58 +0900 "Daniel T. Lee" <danieltimlee@gmail.com> wrote:
> >
> > > [...]
> >
>
> Thanks for the review!
>
> > A general comment, you forgot a cover letter for your patchset.
> >
>
> At first, I thought the size of the patchset (the feature to enhance)
> was small so
> I didn't include it with intent, but now it gets bigger and it seems
> necessary for cover letter.
>
> When the next version is needed, I'll include it.
>
> > And also forgot the "PATCH" part of subj. but patchwork still found it:
> > https://patchwork.ozlabs.org/project/netdev/list/?series=134102&state=2a
> >
>
> I'm not sure I'm following.
> Are you saying that the word "PATCH" should be included in prefix?
> $ git format-patch --subject-prefix="PATCH,v5"
> like this?
I would say "[PATCH net-next v5]" as you should also say which kernel
tree, in this case net-next.
All the rules are documented here:
https://www.kernel.org/doc/html/latest/process/index.html
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
This netdev list have it's own extra rules:
https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-10-04 13:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 1:32 [v4 1/4] samples: pktgen: make variable consistent with option Daniel T. Lee
2019-10-04 1:32 ` [v4 2/4] samples: pktgen: fix proc_cmd command result check logic Daniel T. Lee
2019-10-04 13:24 ` Jesper Dangaard Brouer
2019-10-04 15:11 ` Daniel T. Lee
2019-10-04 1:33 ` [v4 3/4] samples: pktgen: add helper functions for IP(v4/v6) CIDR parsing Daniel T. Lee
2019-10-04 1:33 ` [v4 4/4] samples: pktgen: allow to specify destination IP range (CIDR) Daniel T. Lee
2019-10-04 12:51 ` [v4 1/4] samples: pktgen: make variable consistent with option Jesper Dangaard Brouer
2019-10-04 13:28 ` Daniel T. Lee
2019-10-04 13:41 ` Jesper Dangaard Brouer [this message]
2019-10-04 13:46 ` Daniel T. Lee
[not found] ` <CAEKGpzhmkDBGV5BmwwYgb0ng+Eyyzp2CFoGeZ65aEgR=CxWnMg@mail.gmail.com>
2019-10-04 13:48 ` Toke Høiland-Jørgensen
2019-10-04 12:54 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004154112.7dda5cff@carbon \
--to=brouer@redhat.com \
--cc=danieltimlee@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.