From: Jason Gunthorpe <jgg@ziepe.ca>
To: Bernard Metzler <BMT@zurich.ibm.com>
Cc: Leon Romanovsky <leon@kernel.org>,
linux-rdma@vger.kernel.org, bharat@chelsio.com,
nirranjan@chelsio.com, krishna2@chelsio.com, bvanassche@acm.org
Subject: Re: Re: [[PATCH v2 for-next]] RDMA/siw: Fix SQ/RQ drain logic
Date: Fri, 4 Oct 2019 14:48:04 -0300 [thread overview]
Message-ID: <20191004174804.GF13988@ziepe.ca> (raw)
In-Reply-To: <OFA7E48CEB.393CBE8D-ON00258489.0047C07A-00258489.004DD109@notes.na.collabserv.com>
On Fri, Oct 04, 2019 at 02:09:57PM +0000, Bernard Metzler wrote:
> <...>
>
> >> *
> >> @@ -705,6 +746,12 @@ int siw_post_send(struct ib_qp *base_qp, const
> >struct ib_send_wr *wr,
> >> unsigned long flags;
> >> int rv = 0;
> >>
> >> + if (wr && !qp->kernel_verbs) {
> >
> >It is not related to this specific patch, but all siw "kernel_verbs"
> >should go, we have standard way to distinguish between kernel and
> >user
> >verbs.
> >
> >Thanks
> >
> Understood. I think we touched on that already.
> rdma core objects have a uobject pointer which
> is valid only if it belongs to a user land
> application. We might better use that.
No, the uobject pointer is not to be touched by drivers
Jason
next prev parent reply other threads:[~2019-10-04 17:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 14:38 [[PATCH v2 for-next]] RDMA/siw: Fix SQ/RQ drain logic Bernard Metzler
2019-10-02 15:47 ` Leon Romanovsky
2019-10-04 14:09 ` Bernard Metzler
2019-10-04 17:48 ` Jason Gunthorpe [this message]
2019-10-25 12:11 ` Bernard Metzler
2019-10-27 5:21 ` Leon Romanovsky
2019-10-28 12:37 ` Bernard Metzler
2019-10-28 13:43 ` Jason Gunthorpe
2019-10-29 4:54 ` Leon Romanovsky
2019-10-31 13:38 ` Bernard Metzler
2019-10-05 8:26 ` Leon Romanovsky
2019-10-18 13:50 ` Bernard Metzler
2019-10-22 5:49 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004174804.GF13988@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=BMT@zurich.ibm.com \
--cc=bharat@chelsio.com \
--cc=bvanassche@acm.org \
--cc=krishna2@chelsio.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.