From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.7 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 22E667D2F0 for ; Fri, 4 Oct 2019 23:31:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731345AbfJDXbj (ORCPT ); Fri, 4 Oct 2019 19:31:39 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:57293 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725730AbfJDXbj (ORCPT ); Fri, 4 Oct 2019 19:31:39 -0400 Received: from callcc.thunk.org (guestnat-104-133-0-98.corp.google.com [104.133.0.98] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x94NTuAQ024308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 4 Oct 2019 19:29:57 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id CCF8D42088C; Fri, 4 Oct 2019 19:29:55 -0400 (EDT) Date: Fri, 4 Oct 2019 19:29:55 -0400 From: "Theodore Y. Ts'o" To: shuah Cc: Brendan Higgins , Linus Torvalds , Frank Rowand , Greg Kroah-Hartman , Josh Poimboeuf , Kees Cook , kieran.bingham@ideasonboard.com, Luis Chamberlain , Peter Zijlstra , robh@kernel.org, Stephen Boyd , Masahiro Yamada , devicetree@vger.kernel.org, dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel , Linux Kbuild mailing list , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , Tim.Bird@sony.com, Amir Goldstein , Dan Carpenter , Daniel Vetter , jdike@addtoit.com, Joel Stanley , Julia Lawall , khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com Subject: Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework Message-ID: <20191004232955.GC12012@mit.edu> References: <20190923090249.127984-1-brendanhiggins@google.com> <20191004213812.GA24644@mit.edu> <56e2e1a7-f8fe-765b-8452-1710b41895bf@kernel.org> <20191004222714.GA107737@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Fri, Oct 04, 2019 at 04:47:09PM -0600, shuah wrote: > > However, if I encourage arbitrary tests/improvements into my KUnit > > branch, it further diverges away from torvalds/master, and is more > > likely that there will be a merge conflict or issue that is not related > > to the core KUnit changes that will cause the whole thing to be > > rejected again in v5.5. > > The idea is that the new development will happen based on kunit in > linux-kselftest next. It will work just fine. As we accepts patches, > they will go on top of kunit that is in linux-next now. I don't see how this would work. If I add unit tests to ext4, they would be in fs/ext4. And to the extent that I need to add test mocks to allow the unit tests to work, they will involve changes to existing files in fs/ext4. I can't put them in the ext4.git tree without pulling in the kunit changes into the ext4 git tree. And if they ext4 unit tests land in the kunit tree, it would be a receipe for large numbers of merge conflicts. - Ted From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23D42C4360C for ; Fri, 4 Oct 2019 23:31:05 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEA2320873 for ; Fri, 4 Oct 2019 23:31:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DEA2320873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=mit.edu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from new-ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3A04010FC3264; Fri, 4 Oct 2019 16:32:06 -0700 (PDT) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=18.9.28.11; helo=outgoing.mit.edu; envelope-from=tytso@mit.edu; receiver= Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CB98810FC3262 for ; Fri, 4 Oct 2019 16:32:03 -0700 (PDT) Received: from callcc.thunk.org (guestnat-104-133-0-98.corp.google.com [104.133.0.98] (may be forged)) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id x94NTuAQ024308 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 4 Oct 2019 19:29:57 -0400 Received: by callcc.thunk.org (Postfix, from userid 15806) id CCF8D42088C; Fri, 4 Oct 2019 19:29:55 -0400 (EDT) Date: Fri, 4 Oct 2019 19:29:55 -0400 From: "Theodore Y. Ts'o" To: shuah Subject: Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework Message-ID: <20191004232955.GC12012@mit.edu> References: <20190923090249.127984-1-brendanhiggins@google.com> <20191004213812.GA24644@mit.edu> <56e2e1a7-f8fe-765b-8452-1710b41895bf@kernel.org> <20191004222714.GA107737@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Message-ID-Hash: SHYEY33QC7DAX7Y7HDUEJPZX3SC3R7CW X-Message-ID-Hash: SHYEY33QC7DAX7Y7HDUEJPZX3SC3R7CW X-MailFrom: tytso@mit.edu X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Brendan Higgins , Linus Torvalds , Frank Rowand , Greg Kroah-Hartman , Josh Poimboeuf , Kees Cook , kieran.bingham@ideasonboard.com, Luis Chamberlain , Peter Zijlstra , robh@kernel.org, Stephen Boyd , Masahiro Yamada , devicetree@vger.kernel.org, dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel , Linux Kbuild mailing list , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , Tim.Bird@sony.com, Amir Goldstein , Dan Carpenter , Daniel Vetter , jdike@addtoit.com, Joel Stanley , Julia Lawall , khilman@baylibre.com, knut.omang@oracle.com, Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Oct 04, 2019 at 04:47:09PM -0600, shuah wrote: > > However, if I encourage arbitrary tests/improvements into my KUnit > > branch, it further diverges away from torvalds/master, and is more > > likely that there will be a merge conflict or issue that is not related > > to the core KUnit changes that will cause the whole thing to be > > rejected again in v5.5. > > The idea is that the new development will happen based on kunit in > linux-kselftest next. It will work just fine. As we accepts patches, > they will go on top of kunit that is in linux-next now. I don't see how this would work. If I add unit tests to ext4, they would be in fs/ext4. And to the extent that I need to add test mocks to allow the unit tests to work, they will involve changes to existing files in fs/ext4. I can't put them in the ext4.git tree without pulling in the kunit changes into the ext4 git tree. And if they ext4 unit tests land in the kunit tree, it would be a receipe for large numbers of merge conflicts. - Ted _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outgoing-auth-1.mit.edu ([18.9.28.11] helo=outgoing.mit.edu) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iGX2O-000331-Oz for linux-um@lists.infradead.org; Fri, 04 Oct 2019 23:31:06 +0000 Date: Fri, 4 Oct 2019 19:29:55 -0400 From: "Theodore Y. Ts'o" Subject: Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework Message-ID: <20191004232955.GC12012@mit.edu> References: <20190923090249.127984-1-brendanhiggins@google.com> <20191004213812.GA24644@mit.edu> <56e2e1a7-f8fe-765b-8452-1710b41895bf@kernel.org> <20191004222714.GA107737@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: shuah Cc: Petr Mladek , "open list:DOCUMENTATION" , Peter Zijlstra , Amir Goldstein , Brendan Higgins , dri-devel , Sasha Levin , Masahiro Yamada , Michael Ellerman , "open list:KERNEL SELFTEST FRAMEWORK" , Frank Rowand , robh@kernel.org, linux-nvdimm , khilman@baylibre.com, knut.omang@oracle.com, kieran.bingham@ideasonboard.com, wfg@linux.intel.com, Joel Stanley , David Rientjes , jdike@addtoit.com, Dan Carpenter , devicetree@vger.kernel.org, Linux Kbuild mailing list , Tim.Bird@sony.com, linux-um@lists.infradead.org, Steven Rostedt , Julia Lawall , Josh Poimboeuf , kunit-dev@googlegroups.com, logang@deltatee.com, Richard Weinberger , Stephen Boyd , Greg Kroah-Hartman , Randy Dunlap , Linux Kernel Mailing List , Luis Chamberlain , Daniel Vetter , Kees Cook , linux-fsdevel , Linus Torvalds On Fri, Oct 04, 2019 at 04:47:09PM -0600, shuah wrote: > > However, if I encourage arbitrary tests/improvements into my KUnit > > branch, it further diverges away from torvalds/master, and is more > > likely that there will be a merge conflict or issue that is not related > > to the core KUnit changes that will cause the whole thing to be > > rejected again in v5.5. > > The idea is that the new development will happen based on kunit in > linux-kselftest next. It will work just fine. As we accepts patches, > they will go on top of kunit that is in linux-next now. I don't see how this would work. If I add unit tests to ext4, they would be in fs/ext4. And to the extent that I need to add test mocks to allow the unit tests to work, they will involve changes to existing files in fs/ext4. I can't put them in the ext4.git tree without pulling in the kunit changes into the ext4 git tree. And if they ext4 unit tests land in the kunit tree, it would be a receipe for large numbers of merge conflicts. - Ted _______________________________________________ linux-um mailing list linux-um@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-um From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Theodore Y. Ts'o" Subject: Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework Date: Fri, 4 Oct 2019 19:29:55 -0400 Message-ID: <20191004232955.GC12012@mit.edu> References: <20190923090249.127984-1-brendanhiggins@google.com> <20191004213812.GA24644@mit.edu> <56e2e1a7-f8fe-765b-8452-1710b41895bf@kernel.org> <20191004222714.GA107737@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: shuah Cc: Petr Mladek , "open list:DOCUMENTATION" , Peter Zijlstra , Amir Goldstein , Brendan Higgins , dri-devel , Sasha Levin , Masahiro Yamada , Michael Ellerman , "open list:KERNEL SELFTEST FRAMEWORK" , Frank Rowand , linux-nvdimm , khilman@baylibre.com, knut.omang@oracle.com, kieran.bingham@ideasonboard.com, wfg@linux.intel.com, Joel Stanley , David Rientjes , jdike@addtoit.com, Dan Carpenter , devicetree@vger.kernel.org, Linux Kbuild mailing list , Tim.Bird@sony.comlinux- List-Id: devicetree@vger.kernel.org T24gRnJpLCBPY3QgMDQsIDIwMTkgYXQgMDQ6NDc6MDlQTSAtMDYwMCwgc2h1YWggd3JvdGU6Cj4g PiBIb3dldmVyLCBpZiBJIGVuY291cmFnZSBhcmJpdHJhcnkgdGVzdHMvaW1wcm92ZW1lbnRzIGlu dG8gbXkgS1VuaXQKPiA+IGJyYW5jaCwgaXQgZnVydGhlciBkaXZlcmdlcyBhd2F5IGZyb20gdG9y dmFsZHMvbWFzdGVyLCBhbmQgaXMgbW9yZQo+ID4gbGlrZWx5IHRoYXQgdGhlcmUgd2lsbCBiZSBh IG1lcmdlIGNvbmZsaWN0IG9yIGlzc3VlIHRoYXQgaXMgbm90IHJlbGF0ZWQKPiA+IHRvIHRoZSBj b3JlIEtVbml0IGNoYW5nZXMgdGhhdCB3aWxsIGNhdXNlIHRoZSB3aG9sZSB0aGluZyB0byBiZQo+ ID4gcmVqZWN0ZWQgYWdhaW4gaW4gdjUuNS4KPiAKPiBUaGUgaWRlYSBpcyB0aGF0IHRoZSBuZXcg ZGV2ZWxvcG1lbnQgd2lsbCBoYXBwZW4gYmFzZWQgb24ga3VuaXQgaW4KPiBsaW51eC1rc2VsZnRl c3QgbmV4dC4gSXQgd2lsbCB3b3JrIGp1c3QgZmluZS4gQXMgd2UgYWNjZXB0cyBwYXRjaGVzLAo+ IHRoZXkgd2lsbCBnbyBvbiB0b3Agb2Yga3VuaXQgdGhhdCBpcyBpbiBsaW51eC1uZXh0IG5vdy4K CkkgZG9uJ3Qgc2VlIGhvdyB0aGlzIHdvdWxkIHdvcmsuICBJZiBJIGFkZCB1bml0IHRlc3RzIHRv IGV4dDQsIHRoZXkKd291bGQgYmUgaW4gZnMvZXh0NC4gIEFuZCB0byB0aGUgZXh0ZW50IHRoYXQg SSBuZWVkIHRvIGFkZCB0ZXN0IG1vY2tzCnRvIGFsbG93IHRoZSB1bml0IHRlc3RzIHRvIHdvcmss IHRoZXkgd2lsbCBpbnZvbHZlIGNoYW5nZXMgdG8gZXhpc3RpbmcKZmlsZXMgaW4gZnMvZXh0NC4g IEkgY2FuJ3QgcHV0IHRoZW0gaW4gdGhlIGV4dDQuZ2l0IHRyZWUgd2l0aG91dApwdWxsaW5nIGlu IHRoZSBrdW5pdCBjaGFuZ2VzIGludG8gdGhlIGV4dDQgZ2l0IHRyZWUuICBBbmQgaWYgdGhleSBl eHQ0CnVuaXQgdGVzdHMgbGFuZCBpbiB0aGUga3VuaXQgdHJlZSwgaXQgd291bGQgYmUgYSByZWNl aXBlIGZvciBsYXJnZQpudW1iZXJzIG9mIG1lcmdlIGNvbmZsaWN0cy4KCgkJCQkJCS0gVGVkCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==