All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Angus Ainslie <angus@akkea.ca>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
	knaack.h@gmx.de, lars@metafoo.de, tomas@novotny.cz,
	linux-iio@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/2] iio: light: add missing vcnl4040 of_compatible
Date: Sat, 5 Oct 2019 13:30:06 +0100	[thread overview]
Message-ID: <20191005133006.4fc6c0a5@archlinux> (raw)
In-Reply-To: <a93e2e861ac7f2473a05929f4511bfa0@akkea.ca>

On Wed, 18 Sep 2019 07:47:31 -0700
Angus Ainslie <angus@akkea.ca> wrote:

> On 2019-09-17 07:56, Marco Felsch wrote:
> > Commit 5a441aade5b3 ("iio: light: vcnl4000 add support for the VCNL4040
> > proximity and light sensor") added the support for the vcnl4040 but
> > forgot to add the of_compatible. Fix this by adding it now.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>  
> 
> Reviewed-by: Angus Ainslie (Purism) angus@akkea.ca
I turned the above note on what missed this into a fixes tag and 
marked it for stable.  It's no a particularly critical fix, but it
is fairly trivial and very unlikely to have side effects so lets
get it tidied up everywhere.

Thanks,

Jonathan
 
> 
> > ---
> >  drivers/iio/light/vcnl4000.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/iio/light/vcnl4000.c 
> > b/drivers/iio/light/vcnl4000.c
> > index f522cb863e8c..16dacea9eadf 100644
> > --- a/drivers/iio/light/vcnl4000.c
> > +++ b/drivers/iio/light/vcnl4000.c
> > @@ -408,6 +408,10 @@ static const struct of_device_id 
> > vcnl_4000_of_match[] = {
> >  		.compatible = "vishay,vcnl4020",
> >  		.data = (void *)VCNL4010,
> >  	},
> > +	{
> > +		.compatible = "vishay,vcnl4040",
> > +		.data = (void *)VCNL4040,
> > +	},
> >  	{
> >  		.compatible = "vishay,vcnl4200",
> >  		.data = (void *)VCNL4200,  


  reply	other threads:[~2019-10-05 12:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-17 14:56 [PATCH 1/2] iio: light: fix vcnl4000 devicetree hooks Marco Felsch
2019-09-17 14:56 ` [PATCH 2/2] iio: light: add missing vcnl4040 of_compatible Marco Felsch
2019-09-18 14:47   ` Angus Ainslie
2019-10-05 12:30     ` Jonathan Cameron [this message]
2019-09-18 14:46 ` [PATCH 1/2] iio: light: fix vcnl4000 devicetree hooks Angus Ainslie
2019-10-05 12:27   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191005133006.4fc6c0a5@archlinux \
    --to=jic23@kernel.org \
    --cc=angus@akkea.ca \
    --cc=kernel@pengutronix.de \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=tomas@novotny.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.