From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Kamel Bouhara <kamel.bouhara@bootlin.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
linux-arm-kernel@lists.infradead.org,
Tudor Ambarus <tudor.ambarus@microchip.com>
Subject: Re: [PATCH v6] soc: at91: Add Atmel SFR SN (Serial Number) support
Date: Sat, 5 Oct 2019 21:57:10 +0200 [thread overview]
Message-ID: <20191005195710.GA4254@piout.net> (raw)
In-Reply-To: <20191004151802.21793-1-kamel.bouhara@bootlin.com>
On 04/10/2019 17:18:02+0200, Kamel Bouhara wrote:
> Add support to read SFR's read-only registers providing the SoC
> Serial Numbers (SN0+SN1) to userspace.
>
> ~ # hexdump -n 8 -e'"%d\n"' /sys/bus/nvmem/devices/atmel-sfr0/nvmem
> 959527243
> 371539274
>
> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
> Tested-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
> ---
> Changes in v2:
> - updated atmel-sfr.c to sfr.c in Makefile
> - fixed missing drvdata struct definition
> - added missing syscon header
> Changes in v3:
> - Fixed typo: processor in Kconfig
> - Renamed private struct sfr_priv to atmel_sfr_priv
> - Dropped the drvdata structure as we have same size for both SN
> registers in SAMA5D2/4, just hardcoded it for now.
> - Cleaned up private struct from unused members
> - Fixed misusage of devm_kzalloc
> Changes in v5:
> - Removed the blankline at EOF
> - Feeded the entropy pool with the SoC SN using add_device_randomness()
> and do it only once at probe().
> Changes in v6:
> - Fixed missing return of a possible error from atmel_sfr_read()
> - Added T-b and R-b tags
>
> drivers/soc/atmel/Kconfig | 11 +++++
> drivers/soc/atmel/Makefile | 1 +
> drivers/soc/atmel/sfr.c | 99 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 111 insertions(+)
> create mode 100644 drivers/soc/atmel/sfr.c
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-10-05 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 15:18 [PATCH v6] soc: at91: Add Atmel SFR SN (Serial Number) support Kamel Bouhara
2019-10-05 19:57 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191005195710.GA4254@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=kamel.bouhara@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ludovic.desroches@microchip.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.