All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Le Bihan <eric.le.bihan.dev@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/ripgrep: new package
Date: Sun, 6 Oct 2019 17:56:49 +0200	[thread overview]
Message-ID: <20191006155649.GD5258@ned> (raw)
In-Reply-To: <20191003003146.942555-1-sam.voss@gmail.com>

Hi!

On 2019-10-02 19:31, sam.voss at gmail.com wrote:
> From: Sam Voss <sam.voss@gmail.com>
>
> Signed-off-by: Sam Voss <sam.voss@gmail.com>
> ---
> Changes v1 -> v2:
>   - Fix depends-on values
>   - Add hash for license files
>   - Make indentation consistant

A bit late, but LGTM. In my own version [1], I added
'--jobs=$(PARALLEL_JOBS)' to $(RIPGREP_CARGO_OPTS), but in the end, it
seems useless.

Now that there is one package using Cargo in Buildroot, should the
pkg-cargo infrastructure be added?

[1] https://github.com/elebihan/br2-ext-rust/tree/master/package/ripgrep

Regards,

--
ELB

  parent reply	other threads:[~2019-10-06 15:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-03  0:31 [Buildroot] [PATCH v2] package/ripgrep: new package sam.voss at gmail.com
2019-10-05 21:45 ` Thomas Petazzoni
2019-10-06 15:56 ` Eric Le Bihan [this message]
2019-10-06 19:02   ` Sam Voss
2019-10-07 20:59   ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191006155649.GD5258@ned \
    --to=eric.le.bihan.dev@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.