From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6991AC4360C for ; Sun, 6 Oct 2019 23:44:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3EFF720867 for ; Sun, 6 Oct 2019 23:44:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="EFW2CMar" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726000AbfJFXoy (ORCPT ); Sun, 6 Oct 2019 19:44:54 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40370 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726491AbfJFXox (ORCPT ); Sun, 6 Oct 2019 19:44:53 -0400 Received: by mail-pf1-f194.google.com with SMTP id x127so7463306pfb.7 for ; Sun, 06 Oct 2019 16:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Db+NewJuq9xBTnsJpKUfmZtRSZSczRlD9ss2URKSPvE=; b=EFW2CMarDNX+CDe08d7d90jUqxBgJ56dXrrUtVA64eKS5W/s2PyGt/ioG/268jMG5/ FLV580dtnZjzj1R1HBDlOibXUCU1aRlZ3g3BjTN6Mkym1711Pehv33aswmesnwT2EJav a4LzCXz2nwKX+sdUSStIGsXwsDpxMeybzcEiQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Db+NewJuq9xBTnsJpKUfmZtRSZSczRlD9ss2URKSPvE=; b=YqgA+rtHFDYnH5zNJwzOo3csxiudGdUgB0B/rWGZUdMP5oZ+K+8NyWJMxi5E7/FmCI neWTSN8oG8gwCTZwpw8/KYvMrfREzuK48XS0UZrdSxPEZkLFmLXGM4qhfDrXWGLU0raa dkwrjBrbhgYl0tu10mYThVLpWGBKIPbDmrVp25Cocra8dHXZUBcYd915NGszdqw9TDxN 8T4aSctCQtnSpeG+x46V8OX1Pp8MjcWNYcZx8wKSD0pE30MrLOPw9lXCjI2gSQ+NrSpN /UJowelnTSme88PaWjw8r3hsZbe29cNW5LDqUc78owh8xNE3ricML4z/BuyUy4lIcswn pDMw== X-Gm-Message-State: APjAAAV2Z3n0EKcHOkNrS2YsEfYuyOCJCOePF+pzTjLevnJtnddkIyha ptkkoVFsWhVPGrqktlUsGEjQ7A== X-Google-Smtp-Source: APXvYqyiCQIPrme0B2WFaLqwuh9sQyceaZD5oJjwPK2yC9iskOqxsWWOyRaFgUdY6BnXQ8AVqw8oNg== X-Received: by 2002:a62:db84:: with SMTP id f126mr30458639pfg.25.1570405492270; Sun, 06 Oct 2019 16:44:52 -0700 (PDT) Received: from localhost ([2620:15c:6:12:9c46:e0da:efbf:69cc]) by smtp.gmail.com with ESMTPSA id y36sm2033543pgk.66.2019.10.06.16.44.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Oct 2019 16:44:51 -0700 (PDT) Date: Sun, 6 Oct 2019 19:44:50 -0400 From: Joel Fernandes To: "Paul E. McKenney" Cc: Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , rcu@vger.kernel.org, Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rculist: Describe variadic macro argument in a Sphinx-compatible way Message-ID: <20191006234450.GA2711@google.com> References: <20191004215402.28008-1-j.neuschaefer@gmx.net> <20191004222439.GR2689@paulmck-ThinkPad-P72> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191004222439.GR2689@paulmck-ThinkPad-P72> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: rcu-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: rcu@vger.kernel.org On Fri, Oct 04, 2019 at 03:24:39PM -0700, Paul E. McKenney wrote: > On Fri, Oct 04, 2019 at 11:54:02PM +0200, Jonathan Neuschäfer wrote: > > Without this patch, Sphinx shows "variable arguments" as the description > > of the cond argument, rather than the intended description, and prints > > the following warnings: > > > > ./include/linux/rculist.h:374: warning: Excess function parameter 'cond' description in 'list_for_each_entry_rcu' > > ./include/linux/rculist.h:651: warning: Excess function parameter 'cond' description in 'hlist_for_each_entry_rcu' > > > > Signed-off-by: Jonathan Neuschäfer > > Applied for testing and review, thank you! > > Joel, does this look sane to you? Sorry for late reply due to weekend. Yes, looks good to me. thanks, - Joel