From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============4761582698182670983=="
MIME-Version: 1.0
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: kbuild-all@lists.01.org
Subject: Re: [staging:staging-testing 41/59] drivers/staging/wfx/main.c:47:14-21: ERROR: PTR_ERR applied after initialization to constant on line 42
Date: Mon, 07 Oct 2019 10:57:47 +0200
Message-ID: <20191007085747.GA356447@kroah.com>
In-Reply-To: <3767201.AobC1b7GVW@pc-42>
List-Id: <oe-kbuild-all.lists.linux.dev>

--===============4761582698182670983==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 07, 2019 at 08:36:22AM +0000, Jerome Pouiller wrote:
> On Friday 4 October 2019 12:48:32 CEST kbuild test robot wrote:
> [...]
> > >> drivers/staging/wfx/main.c:47:14-21: ERROR: PTR_ERR applied after in=
itialization to constant on line 42
> > =

> > vim +47 drivers/staging/wfx/main.c
> > =

> >     30
> >     31  struct gpio_desc *wfx_get_gpio(struct device *dev, int override=
, const char *label)
> >     32  {
> >     33          struct gpio_desc *ret;
> >     34          char label_buf[256];
> >     35
> >     36          if (override >=3D 0) {
> >     37                  snprintf(label_buf, sizeof(label_buf), "wfx_%s"=
, label);
> >     38                  ret =3D ERR_PTR(devm_gpio_request_one(dev, over=
ride, GPIOF_OUT_INIT_LOW, label_buf));
> >     39                  if (!ret)
> >     40                          ret =3D gpio_to_desc(override);
> >     41          } else if (override =3D=3D -1) {
> >   > 42                  ret =3D NULL;
> >     43          } else {
> >     44                  ret =3D devm_gpiod_get(dev, label, GPIOD_OUT_LO=
W);
> >     45          }
> >     46          if (IS_ERR(ret) || !ret) {
> >   > 47                  if (!ret || PTR_ERR(ret) =3D=3D -ENOENT)
> >     48                          dev_warn(dev, "gpio %s is not defined\n=
", label);
> >     49                  else
> >     50                          dev_warn(dev, "error while requesting g=
pio %s\n", label);
> >     51                  ret =3D NULL;
> >     52          } else {
> >     53                  dev_dbg(dev, "using gpio %d for %s\n", desc_to_=
gpio(ret), label);
> >     54          }
> >     55          return ret;
> >     56  }
> >     57
> =

> I think that this report is a false positive or I missed something?

No idea, but I really can not understand that code at all, so it does
need to be simplified no matter what :)

thanks,

greg k-h
--===============4761582698182670983==--