From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Frédéric Basse" <contact@fredericb.info>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Evgeny Voevodin" <e.voevodin@samsung.com>,
"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
"Igor Mitsyanko" <i.mitsyanko@gmail.com>,
qemu-devel@nongnu.org,
"Jean-Christophe Dubois" <jcd@tribudubois.net>,
qemu-arm@nongnu.org, "Dmitry Solodkiy" <d.solodkiy@samsung.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Maksim Kozlov" <m.kozlov@samsung.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Guenter Roeck" <linux@roeck-us.net>
Subject: Re: [PATCH 3/5] hw/sd/sdhci: Add dummy Samsung SDHCI controller
Date: Mon, 7 Oct 2019 10:59:31 +0200 [thread overview]
Message-ID: <20191007085931.GA541@pi3> (raw)
In-Reply-To: <20191005154748.21718-4-f4bug@amsat.org>
On Sat, Oct 05, 2019 at 05:47:46PM +0200, Philippe Mathieu-Daudé wrote:
> The Linux kernel access few S3C-specific registers [1] to set some
> clock. We don't care about this part for device emulation [2]. Add
> a dummy device to properly ignore these accesses, so we can focus
> on the important registers missing.
The CONTROL2 has also few other settings, not clock related, but they
can be skipped as well.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mmc/host/sdhci-s3c-regs.h?h=cc014f3
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/mmc/host/sdhci-s3c.c?h=v5.3#n263
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Eventually we should add the ADMA changes Igor sent in this patch:
> https://patchwork.ozlabs.org/patch/181854/
> They might solve the boot timing issues when using SD cards.
> ---
> hw/sd/sdhci.c | 65 +++++++++++++++++++++++++++++++++++++++++++
> include/hw/sd/sdhci.h | 2 ++
> 2 files changed, 67 insertions(+)
>
next prev parent reply other threads:[~2019-10-07 9:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-05 15:47 [PATCH 0/5] hw/arm/exynos4210: Add acceptance tests to the SMDKC210 board Philippe Mathieu-Daudé
2019-10-05 15:47 ` [PATCH 1/5] tests/boot_linux_console: Add initrd test for the Exynos4210 Philippe Mathieu-Daudé
2019-10-07 16:28 ` Peter Maydell
2019-10-08 21:49 ` Cleber Rosa
2019-10-08 23:01 ` Guenter Roeck
2019-10-09 13:38 ` Peter Maydell
2019-10-09 19:07 ` Cleber Rosa
2019-10-10 13:43 ` Philippe Mathieu-Daudé
2019-10-21 12:11 ` Philippe Mathieu-Daudé
2019-10-08 21:35 ` Cleber Rosa
2019-10-05 15:47 ` [PATCH 2/5] hw/sd/sdhci: Add a comment to distinct the i.MX eSDHC functions Philippe Mathieu-Daudé
2019-10-08 21:58 ` Cleber Rosa
2019-10-05 15:47 ` [PATCH 3/5] hw/sd/sdhci: Add dummy Samsung SDHCI controller Philippe Mathieu-Daudé
2019-10-07 8:59 ` Krzysztof Kozlowski [this message]
2019-10-05 15:47 ` [PATCH 4/5] hw/arm/exynos4210: Use the Samsung s3c " Philippe Mathieu-Daudé
2019-10-07 9:00 ` Krzysztof Kozlowski
2019-10-05 15:47 ` [PATCH 5/5] tests/boot_linux_console: Add sdcard test for the Exynos4210 Philippe Mathieu-Daudé
2019-10-08 23:12 ` Cleber Rosa
2019-10-07 9:10 ` [PATCH 0/5] hw/arm/exynos4210: Add acceptance tests to the SMDKC210 board Krzysztof Kozlowski
2019-10-07 17:42 ` Krzysztof Kozlowski
2019-10-18 14:48 ` Philippe Mathieu-Daudé
2019-10-22 12:54 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007085931.GA541@pi3 \
--to=krzk@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=contact@fredericb.info \
--cc=crosa@redhat.com \
--cc=d.solodkiy@samsung.com \
--cc=e.voevodin@samsung.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=i.mitsyanko@gmail.com \
--cc=jcd@tribudubois.net \
--cc=linux@roeck-us.net \
--cc=m.kozlov@samsung.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.