Re: [PATCH] xfs/097: Remove wrong broken assignment operation

["Darrick J. Wong" <darrick.wong@oracle.com>]

On Mon, Oct 07, 2019 at 03:15:15PM +0800, Yang Xu wrote:
> On old kernel, since commit ded188b8609 ("xfs: Fix the situation that mount 
> operation rejects corrupted XFS") running this case got the mismatched output,
> as below:

But why did the output mismatch?  Did the fs heal itself?  Did
allocating 5 more files somehow avoid touching the finobt?  Is the
assignment logic in the loop broken?

--D

> -----------------------------------
>  + check fs
>  + corrupt image
>  + mount image && modify files
> -broken: 1
> +broken: 0
>  + repair fs
>  + mount image (2)
> ------------------------------------
> 
> It fails because the broken is always equal to 0 when _try_scratch_mount
> succeed. So remove this wrong assignment operation.
> 
> Signed-off-by: Yang Xu <xuyang2018.jy@cn.fujitsu.com>
> ---
>  tests/xfs/097 | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tests/xfs/097 b/tests/xfs/097
> index 1cb7d69c..20791738 100755
> --- a/tests/xfs/097
> +++ b/tests/xfs/097
> @@ -81,8 +81,6 @@ done
>  echo "+ mount image && modify files"
>  broken=1
>  if _try_scratch_mount >> $seqres.full 2>&1; then
> -
> -	broken=0
>  	for x in `seq 65 70`; do
>  		touch "${TESTFILE}.${x}" 2> /dev/null && broken=0
>  	done
> -- 
> 2.18.1
> 
> 
>