From: Uladzislau Rezki <urezki@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Daniel Wagner <dwagner@suse.de>,
Uladzislau Rezki <urezki@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] mm: vmalloc: Use the vmap_area_lock to protect ne_fit_preload_node
Date: Mon, 7 Oct 2019 18:23:30 +0200 [thread overview]
Message-ID: <20191007162330.GA26503@pc636> (raw)
In-Reply-To: <20191007105631.iau6zhxqjeuzajnt@linutronix.de>
Hello, Daniel, Sebastian.
> > On Fri, Oct 04, 2019 at 06:30:42PM +0200, Sebastian Andrzej Siewior wrote:
> > > On 2019-10-04 18:20:41 [+0200], Uladzislau Rezki wrote:
> > > > If we have migrate_disable/enable, then, i think preempt_enable/disable
> > > > should be replaced by it and not the way how it has been proposed
> > > > in the patch.
> > >
> > > I don't think this patch is appropriate for upstream.
> >
> > Yes, I agree. The discussion made this clear, this is only for -rt
> > trees. Initially I though this should be in mainline too.
>
> Sorry, this was _before_ Uladzislau pointed out that you *just* moved
> the lock that was there from the beginning. I missed that while looking
> over the patch. Based on that I don't think that this patch is not
> appropriate for upstream.
>
Yes that is a bit messy :) Then i do not see what that patch fixes in
mainline? Instead it will just add an extra blocking, i did not want that
therefore used preempt_enable/disable. But, when i saw this patch i got it
as a preparation of PREEMPT_RT merging work.
--
Vlad Rezki
next prev parent reply other threads:[~2019-10-07 16:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 9:09 [PATCH] mm: vmalloc: Use the vmap_area_lock to protect ne_fit_preload_node Daniel Wagner
2019-10-03 11:55 ` Uladzislau Rezki
2019-10-04 15:37 ` Sebastian Andrzej Siewior
2019-10-04 16:20 ` Uladzislau Rezki
2019-10-04 16:30 ` Sebastian Andrzej Siewior
2019-10-04 17:04 ` Uladzislau Rezki
2019-10-04 17:45 ` Sebastian Andrzej Siewior
2019-10-07 8:30 ` Daniel Wagner
2019-10-07 10:56 ` Sebastian Andrzej Siewior
2019-10-07 16:23 ` Uladzislau Rezki [this message]
2019-10-07 16:34 ` Daniel Wagner
2019-10-07 16:56 ` Uladzislau Rezki
2019-10-07 17:22 ` Daniel Wagner
2019-10-07 17:36 ` Sebastian Andrzej Siewior
2019-10-07 21:44 ` Uladzislau Rezki
2019-10-08 16:04 ` Uladzislau Rezki
2019-10-09 6:05 ` Daniel Wagner
2019-10-09 9:47 ` Uladzislau Rezki
2019-10-07 8:27 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007162330.GA26503@pc636 \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=dwagner@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.