From: Borislav Petkov <bp@alien8.de>
To: Ralf Ramsauer <ralf.ramsauer@oth-regensburg.de>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
x86@kernel.org, jailhouse-dev@googlegroups.com,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
"H . Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v5 2/2] x86/jailhouse: Only enable platform UARTs if available
Date: Mon, 7 Oct 2019 18:59:58 +0200 [thread overview]
Message-ID: <20191007165958.GE24289@zn.tnic> (raw)
In-Reply-To: <85502467-d13b-084e-cdb8-d891178e97d8@oth-regensburg.de>
On Mon, Oct 07, 2019 at 06:44:39PM +0200, Ralf Ramsauer wrote:
> Yep, jailhouse_serial_fixup can become __init, I didn't see that, but
> you're right, thanks. I'm curious, how did you find that?
CONFIG_SECTION_MISMATCH_WARN_ONLY=y
If that it off, it fails the build even:
WARNING: vmlinux.o(.text+0x4fdb0): Section mismatch in reference from the function jailhouse_serial_fixup() to the variable .init.data:can_use_brk_pgt
The function jailhouse_serial_fixup() references
the variable __initdata can_use_brk_pgt.
This is often because jailhouse_serial_fixup lacks a __initdata
annotation or the annotation of can_use_brk_pgt is wrong.
FATAL: modpost: Section mismatches detected.
Set CONFIG_SECTION_MISMATCH_WARN_ONLY=y to allow them.
make[1]: *** [scripts/Makefile.modpost:66: __modpost] Error 1
make: *** [Makefile:1074: vmlinux] Error 2
Apparently we did that with:
47490ec141b9 ("modpost: Add flag -E for making section mismatches fatal")
> "We" didn't notice yet. :-)
LOL.
> BTW, we refers to the Jailhouse folks, but I will rewrite that.
Thanks.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2019-10-07 17:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 12:38 [PATCH v5 0/2] x86/jailhouse: improve probing of platform UARTs Ralf Ramsauer
2019-10-07 12:38 ` [PATCH v5 1/2] x86/jailhouse: improve setup data version comparison Ralf Ramsauer
2019-10-07 16:25 ` Borislav Petkov
2019-10-07 18:25 ` [tip: x86/platform] x86/jailhouse: Improve " tip-bot2 for Ralf Ramsauer
2019-10-07 12:38 ` [PATCH v5 2/2] x86/jailhouse: Only enable platform UARTs if available Ralf Ramsauer
2019-10-07 15:20 ` Jan Kiszka
2019-10-07 16:26 ` Borislav Petkov
2019-10-07 16:44 ` Ralf Ramsauer
2019-10-07 16:59 ` Borislav Petkov [this message]
2019-10-07 18:25 ` [tip: x86/platform] x86/jailhouse: Enable platform UARTs only " tip-bot2 for Ralf Ramsauer
2019-10-07 18:27 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007165958.GE24289@zn.tnic \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jailhouse-dev@googlegroups.com \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ralf.ramsauer@oth-regensburg.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.