From: Sean Paul <sean@poorly.run>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Maxime Ripard <mripard@kernel.org>,
David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, Ben Skeggs <bskeggs@redhat.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Dariusz Marcinkiewicz <darekm@google.com>,
Sean Paul <sean@poorly.run>
Subject: Re: [PATCH v1 1/2] drm_dp_cec: drop use of drmP.h
Date: Mon, 7 Oct 2019 14:17:35 -0400 [thread overview]
Message-ID: <20191007181735.GE126146@art_vandelay> (raw)
In-Reply-To: <20191007171224.1581-2-sam@ravnborg.org>
On Mon, Oct 07, 2019 at 07:12:23PM +0200, Sam Ravnborg wrote:
> drmP.h is deprecated and will be deleted.
> Replace use with proper header.
>
> Divide header includes in blocks while touching these.
>
> Build tested with various archtectures and configs.
>
> Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Sean Paul <sean@poorly.run>
> Fixes: ae85b0df124f6928 ("drm_dp_cec: add connector info support.")
> Cc: Dariusz Marcinkiewicz <darekm@google.com>
> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: Ben Skeggs <bskeggs@redhat.com>
> ---
> drivers/gpu/drm/drm_dp_cec.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_cec.c b/drivers/gpu/drm/drm_dp_cec.c
> index b457c16c3a8b..3ab2609f9ec7 100644
> --- a/drivers/gpu/drm/drm_dp_cec.c
> +++ b/drivers/gpu/drm/drm_dp_cec.c
> @@ -8,10 +8,12 @@
> #include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/slab.h>
> +
> +#include <media/cec.h>
> +
> #include <drm/drm_connector.h>
> +#include <drm/drm_device.h>
> #include <drm/drm_dp_helper.h>
> -#include <drm/drmP.h>
> -#include <media/cec.h>
>
> /*
> * Unfortunately it turns out that we have a chicken-and-egg situation
> --
> 2.20.1
>
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-10-07 18:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 17:12 [PATCH v1 0/2]: Finally delete drmP.h Sam Ravnborg
2019-10-07 17:12 ` [PATCH v1 1/2] drm_dp_cec: drop use of drmP.h Sam Ravnborg
2019-10-07 18:17 ` Sean Paul [this message]
2019-10-07 18:35 ` Lyude Paul
2019-10-08 7:32 ` Hans Verkuil
2019-10-07 17:12 ` [PATCH v1 2/2] drm: delete drmP.h + drm_os_linux.h Sam Ravnborg
2019-10-07 18:17 ` Sean Paul
2019-10-07 18:36 ` Lyude Paul
2019-10-08 7:31 ` Jani Nikula
2019-10-08 16:51 ` [PATCH v1 0/2]: Finally delete drmP.h Sam Ravnborg
2019-10-09 16:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007181735.GE126146@art_vandelay \
--to=sean@poorly.run \
--cc=airlied@linux.ie \
--cc=bskeggs@redhat.com \
--cc=darekm@google.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=mripard@kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.