From: Christoph Hellwig <hch@lst.de>
To: Arvind Sankar <nivedita@alum.mit.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org
Subject: Re: ehci-pci breakage with dma-mapping changes in 5.4-rc2
Date: Mon, 7 Oct 2019 20:47:54 +0200 [thread overview]
Message-ID: <20191007184754.GB31345@lst.de> (raw)
In-Reply-To: <20191007183206.GA13589@rani.riverdale.lan>
On Mon, Oct 07, 2019 at 02:32:07PM -0400, Arvind Sankar wrote:
> On Mon, Oct 07, 2019 at 01:58:57PM -0400, Arvind Sankar wrote:
> > On Mon, Oct 07, 2019 at 10:56:30AM -0700, Christoph Hellwig wrote:
> > > On Mon, Oct 07, 2019 at 07:55:28PM +0200, Christoph Hellwig wrote:
> > > > On Mon, Oct 07, 2019 at 01:54:32PM -0400, Arvind Sankar wrote:
> > > > > It doesn't boot with the patch. Won't it go
> > > > > dma_get_required_mask
> > > > > -> intel_get_required_mask
> > > > > -> iommu_need_mapping
> > > > > -> dma_get_required_mask
> > > > > ?
> > > > >
> > > > > Should the call to dma_get_required_mask in iommu_need_mapping be
> > > > > replaced with dma_direct_get_required_mask on top of your patch?
> > > >
> > > > Yes, sorry.
> > >
> > > Actually my patch already calls dma_direct_get_required_mask.
> > > How did you get the loop?
> >
> > The function iommu_need_mapping (not changed by your patch) calls
> > dma_get_required_mask internally, to check whether the device's dma_mask
> > is big enough or not. That's the call I was asking whether it needs to
> > be changed.
>
> Yeah the attached patch seems to fix it.
That looks fine to me:
Acked-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-10-07 18:47 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 2:24 ehci-pci breakage with dma-mapping changes in 5.4-rc2 Arvind Sankar
2019-10-07 7:34 ` Christoph Hellwig
2019-10-07 17:54 ` Arvind Sankar
2019-10-07 17:55 ` Christoph Hellwig
2019-10-07 17:56 ` Christoph Hellwig
2019-10-07 17:58 ` Arvind Sankar
2019-10-07 18:32 ` Arvind Sankar
2019-10-07 18:47 ` Christoph Hellwig [this message]
2019-10-07 22:10 ` Arvind Sankar
2019-10-07 23:54 ` Arvind Sankar
2019-10-08 7:32 ` Christoph Hellwig
2019-10-08 11:51 ` Arvind Sankar
2019-10-08 12:50 ` Christoph Hellwig
2019-10-08 15:47 ` Arvind Sankar
2019-10-09 6:50 ` Christoph Hellwig
2019-10-09 13:48 ` Arvind Sankar
2019-10-08 7:29 ` Christoph Hellwig
2019-10-08 14:33 ` [PATCH] iommu/vt-d: Return the correct dma mask when we are bypassing the IOMMU Arvind Sankar
2019-10-09 2:45 ` Lu Baolu
2019-10-09 6:51 ` Christoph Hellwig
2019-10-10 1:24 ` Lu Baolu
2019-10-10 1:26 ` Lu Baolu
2019-10-16 19:15 ` Arvind Sankar
2019-10-17 7:08 ` Christoph Hellwig
2019-10-17 15:55 ` Arvind Sankar
2019-10-17 15:55 ` Arvind Sankar
2019-10-18 9:50 ` Joerg Roedel
2019-10-18 15:14 ` Christoph Hellwig
2019-10-18 15:21 ` Joerg Roedel
2019-10-18 15:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007184754.GB31345@lst.de \
--to=hch@lst.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nivedita@alum.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.