From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/gcc: add support for D language
Date: Mon, 7 Oct 2019 23:16:30 +0200 [thread overview]
Message-ID: <20191007231630.6f5f0744@windsurf.home> (raw)
In-Reply-To: <663f4e52-ac32-1375-c135-0f7c3fa12803@mind.be>
On Mon, 7 Oct 2019 23:09:28 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> > config BR2_TOOLCHAIN_CAN_SUPPORT_DLANG
> > bool
> > depends on BR2_TOOLCHAIN_GCC_AT_LEAST_9
> > depends on BR2_TOLCHAIN_USES_GLIBC
> > default y if BR2_arm
> > default y if BR2_x86_64
> > default y if ...
> >
> > and then re-use that for both the internal and external toolchain cases.
>
> Nack that. An external toolchain may use a gcc branch that does support
> additional architectures or a different libc or a gcc version < 9. So for the
> external toolchain, there should just be a BR2_TOOLCHAIN_EXTERNAL_CUSTOM_DLANG
> that is user-settable (and verified with a compiler test).
That's true. I thought about that when writing my reply, but didn't see
a good solution to handle that.
> Also, there should be a hidden BR2_TOOLCHAIN_HAS_DLANG option that gets
> selected by BR2_TOOLCHAIN_BUILDROOT_DLANG and
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM_DLANG (and possibly by other external toolchains
> in the future).
This is exactly what I suggested in my initial reply to Eric's patches.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-10-07 21:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-29 16:55 [Buildroot] [PATCH 0/2] Add support for the D programming language Eric Le Bihan
2019-09-29 16:56 ` [Buildroot] [PATCH 1/2] toolchain: add support for D language Eric Le Bihan
2019-09-29 16:56 ` [Buildroot] [PATCH 2/2] package/gcc: " Eric Le Bihan
2019-09-30 21:04 ` Thomas Petazzoni
2019-10-01 5:56 ` Eric Le Bihan
2019-10-01 6:56 ` Thomas Petazzoni
2019-10-06 15:12 ` Eric Le Bihan
2019-10-07 7:10 ` Thomas Petazzoni
2019-10-07 21:09 ` Arnout Vandecappelle
2019-10-07 21:16 ` Thomas Petazzoni [this message]
2019-09-30 21:03 ` [Buildroot] [PATCH 0/2] Add support for the D programming language Thomas Petazzoni
2019-10-01 6:03 ` Eric Le Bihan
2019-10-01 6:56 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007231630.6f5f0744@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.