From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Subject: Re: [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start Date: Tue, 8 Oct 2019 10:18:32 +0200 Message-ID: <20191008081831.GA29132@dell5510> References: <20190708213551.26349-1-petr.vorel@gmail.com> <20190709024742.GA22293@infradead.org> <20190709080204.GA12875@dell5510> <20190709133436.GA2231@infradead.org> <20191002060508.GA16684@x230> <20191007165732.GA4805@infradead.org> Reply-To: Petr Vorel Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20191007165732.GA4805@infradead.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Christoph Hellwig Cc: dm-devel@redhat.com, Baruch Even List-Id: dm-devel.ids Hi Christoph, > On Wed, Oct 02, 2019 at 08:05:09AM +0200, Petr Vorel wrote: > > I tried to search in [1], with not much success, I don't know the original name > > of the struct and struct members are quite similar. Do you have a tip, where it > > could be or would you dare to search? > No, I don't know Solaris very well. > > Christophe already merged my patch as > > 129e6fe6 ("kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start") > > But, according to your comments it looks to me better to use the exact structure > > kernel uses. So, if we don't find anything, I'd be for using kernel struct. > Thanks, that would be great. I've sent a patch, as RFC, Cc also Baruch Even, the gpart maintainer. I wonder, if there is anybody actually using this code nowadays. Kind regards, Petr