All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/lua-sdl2: fix install path
Date: Tue, 8 Oct 2019 09:23:59 +0200	[thread overview]
Message-ID: <20191008092359.0fff1caa@windsurf> (raw)
In-Reply-To: <20191007040250.23281-1-francois.perrad@gadz.org>

Hello Fran?ois,

On Mon,  7 Oct 2019 06:02:50 +0200
Francois Perrad <fperrad@gmail.com> wrote:

> WITH_LUAVER must be set with a value depending of Lua interpreter,
> by this way, the module is installed in the correct location
> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/lua-sdl2/lua-sdl2.mk | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/package/lua-sdl2/lua-sdl2.mk b/package/lua-sdl2/lua-sdl2.mk
> index a1e54bfde..e0ed0b7e2 100644
> --- a/package/lua-sdl2/lua-sdl2.mk
> +++ b/package/lua-sdl2/lua-sdl2.mk
> @@ -10,7 +10,17 @@ LUA_SDL2_LICENSE = ISC
>  LUA_SDL2_LICENSE_FILES = LICENSE
>  LUA_SDL2_DEPENDENCIES = luainterpreter sdl2
>  
> -LUA_SDL2_CONF_OPTS += -DWITH_LUAVER=user -DLUA_INCLUDE_DIR=$(STAGING_DIR)/usr/include
> +ifeq ($(BR2_PACKAGE_LUAJIT),y)
> +LUA_SDL2_LUAVER=JIT

We put spaces around = sign.

> +else
> +ifeq ($(BR2_PACKAGE_LUA_5_3),y)

This should have been written as:

else ifeq (...)

this way, you don't enter another conditional block, and you don't need
the double "endif".

I fixed that, and applied. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-10-08  7:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07  4:02 [Buildroot] [PATCH] package/lua-sdl2: fix install path Francois Perrad
2019-10-07 23:33 ` Ricardo Martincoski
2019-10-08  7:23 ` Thomas Petazzoni [this message]
2019-10-28  9:57 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008092359.0fff1caa@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.