From: Tony Lindgren <tony@atomide.com>
To: Graeme Smecher <gsmecher@threespeedlogic.com>
Cc: "Andrey Smirnov" <andrew.smirnov@gmail.com>,
linux-omap@vger.kernel.org,
"Benoît Cousson" <bcousson@baylibre.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: am3874-iceboard: Fix 'i2c-mux-idle-disconnect' usage
Date: Tue, 8 Oct 2019 07:16:59 -0700 [thread overview]
Message-ID: <20191008141659.GC5610@atomide.com> (raw)
In-Reply-To: <c40b8414-45a8-575a-c3c8-902ed35e5764@threespeedlogic.com>
* Graeme Smecher <gsmecher@threespeedlogic.com> [191004 23:53]:
> Hi Andrey,
>
> On 2019-10-03 6:45 p.m., Andrey Smirnov wrote:
> > According to
> > Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt,
> > i2c-mux-idle-disconnect is a property of a parent node since it
> > pertains to the mux/switch as a whole, so move it there and drop all
> > of the concurrences in child nodes.
> >
> > Fixes: d031773169df ("ARM: dts: Adds device tree file for McGill's IceBoard, based on TI AM3874")
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Cc: Benoît Cousson <bcousson@baylibre.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Graeme Smecher <gsmecher@threespeedlogic.com>
> > Cc: linux-omap@vger.kernel.org
> > Cc: devicetree@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >
> > This is purely a drive-by fix, since it concerns the HW I've never
> > heard of before. However I was working with PCA9548
> > (vf610-zii-scu4-aib is my HW) and looking at various users in the
> > kernel, when this code caught my eye. Apologies for the noise if this
> > fix is somehow bogus.
> >
> > In case that it matters this patch is based on top of 5.4-rc1.
>
> Thanks! We do have I2C address collisions on downstream bus segments, so
> keeping these segments isolated is important. I'm surprised this patch
> was necessary and happy to see it.
>
> Lightly tested on 5.3.
>
> Tested-by: Graeme Smecher <gsmecher@threespeedlogic.com>
Applying into fixes thanks.
Tony
prev parent reply other threads:[~2019-10-08 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 1:45 [PATCH] ARM: dts: am3874-iceboard: Fix 'i2c-mux-idle-disconnect' usage Andrey Smirnov
2019-10-04 23:52 ` Graeme Smecher
2019-10-08 14:16 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008141659.GC5610@atomide.com \
--to=tony@atomide.com \
--cc=andrew.smirnov@gmail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=gsmecher@threespeedlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.