From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU Date: Tue, 8 Oct 2019 16:29:00 +0200 Message-ID: <20191008142900.GA2635@pi3> References: <20191004151414.8458-1-krzk@kernel.org> <20191008125038.GA2550@pi3> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc , Maciej Falkowski , "open list:SERIAL DRIVERS" , David Airlie , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , dri-devel , Kukjin Kim , Lee Jones , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org T24gVHVlLCBPY3QgMDgsIDIwMTkgYXQgMDk6MTc6MTZBTSAtMDUwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gT24gVHVlLCBPY3QgOCwgMjAxOSBhdCA5OjA1IEFNIFJvYiBIZXJyaW5nIDxyb2JoK2R0 QGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4KPiA+IE9uIFR1ZSwgT2N0IDgsIDIwMTkgYXQgNzo1MCBB TSBLcnp5c3p0b2YgS296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4gPgo+ID4g PiBPbiBUdWUsIE9jdCAwOCwgMjAxOSBhdCAwNzozODoxNEFNIC0wNTAwLCBSb2IgSGVycmluZyB3 cm90ZToKPiA+ID4gPiBPbiBGcmksIE9jdCA0LCAyMDE5IGF0IDEwOjE0IEFNIEtyenlzenRvZiBL b3psb3dza2kgPGtyemtAa2VybmVsLm9yZz4gd3JvdGU6Cj4gPiA+ID4gPgo+ID4gPiA+ID4gVGhl IGNsa291dE4gbmFtZXMgb2YgY2xvY2tzIG11c3QgYmUgdW5pcXVlIGJlY2F1c2UgdGhleSByZXBy ZXNlbnQKPiA+ID4gPiA+IHVuaXF1ZSBpbnB1dHMgb2YgY2xvY2sgbXVsdGlwbGV4ZXIuCj4gPiA+ ID4gPgo+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogS3J6eXN6dG9mIEtvemxvd3NraSA8a3J6a0Br ZXJuZWwub3JnPgo+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL2FybS9zYW1zdW5nL3BtdS55YW1sIHwgNiArKysrLS0KPiA+ID4gPiA+ICAx IGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+ID4gPiA+ID4K PiA+ID4gPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv YXJtL3NhbXN1bmcvcG11LnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv YXJtL3NhbXN1bmcvcG11LnlhbWwKPiA+ID4gPiA+IGluZGV4IDczYjU2ZmM1YmY1OC4uZDhlMDM3 MTZmNWQyIDEwMDY0NAo+ID4gPiA+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2FybS9zYW1zdW5nL3BtdS55YW1sCj4gPiA+ID4gPiArKysgYi9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvYXJtL3NhbXN1bmcvcG11LnlhbWwKPiA+ID4gPiA+IEBAIC01 Myw4ICs1MywxMCBAQCBwcm9wZXJ0aWVzOgo+ID4gPiA+ID4gICAgICAgIExpc3Qgb2YgY2xvY2sg bmFtZXMgZm9yIHBhcnRpY3VsYXIgQ0xLT1VUIG11eCBpbnB1dHMKPiA+ID4gPiA+ICAgICAgbWlu SXRlbXM6IDEKPiA+ID4gPiA+ICAgICAgbWF4SXRlbXM6IDMyCj4gPiA+ID4gPiAtICAgIGl0ZW1z Ogo+ID4gPiA+ID4gLSAgICAgIHBhdHRlcm46ICdeY2xrb3V0KFswLTldfFsxMl1bMC05XXwzWzAt MV0pJCcKPiA+ID4gPiA+ICsgICAgYWxsT2Y6Cj4gPiA+ID4gPiArICAgICAgLSBpdGVtczoKPiA+ ID4gPiA+ICsgICAgICAgICAgcGF0dGVybjogJ15jbGtvdXQoWzAtOV18WzEyXVswLTldfDNbMC0x XSkkJwo+ID4gPiA+ID4gKyAgICAgIC0gdW5pcXVlSXRlbXM6IHRydWUKPiA+ID4gPgo+ID4gPiA+ IFlvdSBzaG91bGRuJ3QgbmVlZCB0aGUgJ2FsbE9mJywganVzdCBhZGQgdW5pcXVlSXRlbXMgYXQg dGhlIHNhbWUgbGV2ZWwgYXMgaXRlbXMuCj4gPiA+Cj4gPiA+IElmIHlvdSBtZWFuIHNvbWV0aGlu ZyBsaWtlOgo+ID4gPiAgIDU2ICAgICB1bmlxdWVJdGVtczogdHJ1ZQo+ID4gPiAgIDU3ICAgICBp dGVtczoKPiA+ID4gICA1OCAgICAgICBwYXR0ZXJuOiAnXmNsa291dChbMC05XXxbMTJdWzAtOV18 M1swLTFdKSQnCj4gPiA+Cj4gPiA+IFRoZW4gdGhlIGR0X2JpbmRpbmdfY2hlY2sgZmFpbHM6Cj4g PiA+Cj4gPiA+IGRldi9saW51eC9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvYXJt L3NhbXN1bmcvcG11LnlhbWw6IHByb3BlcnRpZXM6Y2xvY2stbmFtZXM6Cj4gPiA+ICd1bmlxdWVJ dGVtcycgaXMgbm90IG9uZSBvZiBbJyRyZWYnLCAnYWRkaXRpb25hbEl0ZW1zJywgJ2FkZGl0aW9u YWxQcm9wZXJ0aWVzJywgJ2FsbE9mJywgJ2FueU9mJywgJ2NvbnN0JywgJ2NvbnRhaW5zJywgJ2Rl ZmF1bHQnLCAnZGVwZW5kZW5jaWVzJywgJ2RlcHJlY2F0ZWQnLCAnZGVzY3JpcHRpb24nLCAnZWxz ZScsICdlbnVtJywgJ2l0ZW1zJywgJ2lmJywgJ21pbkl0ZW1zJywgJ21pbmltdW0nLCAnbWF4SXRl bXMnLCAnbWF4aW11bScsICdub3QnLCAnb25lT2YnLCAncGF0dGVybicsICdwYXR0ZXJuUHJvcGVy dGllcycsICdwcm9wZXJ0aWVzJywgJ3JlcXVpcmVkJywgJ3RoZW4nLCAndHlwZScsICd0eXBlU2l6 ZScsICd1bmV2YWx1YXRlZFByb3BlcnRpZXMnXQo+ID4KPiA+IEkgY2FuIGFkZCBpdC4KPiA+Cj4g PiBUaGUgb3RoZXIgb3B0aW9uIGlzIHRvIGZpeCB0aGlzIGluIHRoZSBjbG9jayBzY2hlbWEuIEkn bSBub3Qgc3VyZSBpZgo+ID4gdGhlcmUncyBhIG5lZWQgZm9yIGR1cGxpY2F0ZSBjbG9jay1uYW1l cy4gU2VlbXMgdW5saWtlbHkuIEknbGwgdGVzdAo+ID4gdGhhdC4KPiAKPiBBY3R1YWxseSwgY2xv Y2stbmFtZXMgaXMgYWxyZWFkeSBzZXQgdG8gYmUgdW5pcXVlLiBEaWQgeW91IHNlZSBvdGhlcndp c2U/CgpZZWFoLCBJIGR1cGxpY2F0ZWQgb24gcHVycG9zZSAiY2xrb3V0MSIgYW5kIGl0IHdhcyBu b3QgcmVwb3J0ZWQgYXMgYW4KZXJyb3IuIFRoYXQncyB3aHkgSSBhZGRlZCAidW5pcXVlSXRlbXMi LgoKQmVzdCByZWdhcmRzLApLcnp5c3p0b2YKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40005C10F14 for ; Tue, 8 Oct 2019 14:29:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18E5E217D7 for ; Tue, 8 Oct 2019 14:29:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570544950; bh=ys2SNXL5zK/iSkN3q9J3K5H+3XMp/3DlnDb+8W4ifTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=kaWK6dkatD6Y7RIlxnZHKxd9BdZFlm3d7fqZ2UcdbPWw/WdC2iTEZuv9W1Uf4utRT vJAlzzQFtpGHoI9eKSp5az3/lLa1B9sam0oRy6W/RUCJuIBgzgT7o0+NGpISEwXN3S AYY89hrARAVGnkZaHduS0+sZXu9ngQ7kdrj9wd18= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726071AbfJHO3G (ORCPT ); Tue, 8 Oct 2019 10:29:06 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:52029 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725795AbfJHO3G (ORCPT ); Tue, 8 Oct 2019 10:29:06 -0400 Received: by mail-wm1-f66.google.com with SMTP id 7so3414306wme.1; Tue, 08 Oct 2019 07:29:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YE0D8Jghzw7CVdBybcskFRzbxtu5Ddla3G2nKPd70nY=; b=Sc8Om7IguzBfLUV8d0Qb3/RSTq6q2+HX3E3E88BENJ2zail1KFY8MdtpSMcANhmSH9 hBYWxFhwEIVGjyzS1a5S09LFWFClss+NFEb3UGqcH6VnUAKW3waCdlAC2cqwFoVBZ0wk 5YZsCI9dC03b9yyLEm5otuFb68kEyhVxpZKLtoWrAwiJY7YJeoz7/iAJYOuCQsr1HE7p MsxAF3hEVS8gyUbMNOl8UFD9L5rRE2JIN4G/O7ByydEKqXc4H7Ri+FS7/VmsT334zMJx 129RCo1MHf+edtdRCzdCI6pauGWSS9bgxWslmc2Btes7xZV8yjLIxi6oi8MiEv3KGTbt F7og== X-Gm-Message-State: APjAAAVn5OEmWl6hXEIVU9qCQesSBTQpVYKjf9VSScFf3MVanW5feC/b DMxbteYzs220Bg0urwK96qgD64P3 X-Google-Smtp-Source: APXvYqw13buOvMKCLr9dJbc+42LtMA0u9H09vXHDWUs/lreMeW+bzq3Dl290U336az+CLfiT3ep52A== X-Received: by 2002:a1c:a6ca:: with SMTP id p193mr3960835wme.103.1570544942984; Tue, 08 Oct 2019 07:29:02 -0700 (PDT) Received: from pi3 ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id 143sm4202466wmb.33.2019.10.08.07.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 07:29:02 -0700 (PDT) Date: Tue, 8 Oct 2019 16:29:00 +0200 From: Krzysztof Kozlowski To: Rob Herring Cc: Kukjin Kim , Mark Rutland , David Airlie , Daniel Vetter , Lee Jones , Greg Kroah-Hartman , Maciej Falkowski , Marek Szyprowski , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-samsung-soc , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , dri-devel , "open list:SERIAL DRIVERS" Subject: Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU Message-ID: <20191008142900.GA2635@pi3> References: <20191004151414.8458-1-krzk@kernel.org> <20191008125038.GA2550@pi3> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Message-ID: <20191008142900.ZEZIckd4MSvZQzYalBrtpynK-sg-gc4JClbF5EGaJpQ@z> On Tue, Oct 08, 2019 at 09:17:16AM -0500, Rob Herring wrote: > On Tue, Oct 8, 2019 at 9:05 AM Rob Herring wrote: > > > > On Tue, Oct 8, 2019 at 7:50 AM Krzysztof Kozlowski wrote: > > > > > > On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote: > > > > On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski wrote: > > > > > > > > > > The clkoutN names of clocks must be unique because they represent > > > > > unique inputs of clock multiplexer. > > > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > --- > > > > > Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 6 ++++-- > > > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > index 73b56fc5bf58..d8e03716f5d2 100644 > > > > > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > @@ -53,8 +53,10 @@ properties: > > > > > List of clock names for particular CLKOUT mux inputs > > > > > minItems: 1 > > > > > maxItems: 32 > > > > > - items: > > > > > - pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > > > > + allOf: > > > > > + - items: > > > > > + pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > > > > + - uniqueItems: true > > > > > > > > You shouldn't need the 'allOf', just add uniqueItems at the same level as items. > > > > > > If you mean something like: > > > 56 uniqueItems: true > > > 57 items: > > > 58 pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > > > > > Then the dt_binding_check fails: > > > > > > dev/linux/Documentation/devicetree/bindings/arm/samsung/pmu.yaml: properties:clock-names: > > > 'uniqueItems' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties'] > > > > I can add it. > > > > The other option is to fix this in the clock schema. I'm not sure if > > there's a need for duplicate clock-names. Seems unlikely. I'll test > > that. > > Actually, clock-names is already set to be unique. Did you see otherwise? Yeah, I duplicated on purpose "clkout1" and it was not reported as an error. That's why I added "uniqueItems". Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7ECC10F14 for ; Tue, 8 Oct 2019 14:29:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 346CA205C9 for ; Tue, 8 Oct 2019 14:29:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rZibEIyy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 346CA205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ogEcnK/V1a5ytZFZJozKofKXsnqMkymBvFeV+IXbf4Y=; b=rZibEIyyh02Yhv VXAMD92vRjMB3yi911DsQYgM560QTOiwsWWBZcEaGwhJeRxZFzZIQKlGnuFuBqylRybYt1iH28Muf gQ+7OPRkXM0767xDlBayKRH3vep8saqlmhbvc5HMyy5zoO5eFaD+ScDLDXIClo+X10kYcmSibBAgC 1H2b1AG9Vahn0NwArGfzY5WutllmXFpC0SSPH451Wp41AhWnPbuo2QQvzXPFidQBZZblCUHrHDLtZ cMQcP1BetMgWQHy5EPu4dFUgyAtv2PYdv5//2sscNmQ4JX4tyNqMAJeEMWI7L/AsbhcdFCS9qEK3j 1jJk3gnMqbfqUe6qvwKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHqU9-0002Uf-Tz; Tue, 08 Oct 2019 14:29:09 +0000 Received: from mail-wm1-f65.google.com ([209.85.128.65]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHqU6-0002Tq-Lb for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2019 14:29:08 +0000 Received: by mail-wm1-f65.google.com with SMTP id y21so3383092wmi.0 for ; Tue, 08 Oct 2019 07:29:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=YE0D8Jghzw7CVdBybcskFRzbxtu5Ddla3G2nKPd70nY=; b=pIrJDq3YAhckHcc369I7VRIoIrEk3/39fqij/GOUG2CI8OO3AB7bMTf2/IzEZEIw3C H4DTZOfd/d+zchIC3FN94bo1S1JOLmauCpJheesK7yJ5iUvWnOB0yFg5BPldChH5Pqoi sujscUhQt1T+bV67P3kMdBeziHWaqe3uMMfsRfElb7lYzWjInLZ92QqM5oUMIEIJNgmH qeowD//xOdM+R3cM3HF54BjSkqm9PTVcIOjotPsL7PDs0sBebhsyO5HkmKGdyuMMXv/d bioIbGX12+bWNepjT9VySQLwW+Q8znIGMFaNPQptDfXrqj1C/l9y7zeV3laeYS26kUvW 4YNQ== X-Gm-Message-State: APjAAAXYVaDsNCmDW789ti75gpmki2I74MaYb+sPGnS6NIIEltfTP8YK VzH431BcXqPAIRdVnJIMJTQ= X-Google-Smtp-Source: APXvYqw13buOvMKCLr9dJbc+42LtMA0u9H09vXHDWUs/lreMeW+bzq3Dl290U336az+CLfiT3ep52A== X-Received: by 2002:a1c:a6ca:: with SMTP id p193mr3960835wme.103.1570544942984; Tue, 08 Oct 2019 07:29:02 -0700 (PDT) Received: from pi3 ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id 143sm4202466wmb.33.2019.10.08.07.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Oct 2019 07:29:02 -0700 (PDT) Date: Tue, 8 Oct 2019 16:29:00 +0200 From: Krzysztof Kozlowski To: Rob Herring Subject: Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU Message-ID: <20191008142900.GA2635@pi3> References: <20191004151414.8458-1-krzk@kernel.org> <20191008125038.GA2550@pi3> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191008_072906_708703_85ECCA99 X-CRM114-Status: GOOD ( 20.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc , Maciej Falkowski , "open list:SERIAL DRIVERS" , David Airlie , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , dri-devel , Kukjin Kim , Daniel Vetter , Lee Jones , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 08, 2019 at 09:17:16AM -0500, Rob Herring wrote: > On Tue, Oct 8, 2019 at 9:05 AM Rob Herring wrote: > > > > On Tue, Oct 8, 2019 at 7:50 AM Krzysztof Kozlowski wrote: > > > > > > On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote: > > > > On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski wrote: > > > > > > > > > > The clkoutN names of clocks must be unique because they represent > > > > > unique inputs of clock multiplexer. > > > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > --- > > > > > Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 6 ++++-- > > > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > index 73b56fc5bf58..d8e03716f5d2 100644 > > > > > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > @@ -53,8 +53,10 @@ properties: > > > > > List of clock names for particular CLKOUT mux inputs > > > > > minItems: 1 > > > > > maxItems: 32 > > > > > - items: > > > > > - pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > > > > + allOf: > > > > > + - items: > > > > > + pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > > > > + - uniqueItems: true > > > > > > > > You shouldn't need the 'allOf', just add uniqueItems at the same level as items. > > > > > > If you mean something like: > > > 56 uniqueItems: true > > > 57 items: > > > 58 pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > > > > > Then the dt_binding_check fails: > > > > > > dev/linux/Documentation/devicetree/bindings/arm/samsung/pmu.yaml: properties:clock-names: > > > 'uniqueItems' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties'] > > > > I can add it. > > > > The other option is to fix this in the clock schema. I'm not sure if > > there's a need for duplicate clock-names. Seems unlikely. I'll test > > that. > > Actually, clock-names is already set to be unique. Did you see otherwise? Yeah, I duplicated on purpose "clkout1" and it was not reported as an error. That's why I added "uniqueItems". Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel