From: Johan Hovold <johan@kernel.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Johan Hovold <johan@kernel.org>,
Amitkumar Karwar <amitkarwar@gmail.com>,
Siva Rebbagondla <siva8118@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Denis Efremov <efremov@linux.com>
Subject: Re: [PATCH 1/2] Revert "rsi: fix potential null dereference in rsi_probe()"
Date: Tue, 8 Oct 2019 18:44:39 +0200 [thread overview]
Message-ID: <20191008164439.GA27819@localhost> (raw)
In-Reply-To: <87pnj7grii.fsf@tynnyri.adurom.net>
On Tue, Oct 08, 2019 at 06:56:37PM +0300, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
> > Johan Hovold <johan@kernel.org> writes:
> >
> >> This reverts commit f170d44bc4ec2feae5f6206980e7ae7fbf0432a0.
> >>
> >> USB core will never call a USB-driver probe function with a NULL
> >> device-id pointer.
> >>
> >> Reverting before removing the existing checks in order to document this
> >> and prevent the offending commit from being "autoselected" for stable.
> >>
> >> Signed-off-by: Johan Hovold <johan@kernel.org>
> >
> > I'll queue these two to v5.4.
>
> Actually I'll take that back. Commit f170d44bc4ec is in -next so I have
> to also queue these to -next.
That's right. I'm assuming you don't rebase your branches, otherwise
just dropping the offending patch might of course be an option instead
of the revert.
Johan
next prev parent reply other threads:[~2019-10-08 16:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 14:44 [PATCH 1/2] Revert "rsi: fix potential null dereference in rsi_probe()" Johan Hovold
2019-10-04 14:44 ` [PATCH 2/2] rsi: drop bogus device-id checks from probe Johan Hovold
2019-10-06 8:23 ` [PATCH 1/2] Revert "rsi: fix potential null dereference in rsi_probe()" Kalle Valo
2019-10-08 15:56 ` Kalle Valo
2019-10-08 16:44 ` Johan Hovold [this message]
2019-10-08 19:24 ` Kalle Valo
2019-10-09 8:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008164439.GA27819@localhost \
--to=johan@kernel.org \
--cc=amitkarwar@gmail.com \
--cc=efremov@linux.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=siva8118@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.