From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] ARM: dts: s3c64xx: Fix init order of clock providers Date: Tue, 8 Oct 2019 19:53:30 +0200 Message-ID: <20191008175330.GA28160@kozik-lap> References: <20191008165917.23908-1-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sylwester Nawrocki Cc: Lihua Yao , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-samsung-soc@vger.kernel.org On Tue, Oct 08, 2019 at 07:30:50PM +0200, Sylwester Nawrocki wrote: > On 10/8/19 18:59, Krzysztof Kozlowski wrote: > > From: Lihua Yao > > > > fin_pll is the parent of clock-controller@7e00f000, specify > > the dependency to ensure proper initialization order of clock > > providers. > > > Fixes: 3f6d439f2022 ("clk: reverse default clk provider initialization order in of_clk_init()") > > The patch looks good but I'm not sure above tag points to the right commit. > That commit is just a regression fix for > 1771b10d605d26cc "clk: respect the clock dependencies in of_clk_init" > > How about picking some commit touching the dts files itself, e.g. > a43736deb47d21bd "ARM: dts: Add dts file for S3C6410-based Mini6410 board" ? As I understood, the mentioned commit "reverse default clk provider" caused issue to appear, because of reversed order (first version of this patch played with the order). Even though that commit was not strictly the cause, but should come proably with proper DTS change. Therefore the fixes points to right moment of backports. The DTS commit, at that time, was correct with bindings and with driver. > > > Signed-off-by: Lihua Yao > > Signed-off-by: Krzysztof Kozlowski > > Reviewed-by: Sylwester Nawrocki Thanks! Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D96ECE58C for ; Tue, 8 Oct 2019 17:53:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7744F218AC for ; Tue, 8 Oct 2019 17:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570557217; bh=MwGh36UI/BopOFCDS3wjb/ZJxlTiw6fSQqmuXFC6O3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=uX9wAOMRnk8diD/84BEDVJSIWkGfYNB5sXRs19/xLidvYLK6xvwB3q+j7DKwuVRlM HtX7dnC7w+SZI5hu3zs3V4OEzz25Oc6VbHk5GkDkmdnVMQk/5QlBlnMYqWNBKesWed rXyb8J7VRA7oQv2blIOM7e9txYu7tnkEQ2kGaLak= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727865AbfJHRxg (ORCPT ); Tue, 8 Oct 2019 13:53:36 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:38915 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726320AbfJHRxg (ORCPT ); Tue, 8 Oct 2019 13:53:36 -0400 Received: by mail-wr1-f67.google.com with SMTP id r3so20477897wrj.6; Tue, 08 Oct 2019 10:53:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=biGUlUHt7gI+lvxrPWTuGpTY989m3mtLcUoswoyT+ig=; b=davgj+5BKG+8er/B+LZTJLQTVZ1G4T86SFHNpAuNQDneyi4R3nn9X5z2U7pkOvBuTD muikQ7XuoNiKJ7r1cjE6DRydDg3bg2aL/YZZhdZZ1I9hfua3emindWt5uvAxcCAQkG4H VyWRb42xKpfRLg/rM6pRzavU/FXcC/RvLj9cJUYlc6wXHkw6sObu1AXqVIANULvfQP3b 5u4Hfhu+mWaZWFsUOP70rYFrqL1vWo0CSZ+ONgMOsEWPGQOKtPRl5Jqrtv18qKbf5wsk IhQ0aj7LTnQL6MkJXeLYVGhYBv1ABBJ207x27fzgSHbVvZ3auf1mdwqRytLyEtluCY56 Yn4Q== X-Gm-Message-State: APjAAAVj22rl21sOkhzHAxeYjEUVgh76we8guM4IU8/Eca+BkQ8bZ9aW BzCyz7V1usaqVvPp5VIHPIvmtzWd X-Google-Smtp-Source: APXvYqxcSOUZjtZkaOPACSxR3aFYAuWRL9aDUd0khkLJhPdhJQE9JK92kwvKDqqNrk+Nxg2TFrTmZg== X-Received: by 2002:adf:eec1:: with SMTP id a1mr25802083wrp.151.1570557214261; Tue, 08 Oct 2019 10:53:34 -0700 (PDT) Received: from kozik-lap ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id r6sm4336796wmh.38.2019.10.08.10.53.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Oct 2019 10:53:33 -0700 (PDT) Date: Tue, 8 Oct 2019 19:53:30 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Cc: Lihua Yao , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: s3c64xx: Fix init order of clock providers Message-ID: <20191008175330.GA28160@kozik-lap> References: <20191008165917.23908-1-krzk@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Message-ID: <20191008175330.LicPxHTr6scwZB0-DxvU9Xvk6CeBmddYb8bcf-dLSEY@z> On Tue, Oct 08, 2019 at 07:30:50PM +0200, Sylwester Nawrocki wrote: > On 10/8/19 18:59, Krzysztof Kozlowski wrote: > > From: Lihua Yao > > > > fin_pll is the parent of clock-controller@7e00f000, specify > > the dependency to ensure proper initialization order of clock > > providers. > > > Fixes: 3f6d439f2022 ("clk: reverse default clk provider initialization order in of_clk_init()") > > The patch looks good but I'm not sure above tag points to the right commit. > That commit is just a regression fix for > 1771b10d605d26cc "clk: respect the clock dependencies in of_clk_init" > > How about picking some commit touching the dts files itself, e.g. > a43736deb47d21bd "ARM: dts: Add dts file for S3C6410-based Mini6410 board" ? As I understood, the mentioned commit "reverse default clk provider" caused issue to appear, because of reversed order (first version of this patch played with the order). Even though that commit was not strictly the cause, but should come proably with proper DTS change. Therefore the fixes points to right moment of backports. The DTS commit, at that time, was correct with bindings and with driver. > > > Signed-off-by: Lihua Yao > > Signed-off-by: Krzysztof Kozlowski > > Reviewed-by: Sylwester Nawrocki Thanks! Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA0DC4360C for ; Tue, 8 Oct 2019 17:53:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AC68206B6 for ; Tue, 8 Oct 2019 17:53:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kWP0Qoee" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AC68206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nVpMDLqsqAr3aPCVpbNuIGXa/IEF0z2HIvJHH5cMkd8=; b=kWP0Qoeeovl4Fs jbg2Acd31jKZvZNX77xg4t6OcVV/cCQSSgnE+xl6AP7W0ATZnxEIrtEAeOxx0fyqMQmSbhkkfRvac GYpK/AvvxzdxpsdJ5tBQL5O77FSFeU69Fh8cHTl0+CoQlvM42V5kOPrCPGPMewwhE6iJ+MxJSNrX1 pHGrzarn8X2NMM4cW7IiX49/tMkIdaoYjtrOj6dFkJBOZTfAWYlUIEC9271C/pCdiKKAEXdphRfbl aasDqsMXhsusKdFMXt8kDdPP3+ZGfMgl9pwPzBJYXk0TxxHq6R5Wt972it0Ul4Vm0/NmwS/scYUJ0 UEt6vmNQ7HR+gZD0rKsw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHtg3-0000oh-Ob; Tue, 08 Oct 2019 17:53:39 +0000 Received: from mail-wr1-f68.google.com ([209.85.221.68]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHtg0-0000oD-9d for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2019 17:53:37 +0000 Received: by mail-wr1-f68.google.com with SMTP id p14so19504432wro.4 for ; Tue, 08 Oct 2019 10:53:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=biGUlUHt7gI+lvxrPWTuGpTY989m3mtLcUoswoyT+ig=; b=GioZzfV70l98+b2zLle1dC5+KAl+MckDt83V0KSQovnopAs4oQuZrjNLoT4vEllg+8 kK/in0YNYG/jUI3kZpgPwJCm3x0v64gxUjWT1b8JRTJ36sDgY5Dm3O7/Tw22tgNIpAEt N6DDMw2dmGI4hM2zPviPtIl5hdqq1ezyA6DxHynSgZiptRQfZ/Z37DO3f0ChTOWfz+R4 V/Sk1BNaPrsqBUbWZ3kHDXYWfFWnsO0zj2rc1bRqxUhV1aX0u90+gjo5KEg47a94F6A8 qZQh1DukkI1JOPt0fmqrZRxVWYfONSJTpGlaTz7XtuPEo4Md11b0JWz6TEbt9umsNW4e tQTw== X-Gm-Message-State: APjAAAVo1WmQNf+2v40vEQv+CCu+iaoU8yN/XWDIha3wTaE7WQQWrFdu IcH3cqUbY6MIzFuW2LSUvYg= X-Google-Smtp-Source: APXvYqxcSOUZjtZkaOPACSxR3aFYAuWRL9aDUd0khkLJhPdhJQE9JK92kwvKDqqNrk+Nxg2TFrTmZg== X-Received: by 2002:adf:eec1:: with SMTP id a1mr25802083wrp.151.1570557214261; Tue, 08 Oct 2019 10:53:34 -0700 (PDT) Received: from kozik-lap ([194.230.155.145]) by smtp.googlemail.com with ESMTPSA id r6sm4336796wmh.38.2019.10.08.10.53.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 Oct 2019 10:53:33 -0700 (PDT) Date: Tue, 8 Oct 2019 19:53:30 +0200 From: Krzysztof Kozlowski To: Sylwester Nawrocki Subject: Re: [PATCH] ARM: dts: s3c64xx: Fix init order of clock providers Message-ID: <20191008175330.GA28160@kozik-lap> References: <20191008165917.23908-1-krzk@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191008_105336_335735_319570EB X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lihua Yao , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 08, 2019 at 07:30:50PM +0200, Sylwester Nawrocki wrote: > On 10/8/19 18:59, Krzysztof Kozlowski wrote: > > From: Lihua Yao > > > > fin_pll is the parent of clock-controller@7e00f000, specify > > the dependency to ensure proper initialization order of clock > > providers. > > > Fixes: 3f6d439f2022 ("clk: reverse default clk provider initialization order in of_clk_init()") > > The patch looks good but I'm not sure above tag points to the right commit. > That commit is just a regression fix for > 1771b10d605d26cc "clk: respect the clock dependencies in of_clk_init" > > How about picking some commit touching the dts files itself, e.g. > a43736deb47d21bd "ARM: dts: Add dts file for S3C6410-based Mini6410 board" ? As I understood, the mentioned commit "reverse default clk provider" caused issue to appear, because of reversed order (first version of this patch played with the order). Even though that commit was not strictly the cause, but should come proably with proper DTS change. Therefore the fixes points to right moment of backports. The DTS commit, at that time, was correct with bindings and with driver. > > > Signed-off-by: Lihua Yao > > Signed-off-by: Krzysztof Kozlowski > > Reviewed-by: Sylwester Nawrocki Thanks! Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel