All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Jules Irenge <jbi.octave@gmail.com>
Cc: outreachy-kernel@googlegroups.com, matthias.bgg@gmail.com
Subject: Re: [PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning
Date: Tue, 8 Oct 2019 19:58:01 +0200	[thread overview]
Message-ID: <20191008175801.GA3015744@kroah.com> (raw)
In-Reply-To: <20191008140552.25639-1-jbi.octave@gmail.com>

On Tue, Oct 08, 2019 at 03:05:52PM +0100, Jules Irenge wrote:
> Add blank line to fix missed blank line warning.
> Warning issued by checkpatch.pl tool:
> "WARNING: Missing a blank line after declarations".
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index d964642d95a3..e309923aed2c 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
>  	struct device_dma_parameters dma_parms;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;

Look at the code, does this look correct?  :)

thanks,

greg k-h


      parent reply	other threads:[~2019-10-08 17:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-08 14:05 [PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning Jules Irenge
2019-10-08 16:29 ` [Outreachy kernel] " Julia Lawall
2019-10-08 17:58 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008175801.GA3015744@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jbi.octave@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.