[PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning

[PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning

[Jules Irenge]

Add blank line to fix missed blank line warning.
Warning issued by checkpatch.pl tool:
"WARNING: Missing a blank line after declarations".

Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
 drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index d964642d95a3..e309923aed2c 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
 	struct device_dma_parameters dma_parms;
 	void __iomem *base;
 	struct tasklet_struct task;
+
 	volatile unsigned long chan_issued;
 
 	struct mtk_hsdma_chan chan[1];
-- 
2.21.0

Re: [Outreachy kernel] [PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning

[Julia Lawall]

On Tue, 8 Oct 2019, Jules Irenge wrote:

> Add blank line to fix missed blank line warning.
> Warning issued by checkpatch.pl tool:
> "WARNING: Missing a blank line after declarations".
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index d964642d95a3..e309923aed2c 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
>  	struct device_dma_parameters dma_parms;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;

This is also a declaration, so there should not be a blank line before it.

julia

>
>  	struct mtk_hsdma_chan chan[1];
> --
> 2.21.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191008140552.25639-1-jbi.octave%40gmail.com.
>

Re: [PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning

[Greg KH]

On Tue, Oct 08, 2019 at 03:05:52PM +0100, Jules Irenge wrote:
> Add blank line to fix missed blank line warning.
> Warning issued by checkpatch.pl tool:
> "WARNING: Missing a blank line after declarations".
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
>  drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index d964642d95a3..e309923aed2c 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
>  	struct device_dma_parameters dma_parms;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;

Look at the code, does this look correct?  :)

thanks,

greg k-h