* [PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning
@ 2019-10-08 14:05 Jules Irenge
2019-10-08 16:29 ` [Outreachy kernel] " Julia Lawall
2019-10-08 17:58 ` Greg KH
0 siblings, 2 replies; 3+ messages in thread
From: Jules Irenge @ 2019-10-08 14:05 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, matthias.bgg, Jules Irenge
Add blank line to fix missed blank line warning.
Warning issued by checkpatch.pl tool:
"WARNING: Missing a blank line after declarations".
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index d964642d95a3..e309923aed2c 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
struct device_dma_parameters dma_parms;
void __iomem *base;
struct tasklet_struct task;
+
volatile unsigned long chan_issued;
struct mtk_hsdma_chan chan[1];
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning
2019-10-08 14:05 [PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning Jules Irenge
@ 2019-10-08 16:29 ` Julia Lawall
2019-10-08 17:58 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2019-10-08 16:29 UTC (permalink / raw)
To: Jules Irenge; +Cc: outreachy-kernel, gregkh, matthias.bgg
On Tue, 8 Oct 2019, Jules Irenge wrote:
> Add blank line to fix missed blank line warning.
> Warning issued by checkpatch.pl tool:
> "WARNING: Missing a blank line after declarations".
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index d964642d95a3..e309923aed2c 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
> struct device_dma_parameters dma_parms;
> void __iomem *base;
> struct tasklet_struct task;
> +
> volatile unsigned long chan_issued;
This is also a declaration, so there should not be a blank line before it.
julia
>
> struct mtk_hsdma_chan chan[1];
> --
> 2.21.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191008140552.25639-1-jbi.octave%40gmail.com.
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning
2019-10-08 14:05 [PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning Jules Irenge
2019-10-08 16:29 ` [Outreachy kernel] " Julia Lawall
@ 2019-10-08 17:58 ` Greg KH
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2019-10-08 17:58 UTC (permalink / raw)
To: Jules Irenge; +Cc: outreachy-kernel, matthias.bgg
On Tue, Oct 08, 2019 at 03:05:52PM +0100, Jules Irenge wrote:
> Add blank line to fix missed blank line warning.
> Warning issued by checkpatch.pl tool:
> "WARNING: Missing a blank line after declarations".
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/mt7621-dma/mtk-hsdma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index d964642d95a3..e309923aed2c 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -157,6 +157,7 @@ struct mtk_hsdam_engine {
> struct device_dma_parameters dma_parms;
> void __iomem *base;
> struct tasklet_struct task;
> +
> volatile unsigned long chan_issued;
Look at the code, does this look correct? :)
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-08 17:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-08 14:05 [PATCH] staging: mt7621-dma: add a blank line to fix checkpatch warning Jules Irenge
2019-10-08 16:29 ` [Outreachy kernel] " Julia Lawall
2019-10-08 17:58 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.