All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Martin <Dave.Martin@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: linux-kselftest@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, shuah@kernel.org,
	amit.kachhap@arm.com, andreyknvl@google.com
Subject: Re: [PATCH v7 02/11] kselftest: arm64: mangle_pstate_invalid_compat_toggle and common utils
Date: Tue, 8 Oct 2019 19:01:19 +0100	[thread overview]
Message-ID: <20191008180119.GZ27757@arm.com> (raw)
In-Reply-To: <20191007182954.25730-3-cristian.marussi@arm.com>

On Mon, Oct 07, 2019 at 07:29:45pm +0100, Cristian Marussi wrote:
> Add some arm64/signal specific boilerplate and utility code to help
> further testcases' development.
> 
> Introduce also one simple testcase mangle_pstate_invalid_compat_toggle
> and some related helpers: it is a simple mangle testcase which messes
> with the ucontext_t from within the signal handler, trying to toggle
> PSTATE state bits to switch the system between 32bit/64bit execution
> state. Expects SIGSEGV on test PASS.
> 
> Reviewed-by: Dave Martin <Dave.Martin@arm.com>
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
> v6 --> v7
> - removed ambiguos fprintf in test_init
> - fixed spacing

[...]

> diff --git a/tools/testing/selftests/arm64/signal/test_signals.h b/tools/testing/selftests/arm64/signal/test_signals.h

[...]

> +/* Local Helpers */
> +#define ID_AA64MMFR1_EL1_PAN_SUPPORTED(val) \
> +	(!!((val) & (0xfUL << ID_AA64MMFR1_PAN_SHIFT)))
> +#define ID_AA64MMFR2_EL1_UAO_SUPPORTED(val) \
> +	(!!((val) & (0xfUL << ID_AA64MMFR2_UAO_SHIFT)))
> +
> +#define SSBS_SYSREG		S3_3_C4_C2_6	/* EL0 supported */

Does anything in the series still use SSBS_SYSREG?

If not, please drop it.  No need to remove my Reviewed-by just for thato
change.

[...]

Cheers
---Dave

WARNING: multiple messages have this Message-ID (diff)
From: Dave Martin <Dave.Martin@arm.com>
To: Cristian Marussi <cristian.marussi@arm.com>
Cc: amit.kachhap@arm.com, andreyknvl@google.com, shuah@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v7 02/11] kselftest: arm64: mangle_pstate_invalid_compat_toggle and common utils
Date: Tue, 8 Oct 2019 19:01:19 +0100	[thread overview]
Message-ID: <20191008180119.GZ27757@arm.com> (raw)
In-Reply-To: <20191007182954.25730-3-cristian.marussi@arm.com>

On Mon, Oct 07, 2019 at 07:29:45pm +0100, Cristian Marussi wrote:
> Add some arm64/signal specific boilerplate and utility code to help
> further testcases' development.
> 
> Introduce also one simple testcase mangle_pstate_invalid_compat_toggle
> and some related helpers: it is a simple mangle testcase which messes
> with the ucontext_t from within the signal handler, trying to toggle
> PSTATE state bits to switch the system between 32bit/64bit execution
> state. Expects SIGSEGV on test PASS.
> 
> Reviewed-by: Dave Martin <Dave.Martin@arm.com>
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
> v6 --> v7
> - removed ambiguos fprintf in test_init
> - fixed spacing

[...]

> diff --git a/tools/testing/selftests/arm64/signal/test_signals.h b/tools/testing/selftests/arm64/signal/test_signals.h

[...]

> +/* Local Helpers */
> +#define ID_AA64MMFR1_EL1_PAN_SUPPORTED(val) \
> +	(!!((val) & (0xfUL << ID_AA64MMFR1_PAN_SHIFT)))
> +#define ID_AA64MMFR2_EL1_UAO_SUPPORTED(val) \
> +	(!!((val) & (0xfUL << ID_AA64MMFR2_UAO_SHIFT)))
> +
> +#define SSBS_SYSREG		S3_3_C4_C2_6	/* EL0 supported */

Does anything in the series still use SSBS_SYSREG?

If not, please drop it.  No need to remove my Reviewed-by just for thato
change.

[...]

Cheers
---Dave

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-08 18:01 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 18:29 [PATCH v7 00/11] Add arm64/signal initial kselftest support Cristian Marussi
2019-10-07 18:29 ` Cristian Marussi
2019-10-07 18:29 ` [PATCH v7 01/11] kselftest: arm64: extend toplevel skeleton Makefile Cristian Marussi
2019-10-07 18:29   ` Cristian Marussi
2019-10-07 18:29 ` [PATCH v7 02/11] kselftest: arm64: mangle_pstate_invalid_compat_toggle and common utils Cristian Marussi
2019-10-07 18:29   ` Cristian Marussi
2019-10-08 18:01   ` Dave Martin [this message]
2019-10-08 18:01     ` Dave Martin
2019-10-09  7:47     ` Cristian Marussi
2019-10-09  7:47       ` Cristian Marussi
2019-10-07 18:29 ` [PATCH v7 03/11] kselftest: arm64: mangle_pstate_invalid_daif_bits Cristian Marussi
2019-10-07 18:29   ` Cristian Marussi
2019-10-07 18:29 ` [PATCH v7 04/11] kselftest: arm64: mangle_pstate_invalid_mode_el[123][ht] Cristian Marussi
2019-10-07 18:29   ` Cristian Marussi
2019-10-07 18:29 ` [PATCH v7 05/11] kselftest: arm64: mangle_pstate_ssbs_regs Cristian Marussi
2019-10-07 18:29   ` Cristian Marussi
2019-10-08 18:01   ` Dave Martin
2019-10-08 18:01     ` Dave Martin
2019-10-09  7:52     ` Cristian Marussi
2019-10-09  7:52       ` Cristian Marussi
2019-10-07 18:29 ` [PATCH v7 06/11] kselftest: arm64: fake_sigreturn_bad_magic Cristian Marussi
2019-10-07 18:29   ` Cristian Marussi
2019-10-08 18:01   ` Dave Martin
2019-10-08 18:01     ` Dave Martin
2019-10-07 18:29 ` [PATCH v7 07/11] kselftest: arm64: fake_sigreturn_bad_size_for_magic0 Cristian Marussi
2019-10-07 18:29   ` Cristian Marussi
2019-10-07 18:29 ` [PATCH v7 08/11] kselftest: arm64: fake_sigreturn_missing_fpsimd Cristian Marussi
2019-10-07 18:29   ` Cristian Marussi
2019-10-07 18:29 ` [PATCH v7 09/11] kselftest: arm64: fake_sigreturn_duplicated_fpsimd Cristian Marussi
2019-10-07 18:29   ` Cristian Marussi
2019-10-07 18:29 ` [PATCH v7 10/11] kselftest: arm64: fake_sigreturn_bad_size Cristian Marussi
2019-10-07 18:29   ` Cristian Marussi
2019-10-07 18:29 ` [PATCH v7 11/11] kselftest: arm64: fake_sigreturn_misaligned_sp Cristian Marussi
2019-10-07 18:29   ` Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191008180119.GZ27757@arm.com \
    --to=dave.martin@arm.com \
    --cc=amit.kachhap@arm.com \
    --cc=andreyknvl@google.com \
    --cc=cristian.marussi@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.