From: Stephen Hemminger <stephen@networkplumber.org>
To: Tariq Toukan <tariqt@mellanox.com>
Cc: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, Moshe Shemesh <moshe@mellanox.com>,
Aya Levin <ayal@mellanox.com>, Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH V2 iproute2 0/3] Devlink health FMSG fixes and enhancements
Date: Tue, 8 Oct 2019 20:23:22 -0700 [thread overview]
Message-ID: <20191008202322.747f0c63@hermes.lan> (raw)
In-Reply-To: <1570026916-27592-1-git-send-email-tariqt@mellanox.com>
On Wed, 2 Oct 2019 17:35:13 +0300
Tariq Toukan <tariqt@mellanox.com> wrote:
> Hi,
>
> This patchset by Aya enhances FMSG output and fixes bugs in devlink health.
>
> Patch 1 adds a helper function wrapping repeating code which determines
> whether left-hand-side space separator in needed or not. It's not
> needed after a newline.
> Patch 2 fixes left justification of FMSG output. Prior to this patch
> the FMSG output had an extra space on the left-hand-side. This patch
> avoids this by looking at a flag turned on by pr_out_new_line.
> Patch 3 fixes inconsistency between input and output in devlink health
> show command.
>
> Series generated against master commit:
> 8c2093e5d20c ip vrf: Add json support for show command
>
> Thanks,
> Tariq
>
> V2:
> - Dropped 4th patch, similar one is already accepted:
> 4fb98f08956f devlink: fix segfault on health command
>
> Aya Levin (3):
> devlink: Add helper for left justification print
> devlink: Left justification on FMSG output
> devlink: Fix inconsistency between command input and output
>
> devlink/devlink.c | 62 +++++++++++++++++++++++------------------------
> 1 file changed, 31 insertions(+), 31 deletions(-)
>
Series applied.
prev parent reply other threads:[~2019-10-09 3:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 14:35 [PATCH V2 iproute2 0/3] Devlink health FMSG fixes and enhancements Tariq Toukan
2019-10-02 14:35 ` [PATCH V2 iproute2 1/3] devlink: Add helper for left justification print Tariq Toukan
2019-10-02 14:48 ` Stephen Hemminger
2019-10-02 17:14 ` Jiri Pirko
2019-10-02 14:35 ` [PATCH V2 iproute2 2/3] devlink: Left justification on FMSG output Tariq Toukan
2019-10-02 14:35 ` [PATCH V2 iproute2 3/3] devlink: Fix inconsistency between command input and output Tariq Toukan
2019-10-09 3:23 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008202322.747f0c63@hermes.lan \
--to=stephen@networkplumber.org \
--cc=ayal@mellanox.com \
--cc=dsahern@gmail.com \
--cc=jiri@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.