From mboxrd@z Thu Jan 1 00:00:00 1970 From: "james qian wang (Arm Technology China)" Subject: Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints Date: Wed, 9 Oct 2019 05:54:15 +0000 Message-ID: <20191009055407.GA3082@jamwan02-TSP300> References: <20191004143418.53039-4-mihail.atanassov@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40041.outbound.protection.outlook.com [40.107.4.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6628A6E8D4 for ; Wed, 9 Oct 2019 05:54:30 +0000 (UTC) In-Reply-To: <20191004143418.53039-4-mihail.atanassov@arm.com> Content-Language: en-US Content-ID: <6636E9631376EA46B83E0EA87169D253@eurprd08.prod.outlook.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mihail Atanassov Cc: David Airlie , Liviu Dudau , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Russell King , Maxime Ripard , nd , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBPY3QgMDQsIDIwMTkgYXQgMDI6MzQ6NDJQTSArMDAwMCwgTWloYWlsIEF0YW5hc3Nv diB3cm90ZToKPiBUbyBzdXBwb3J0IHRyYW5zbWl0dGVycyBvdGhlciB0aGFuIHRoZSB0ZGE5OTh4 LCB3ZSBuZWVkIHRvIGFsbG93Cj4gbm9uLWNvbXBvbmVudCBmcmFtZXdvcmsgYnJpZGdlcyB0byBi ZSBhdHRhY2hlZCB0byBhIGR1bW15IGRybV9lbmNvZGVyIGluCj4gb3VyIGRyaXZlci4KPiAKPiBG b3IgdGhlIGV4aXN0aW5nIHN1cHBvcnRlZCBlbmNvZGVyICh0ZGE5OTh4KSwga2VlcCB0aGUgYmVo YXZpb3VyIGFzLWlzLAo+IHNpbmNlIHRoZXJlJ3Mgbm8gd2F5IHRvIHVuYmluZCBpZiBhIGRybV9i cmlkZ2UgbW9kdWxlIGdvZXMgYXdheSB1bmRlcgo+IG91ciBmZWV0Lgo+IAo+IFNpZ25lZC1vZmYt Ynk6IE1paGFpbCBBdGFuYXNzb3YgPG1paGFpbC5hdGFuYXNzb3ZAYXJtLmNvbT4KPiAtLS0KPiAg Li4uL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tvbWVkYV9kZXYuaCAgIHwgICA1ICsKPiAg Li4uL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tvbWVkYV9kcnYuYyAgIHwgIDU4ICsrKysr Ky0tCj4gIC4uLi9ncHUvZHJtL2FybS9kaXNwbGF5L2tvbWVkYS9rb21lZGFfa21zLmMgICB8IDEz MyArKysrKysrKysrKysrKysrKy0KPiAgLi4uL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tv bWVkYV9rbXMuaCAgIHwgICA1ICsKPiAgNCBmaWxlcyBjaGFuZ2VkLCAxODcgaW5zZXJ0aW9ucygr KSwgMTQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hcm0v ZGlzcGxheS9rb21lZGEva29tZWRhX2Rldi5oIGIvZHJpdmVycy9ncHUvZHJtL2FybS9kaXNwbGF5 L2tvbWVkYS9rb21lZGFfZGV2LmgKPiBpbmRleCBlMzkyYjhmZmMzNzIuLjY0ZDI5MDJlMmUwYyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tvbWVkYV9k ZXYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hcm0vZGlzcGxheS9rb21lZGEva29tZWRhX2Rl di5oCj4gQEAgLTE3Niw2ICsxNzYsMTEgQEAgc3RydWN0IGtvbWVkYV9kZXYgewo+ICAKPiAgCS8q KiBAaXJxOiBpcnEgbnVtYmVyICovCj4gIAlpbnQgaXJxOwo+ICsJLyoqIEBoYXNfY29tcG9uZW50 czoKPiArCSAqCj4gKwkgKiBpZiB0cnVlLCB1c2UgdGhlIGNvbXBvbmVudCBmcmFtZXdvcmsgdG8g YmluZC91bmJpbmQgZHJpdmVyCj4gKwkgKi8KPiArCWJvb2wgaGFzX2NvbXBvbmVudHM7Cj4gIAo+ ICAJLyoqIEBsb2NrOiB1c2VkIHRvIHByb3RlY3QgZHBtb2RlICovCj4gIAlzdHJ1Y3QgbXV0ZXgg bG9jazsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybS9kaXNwbGF5L2tvbWVkYS9r b21lZGFfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tvbWVkYV9k cnYuYwo+IGluZGV4IDllZDI1ZmZlMGUyMi4uMzRjZmM2YTRjM2U0IDEwMDY0NAo+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9hcm0vZGlzcGxheS9rb21lZGEva29tZWRhX2Rydi5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2FybS9kaXNwbGF5L2tvbWVkYS9rb21lZGFfZHJ2LmMKPiBAQCAtMTAsNiAr MTAsOCBAQAo+ICAjaW5jbHVkZSA8bGludXgvY29tcG9uZW50Lmg+Cj4gICNpbmNsdWRlIDxsaW51 eC9wbV9ydW50aW1lLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX29mLmg+Cj4gKyNpbmNsdWRlIDxk cm0vZHJtX2JyaWRnZS5oPgo+ICsjaW5jbHVkZSA8ZHJtL2RybV9lbmNvZGVyLmg+Cj4gICNpbmNs dWRlICJrb21lZGFfZGV2LmgiCj4gICNpbmNsdWRlICJrb21lZGFfa21zLmgiCj4gIAo+IEBAIC02 OSwxOCArNzEsMzUgQEAgc3RhdGljIGludCBjb21wYXJlX29mKHN0cnVjdCBkZXZpY2UgKmRldiwg dm9pZCAqZGF0YSkKPiAgCXJldHVybiBkZXYtPm9mX25vZGUgPT0gZGF0YTsKPiAgfQo+ICAKPiAt c3RhdGljIHZvaWQga29tZWRhX2FkZF9zbGF2ZShzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsCj4gLQkJ CSAgICAgc3RydWN0IGNvbXBvbmVudF9tYXRjaCAqKm1hdGNoLAo+IC0JCQkgICAgIHN0cnVjdCBk ZXZpY2Vfbm9kZSAqbnAsCj4gLQkJCSAgICAgdTMyIHBvcnQsIHUzMiBlbmRwb2ludCkKPiArc3Rh dGljIGludCBrb21lZGFfYWRkX3NsYXZlKHN0cnVjdCBkZXZpY2UgKm1hc3RlciwKPiArCQkJICAg IHN0cnVjdCBrb21lZGFfZHJ2ICptZHJ2LAo+ICsJCQkgICAgc3RydWN0IGNvbXBvbmVudF9tYXRj aCAqKm1hdGNoLAo+ICsJCQkgICAgc3RydWN0IGRldmljZV9ub2RlICpucCwKPiArCQkJICAgIHUz MiBwb3J0LCB1MzIgZW5kcG9pbnQpCj4gIHsKPiAgCXN0cnVjdCBkZXZpY2Vfbm9kZSAqcmVtb3Rl Owo+ICsJc3RydWN0IGRybV9icmlkZ2UgKmJyaWRnZTsKPiArCWludCByZXQgPSAwOwo+ICAKPiAg CXJlbW90ZSA9IG9mX2dyYXBoX2dldF9yZW1vdGVfbm9kZShucCwgcG9ydCwgZW5kcG9pbnQpOwo+ IC0JaWYgKHJlbW90ZSkgewo+ICsJaWYgKCFyZW1vdGUpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJ aWYgKGtvbWVkYV9yZW1vdGVfZGV2aWNlX2lzX2NvbXBvbmVudChucCwgcG9ydCwgZW5kcG9pbnQp KSB7Cj4gKwkJbWRydi0+bWRldi5oYXNfY29tcG9uZW50cyA9IHRydWU7Cj4gIAkJZHJtX29mX2Nv bXBvbmVudF9tYXRjaF9hZGQobWFzdGVyLCBtYXRjaCwgY29tcGFyZV9vZiwgcmVtb3RlKTsKPiAt CQlvZl9ub2RlX3B1dChyZW1vdGUpOwo+ICsJCWdvdG8gZXhpdDsKPiArCX0KPiArCj4gKwlicmlk Z2UgPSBvZl9kcm1fZmluZF9icmlkZ2UocmVtb3RlKTsKPiArCWlmICghYnJpZGdlKSB7Cj4gKwkJ cmV0ID0gLUVQUk9CRV9ERUZFUjsKPiArCQlnb3RvIGV4aXQ7Cj4gIAl9Cj4gKwo+ICtleGl0Ogo+ ICsJb2Zfbm9kZV9wdXQocmVtb3RlKTsKPiArCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gIHN0YXRp YyBpbnQga29tZWRhX3BsYXRmb3JtX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYp Cj4gQEAgLTg5LDYgKzEwOCw3IEBAIHN0YXRpYyBpbnQga29tZWRhX3BsYXRmb3JtX3Byb2JlKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAlzdHJ1Y3QgY29tcG9uZW50X21hdGNoICpt YXRjaCA9IE5VTEw7Cj4gIAlzdHJ1Y3QgZGV2aWNlX25vZGUgKmNoaWxkOwo+ICAJc3RydWN0IGtv bWVkYV9kcnYgKm1kcnY7Cj4gKwlpbnQgcmV0Owo+ICAKPiAgCWlmICghZGV2LT5vZl9ub2RlKQo+ ICAJCXJldHVybiAtRU5PREVWOwo+IEBAIC0xMDEsMTQgKzEyMSwyNyBAQCBzdGF0aWMgaW50IGtv bWVkYV9wbGF0Zm9ybV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJCWlm IChvZl9ub2RlX2NtcChjaGlsZC0+bmFtZSwgInBpcGVsaW5lIikgIT0gMCkKPiAgCQkJY29udGlu dWU7Cj4gIAo+IC0JCS8qIGFkZCBjb25uZWN0b3IgKi8KPiAtCQlrb21lZGFfYWRkX3NsYXZlKGRl diwgJm1hdGNoLCBjaGlsZCwgS09NRURBX09GX1BPUlRfT1VUUFVULCAwKTsKPiAtCQlrb21lZGFf YWRkX3NsYXZlKGRldiwgJm1hdGNoLCBjaGlsZCwgS09NRURBX09GX1BPUlRfT1VUUFVULCAxKTsK PiArCQkvKiBhdHRhY2ggYW55IHJlbW90ZSBkZXZpY2VzIGlmIHByZXNlbnQgKi8KPiArCQlyZXQg PSBrb21lZGFfYWRkX3NsYXZlKGRldiwgbWRydiwgJm1hdGNoLCBjaGlsZCwKPiArCQkJCSAgICAg ICBLT01FREFfT0ZfUE9SVF9PVVRQVVQsIDApOwo+ICsJCWlmIChyZXQpCj4gKwkJCWdvdG8gZnJl ZV9tZHJ2Owo+ICsJCXJldCA9IGtvbWVkYV9hZGRfc2xhdmUoZGV2LCBtZHJ2LCAmbWF0Y2gsIGNo aWxkLAo+ICsJCQkJICAgICAgIEtPTUVEQV9PRl9QT1JUX09VVFBVVCwgMSk7Cj4gKwkJaWYgKHJl dCkKPiArCQkJZ290byBmcmVlX21kcnY7Cj4gIAl9Cj4gIAo+ICAJZGV2X3NldF9kcnZkYXRhKGRl diwgbWRydik7Cj4gIAo+IC0JcmV0dXJuIGNvbXBvbmVudF9tYXN0ZXJfYWRkX3dpdGhfbWF0Y2go ZGV2LCAma29tZWRhX21hc3Rlcl9vcHMsIG1hdGNoKTsKPiArCXJldHVybiBtZHJ2LT5tZGV2Lmhh c19jb21wb25lbnRzCj4gKwkJPyBjb21wb25lbnRfbWFzdGVyX2FkZF93aXRoX21hdGNoKAo+ICsJ CQlkZXYsICZrb21lZGFfbWFzdGVyX29wcywgbWF0Y2gpCj4gKwkJOiBrb21lZGFfYmluZChkZXYp Owo+ICsKPiArZnJlZV9tZHJ2Ogo+ICsJZGV2bV9rZnJlZShkZXYsIG1kcnYpOwo+ICsJcmV0dXJu IHJldDsKPiAgfQo+ICAKPiAgc3RhdGljIGludCBrb21lZGFfcGxhdGZvcm1fcmVtb3ZlKHN0cnVj dCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gQEAgLTExNiw3ICsxNDksMTAgQEAgc3RhdGljIGlu dCBrb21lZGFfcGxhdGZvcm1fcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4g IAlzdHJ1Y3QgZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2Owo+ICAJc3RydWN0IGtvbWVkYV9kcnYg Km1kcnYgPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKPiAgCj4gLQljb21wb25lbnRfbWFzdGVyX2Rl bChkZXYsICZrb21lZGFfbWFzdGVyX29wcyk7Cj4gKwlpZiAobWRydi0+bWRldi5oYXNfY29tcG9u ZW50cykKPiArCQljb21wb25lbnRfbWFzdGVyX2RlbChkZXYsICZrb21lZGFfbWFzdGVyX29wcyk7 Cj4gKwllbHNlCj4gKwkJa29tZWRhX3VuYmluZChkZXYpOwo+ICAKPiAgCWRldl9zZXRfZHJ2ZGF0 YShkZXYsIE5VTEwpOwo+ICAJZGV2bV9rZnJlZShkZXYsIG1kcnYpOwo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tvbWVkYV9rbXMuYyBiL2RyaXZlcnMv Z3B1L2RybS9hcm0vZGlzcGxheS9rb21lZGEva29tZWRhX2ttcy5jCj4gaW5kZXggMDNkY2YxZDc2 ODhmLi42ZWI1MmQxYjIwYTAgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FybS9kaXNw bGF5L2tvbWVkYS9rb21lZGFfa21zLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYXJtL2Rpc3Bs YXkva29tZWRhL2tvbWVkYV9rbXMuYwo+IEBAIC02LDYgKzYsNyBAQAo+ICAgKi8KPiAgI2luY2x1 ZGUgPGxpbnV4L2NvbXBvbmVudC5oPgo+ICAjaW5jbHVkZSA8bGludXgvaW50ZXJydXB0Lmg+Cj4g KyNpbmNsdWRlIDxsaW51eC9vZl9ncmFwaC5oPgo+ICAKPiAgI2luY2x1ZGUgPGRybS9kcm1fYXRv bWljLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2F0b21pY19oZWxwZXIuaD4KPiBAQCAtMTQsNiAr MTUsOCBAQAo+ICAjaW5jbHVkZSA8ZHJtL2RybV9nZW1fY21hX2hlbHBlci5oPgo+ICAjaW5jbHVk ZSA8ZHJtL2RybV9nZW1fZnJhbWVidWZmZXJfaGVscGVyLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJt X2lycS5oPgo+ICsjaW5jbHVkZSA8ZHJtL2RybV9tb2Rlcy5oPgo+ICsjaW5jbHVkZSA8ZHJtL2Ry bV9vZi5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9wcm9iZV9oZWxwZXIuaD4KPiAgI2luY2x1ZGUg PGRybS9kcm1fdmJsYW5rLmg+Cj4gIAo+IEBAIC0yNjcsNiArMjcwLDEzMCBAQCBzdGF0aWMgdm9p ZCBrb21lZGFfa21zX21vZGVfY29uZmlnX2luaXQoc3RydWN0IGtvbWVkYV9rbXNfZGV2ICprbXMs Cj4gIAljb25maWctPmhlbHBlcl9wcml2YXRlID0gJmtvbWVkYV9tb2RlX2NvbmZpZ19oZWxwZXJz Owo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBrb21lZGFfZW5jb2Rlcl9kZXN0cm95KHN0cnVjdCBk cm1fZW5jb2RlciAqZW5jb2RlcikKPiArewo+ICsJZHJtX2VuY29kZXJfY2xlYW51cChlbmNvZGVy KTsKPiArfQo+ICsKPiArc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZW5jb2Rlcl9mdW5jcyBrb21l ZGFfZHVtbXlfZW5jX2Z1bmNzID0gewo+ICsJLmRlc3Ryb3kgPSBrb21lZGFfZW5jb2Rlcl9kZXN0 cm95LAo+ICt9Owo+ICsKPiArYm9vbCBrb21lZGFfcmVtb3RlX2RldmljZV9pc19jb21wb25lbnQo c3RydWN0IGRldmljZV9ub2RlICpsb2NhbCwKPiArCQkJCSAgICAgICB1MzIgcG9ydCwgdTMyIGVu ZHBvaW50KQo+ICt7Cj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKnJlbW90ZTsKPiArCWNoYXIgY29u c3QgKiBjb25zdCBjb21wb25lbnRfZGV2aWNlc1tdID0gewo+ICsJCSJueHAsdGRhOTk4eCIsCgpJ IHJlYWxseSBkb24ndCB0aGluayBwdXQgdGhpcyBkdW1teV9lbmNvZGVyIGludG8ga29tZWRhIGlz IGEgZ29vZAppZGVhLgoKQW5kIEkgc3VnZ2VzdCB0byBzZXBlcmF0ZSB0aGlzIGR1bW15X2VuY29k ZXIgdG8gYSBpbmRpdmlkdWFsIG1vZHVsZQp3aGljaCB3aWxsIGJ1aWxkIHRoZSBkcm1fcmlkZ2Ug dG8gYSBzdGFuZGFyZCBkcm0gZW5jb2RlciBhbmQgY29tcG9uZW50CmJhc2VkIG1vZHVsZSwgd2hp Y2ggd2lsbCBiZSBlbmFibGUgYnkgRFQsIHRvdGFsbHkgdHJhbnNwYXJlbnQgZm9yIGtvbWVkYS4K CkJUVzoKSSByZWFsbHkgZG9uJ3QgbGlrZSBzdWNoIGxvZ2ljOiBkaXN0aW5ndXNoIHRoZSBTWVNU RU0gY29uZmlndXJhdGlvbgpieSBjaGVjayB0aGUgY29ubmVjdGVkIGRldmljZSBuYW1lLCBpdCdz IGhhcmQgdG8gbWFpbnRhaW4gYW5kIGNvZGUKc2hhcmluZywgYW5kIHRoYXQncyB3aHkgTk9XIHdl IGhhdmUgdGhlIGRldmljZS10cmVlLgoKVGhhbmtzCkphbWVzCgo+ICsJfTsKPiArCWludCBpOwo+ ICsJYm9vbCByZXQgPSBmYWxzZTsKPiArCj4gKwlyZW1vdGUgPSBvZl9ncmFwaF9nZXRfcmVtb3Rl X25vZGUobG9jYWwsIHBvcnQsIGVuZHBvaW50KTsKPiArCWlmICghcmVtb3RlKQo+ICsJCXJldHVy biBmYWxzZTsKPiArCj4gKwkvKiBDb3Byb2Nlc3NvciBlbmRwb2ludHMgYXJlIGFsd2F5cyBjb21w b25lbnQgYmFzZWQuICovCj4gKwlpZiAocG9ydCAhPSBLT01FREFfT0ZfUE9SVF9PVVRQVVQpIHsK PiArCQlyZXQgPSB0cnVlOwo+ICsJCWdvdG8gZXhpdDsKPiArCX0KPiArCj4gKwlmb3IgKGkgPSAw OyBpIDwgQVJSQVlfU0laRShjb21wb25lbnRfZGV2aWNlcyk7ICsraSkgewo+ICsJCWlmIChvZl9k ZXZpY2VfaXNfY29tcGF0aWJsZShyZW1vdGUsIGNvbXBvbmVudF9kZXZpY2VzW2ldKSkgewo+ICsJ CQlyZXQgPSB0cnVlOwo+ICsJCQlnb3RvIGV4aXQ7Cj4gKwkJfQo+ICsJfQo+ICsKPiArZXhpdDoK PiArCW9mX25vZGVfcHV0KHJlbW90ZSk7Cj4gKwlyZXR1cm4gcmV0Owo+ICt9Cj4gKwo+ICtzdGF0 aWMgaW50IGtvbWVkYV9lbmNvZGVyX2F0dGFjaF9icmlkZ2Uoc3RydWN0IGtvbWVkYV9kZXYgKm1k ZXYsCj4gKwkJCQkJc3RydWN0IGtvbWVkYV9rbXNfZGV2ICprbXMsCj4gKwkJCQkJc3RydWN0IGRy bV9lbmNvZGVyICplbmNvZGVyLAo+ICsJCQkJCXN0cnVjdCBkZXZpY2Vfbm9kZSAqbnApCj4gK3sK PiArCXN0cnVjdCBkZXZpY2Vfbm9kZSAqcmVtb3RlOwo+ICsJc3RydWN0IGRybV9icmlkZ2UgKmJy aWRnZTsKPiArCXUzMiBjcnRjcyA9IDA7Cj4gKwlpbnQgcmV0ID0gMDsKPiArCj4gKwlpZiAoa29t ZWRhX3JlbW90ZV9kZXZpY2VfaXNfY29tcG9uZW50KG5wLCBLT01FREFfT0ZfUE9SVF9PVVRQVVQs IDApKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCXJlbW90ZSA9IG9mX2dyYXBoX2dldF9yZW1vdGVf bm9kZShucCwgS09NRURBX09GX1BPUlRfT1VUUFVULCAwKTsKPiArCWlmICghcmVtb3RlKQo+ICsJ CXJldHVybiAwOwo+ICsKPiArCWJyaWRnZSA9IG9mX2RybV9maW5kX2JyaWRnZShyZW1vdGUpOwo+ ICsJaWYgKCFicmlkZ2UpIHsKPiArCQlyZXQgPSAtRUlOVkFMOwo+ICsJCWdvdG8gZXhpdDsKPiAr CX0KPiArCj4gKwljcnRjcyA9IGRybV9vZl9maW5kX3Bvc3NpYmxlX2NydGNzKCZrbXMtPmJhc2Us IHJlbW90ZSk7Cj4gKwo+ICsJZW5jb2Rlci0+cG9zc2libGVfY3J0Y3MgPSBjcnRjcyA/IGNydGNz IDogMTsKPiArCj4gKwlyZXQgPSBkcm1fZW5jb2Rlcl9pbml0KCZrbXMtPmJhc2UsIGVuY29kZXIs Cj4gKwkJCSAgICAgICAma29tZWRhX2R1bW15X2VuY19mdW5jcywgRFJNX01PREVfRU5DT0RFUl9U TURTLAo+ICsJCQkgICAgICAgTlVMTCk7Cj4gKwlpZiAocmV0KQo+ICsJCWdvdG8gZXhpdDsKPiAr Cj4gKwlyZXQgPSBkcm1fYnJpZGdlX2F0dGFjaChlbmNvZGVyLCBicmlkZ2UsIE5VTEwpOwo+ICsJ aWYgKHJldCkKPiArCQlnb3RvIGV4aXQ7Cj4gKwo+ICtleGl0Ogo+ICsJb2Zfbm9kZV9wdXQocmVt b3RlKTsKPiArCXJldHVybiByZXQ7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQga29tZWRhX2VuY29k ZXJfYXR0YWNoX2JyaWRnZXMoc3RydWN0IGtvbWVkYV9rbXNfZGV2ICprbXMsCj4gKwkJCQkJIHN0 cnVjdCBrb21lZGFfZGV2ICptZGV2KQo+ICt7Cj4gKwlpbnQgaSwgZXJyOwo+ICsKPiArCWZvciAo aSA9IDA7IGkgPCBrbXMtPm5fY3J0Y3M7IGkrKykgewo+ICsJCWVyciA9IGtvbWVkYV9lbmNvZGVy X2F0dGFjaF9icmlkZ2UoCj4gKwkJCW1kZXYsIGttcywKPiArCQkJJmttcy0+ZW5jb2RlcnNbaV0s IG1kZXYtPnBpcGVsaW5lc1tpXS0+b2Zfbm9kZSk7Cj4gKwkJaWYgKGVycikKPiArCQkJcmV0dXJu IGVycjsKPiArCX0KPiArCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiArc3RhdGljIGludCBrb21l ZGFfa21zX2F0dGFjaF9leHRlcm5hbChzdHJ1Y3Qga29tZWRhX2ttc19kZXYgKmttcywKPiArCQkJ CSAgICAgIHN0cnVjdCBrb21lZGFfZGV2ICptZGV2KQo+ICt7Cj4gKwlpbnQgZXJyOwo+ICsKPiAr CWlmIChtZGV2LT5oYXNfY29tcG9uZW50cykgewo+ICsJCWVyciA9IGNvbXBvbmVudF9iaW5kX2Fs bChtZGV2LT5kZXYsIGttcyk7Cj4gKwkJaWYgKGVycikKPiArCQkJcmV0dXJuIGVycjsKPiArCX0K PiArCj4gKwllcnIgPSBrb21lZGFfZW5jb2Rlcl9hdHRhY2hfYnJpZGdlcyhrbXMsIG1kZXYpOwo+ ICsJaWYgKGVycikKPiArCQlyZXR1cm4gZXJyOwo+ICsKPiArCXJldHVybiAwOwo+ICt9Cj4gKwo+ ICtzdGF0aWMgdm9pZCBrb21lZGFfa21zX2RldGFjaF9leHRlcm5hbChzdHJ1Y3Qga29tZWRhX2Rl diAqbWRldiwKPiArCQkJCSAgICAgICBzdHJ1Y3QgZHJtX2RldmljZSAqZHJtKQo+ICt7Cj4gKwlp ZiAobWRldi0+aGFzX2NvbXBvbmVudHMpCj4gKwkJY29tcG9uZW50X3VuYmluZF9hbGwobWRldi0+ ZGV2LCBkcm0pOwo+ICt9Cj4gKwo+ICBpbnQga29tZWRhX2ttc19pbml0KHN0cnVjdCBrb21lZGFf a21zX2RldiAqa21zLCBzdHJ1Y3Qga29tZWRhX2RldiAqbWRldikKPiAgewo+ICAJc3RydWN0IGRy bV9kZXZpY2UgKmRybTsKPiBAQCAtMzAxLDcgKzQyOCw3IEBAIGludCBrb21lZGFfa21zX2luaXQo c3RydWN0IGtvbWVkYV9rbXNfZGV2ICprbXMsIHN0cnVjdCBrb21lZGFfZGV2ICptZGV2KQo+ICAJ aWYgKGVycikKPiAgCQlnb3RvIGNsZWFudXBfbW9kZV9jb25maWc7Cj4gIAo+IC0JZXJyID0gY29t cG9uZW50X2JpbmRfYWxsKG1kZXYtPmRldiwga21zKTsKPiArCWVyciA9IGtvbWVkYV9rbXNfYXR0 YWNoX2V4dGVybmFsKGttcywgbWRldik7Cj4gIAlpZiAoZXJyKQo+ICAJCWdvdG8gY2xlYW51cF9t b2RlX2NvbmZpZzsKPiAgCj4gQEAgLTMzMiw3ICs0NTksNyBAQCBpbnQga29tZWRhX2ttc19pbml0 KHN0cnVjdCBrb21lZGFfa21zX2RldiAqa21zLCBzdHJ1Y3Qga29tZWRhX2RldiAqbWRldikKPiAg CWRybS0+aXJxX2VuYWJsZWQgPSBmYWxzZTsKPiAgCW1kZXYtPmZ1bmNzLT5kaXNhYmxlX2lycSht ZGV2KTsKPiAgZnJlZV9jb21wb25lbnRfYmluZGluZzoKPiAtCWNvbXBvbmVudF91bmJpbmRfYWxs KG1kZXYtPmRldiwgZHJtKTsKPiArCWtvbWVkYV9rbXNfZGV0YWNoX2V4dGVybmFsKG1kZXYsIGRy bSk7Cj4gIGNsZWFudXBfbW9kZV9jb25maWc6Cj4gIAlkcm1fbW9kZV9jb25maWdfY2xlYW51cChk cm0pOwo+ICAJa29tZWRhX2ttc19jbGVhbnVwX3ByaXZhdGVfb2JqcyhrbXMpOwo+IEBAIC0zNTEs NyArNDc4LDcgQEAgdm9pZCBrb21lZGFfa21zX2Zpbmkoc3RydWN0IGtvbWVkYV9rbXNfZGV2ICpr bXMpCj4gIAlkcm1fYXRvbWljX2hlbHBlcl9zaHV0ZG93bihkcm0pOwo+ICAJZHJtLT5pcnFfZW5h YmxlZCA9IGZhbHNlOwo+ICAJbWRldi0+ZnVuY3MtPmRpc2FibGVfaXJxKG1kZXYpOwo+IC0JY29t cG9uZW50X3VuYmluZF9hbGwobWRldi0+ZGV2LCBkcm0pOwo+ICsJa29tZWRhX2ttc19kZXRhY2hf ZXh0ZXJuYWwobWRldiwgZHJtKTsKPiAgCWRybV9tb2RlX2NvbmZpZ19jbGVhbnVwKGRybSk7Cj4g IAlrb21lZGFfa21zX2NsZWFudXBfcHJpdmF0ZV9vYmpzKGttcyk7Cj4gIAlkcm0tPmRldl9wcml2 YXRlID0gTlVMTDsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FybS9kaXNwbGF5L2tv bWVkYS9rb21lZGFfa21zLmggYi9kcml2ZXJzL2dwdS9kcm0vYXJtL2Rpc3BsYXkva29tZWRhL2tv bWVkYV9rbXMuaAo+IGluZGV4IGU4MWNlYjI5ODAzNC4uYzI4NTZlMTlkMDkyIDEwMDY0NAo+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9hcm0vZGlzcGxheS9rb21lZGEva29tZWRhX2ttcy5oCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2FybS9kaXNwbGF5L2tvbWVkYS9rb21lZGFfa21zLmgKPiBAQCAt MTIsNiArMTIsNyBAQAo+ICAjaW5jbHVkZSA8ZHJtL2RybV9hdG9taWNfaGVscGVyLmg+Cj4gICNp bmNsdWRlIDxkcm0vZHJtX2NydGNfaGVscGVyLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJtX2Rldmlj ZS5oPgo+ICsjaW5jbHVkZSA8ZHJtL2RybV9lbmNvZGVyLmg+Cj4gICNpbmNsdWRlIDxkcm0vZHJt X3dyaXRlYmFjay5oPgo+ICAjaW5jbHVkZSA8ZHJtL2RybV9wcmludC5oPgo+ICAKPiBAQCAtMTIz LDYgKzEyNCw3IEBAIHN0cnVjdCBrb21lZGFfa21zX2RldiB7Cj4gIAlpbnQgbl9jcnRjczsKPiAg CS8qKiBAY3J0Y3M6IGNydGNzIGxpc3QgKi8KPiAgCXN0cnVjdCBrb21lZGFfY3J0YyBjcnRjc1tL T01FREFfTUFYX1BJUEVMSU5FU107Cj4gKwlzdHJ1Y3QgZHJtX2VuY29kZXIgZW5jb2RlcnNbS09N RURBX01BWF9QSVBFTElORVNdOwo+ICB9Owo+ICAKPiAgI2RlZmluZSB0b19rcGxhbmUocCkJY29u dGFpbmVyX29mKHAsIHN0cnVjdCBrb21lZGFfcGxhbmUsIGJhc2UpCj4gQEAgLTE4NCw0ICsxODYs NyBAQCB2b2lkIGtvbWVkYV9jcnRjX2hhbmRsZV9ldmVudChzdHJ1Y3Qga29tZWRhX2NydGMgICAq a2NydGMsCj4gIGludCBrb21lZGFfa21zX2luaXQoc3RydWN0IGtvbWVkYV9rbXNfZGV2ICprbXMs IHN0cnVjdCBrb21lZGFfZGV2ICptZGV2KTsKPiAgdm9pZCBrb21lZGFfa21zX2Zpbmkoc3RydWN0 IGtvbWVkYV9rbXNfZGV2ICprbXMpOwo+ICAKPiArYm9vbCBrb21lZGFfcmVtb3RlX2RldmljZV9p c19jb21wb25lbnQoc3RydWN0IGRldmljZV9ub2RlICpsb2NhbCwKPiArCQkJCSAgICAgICB1MzIg cG9ydCwgdTMyIGVuZHBvaW50KTsKPiArCj4gICNlbmRpZiAvKl9LT01FREFfS01TX0hfKi8KX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1h aWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44E54C47404 for ; Wed, 9 Oct 2019 05:54:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 002F120B7C for ; Wed, 9 Oct 2019 05:54:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="JmIbiyiN"; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.b="JmIbiyiN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728132AbfJIFyh (ORCPT ); Wed, 9 Oct 2019 01:54:37 -0400 Received: from mail-eopbgr60055.outbound.protection.outlook.com ([40.107.6.55]:47535 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725838AbfJIFyg (ORCPT ); Wed, 9 Oct 2019 01:54:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xs57qjC/o2vUL4xzoPCGby3uSI6yE0u1KgaASApH3zA=; b=JmIbiyiN283QcXiMce8l/Mf2mlgiLR34N3PTgPBMTvMNUMRsz/rgjZ8hD4M//7uLlsn5vfBQDlUA5+DkVKomzNJPZ/FoW/4Uq0HfeNhIaBECrKVQdhoYEVdhwMFRRqT7wWNdxLWjGSrPQ6RKnFIWpqwah5Y1dbqtMBR28TyqSn0= Received: from AM6PR08CA0026.eurprd08.prod.outlook.com (2603:10a6:20b:c0::14) by VI1PR08MB3856.eurprd08.prod.outlook.com (2603:10a6:803:c2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.16; Wed, 9 Oct 2019 05:54:29 +0000 Received: from VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::204) by AM6PR08CA0026.outlook.office365.com (2603:10a6:20b:c0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2347.16 via Frontend Transport; Wed, 9 Oct 2019 05:54:29 +0000 Authentication-Results: spf=temperror (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; vger.kernel.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;vger.kernel.org; dmarc=none action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT040.mail.protection.outlook.com (10.152.18.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2305.15 via Frontend Transport; Wed, 9 Oct 2019 05:54:27 +0000 Received: ("Tessian outbound 081de437afc7:v33"); Wed, 09 Oct 2019 05:54:23 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 2f801ab74e46cdbb X-CR-MTA-TID: 64aa7808 Received: from 2524e65c3e20.2 (ip-172-16-0-2.eu-west-1.compute.internal [104.47.6.58]) by 64aa7808-outbound-1.mta.getcheckrecipient.com id 310EAD6E-9982-4FA6-973A-D9322ECE0F24.1; Wed, 09 Oct 2019 05:54:18 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2058.outbound.protection.outlook.com [104.47.6.58]) by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2524e65c3e20.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384); Wed, 09 Oct 2019 05:54:18 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lxvttFIJcrCPYuALLunSVoyjMMJAjr3AyUYI0MdQUiGh16Gh3gjb+F77RBThTu6Pz45sQi5COSJmdbeoUUixFfTtNZ7NX0Zd8ApdRkxncwAwstjTfpoJOTLfeCbPhQ6tVEXr8kNneSxhCVycuA6sgGgHqANuhYNhIhcQ1ZOtelBLTmIZeRP54PWAt/KNQgjfvjmYAiRhZMCR9KuwqLf/NBXvZnyHCsYqWBV3G77YmgxnQhyQXfdkB7mMr5suluZVI2XGo4fo4rcf3M6yZ3MLScYiMaosm4BIq39fzZfW4tnEnZQIS2hh/9JvdfPWmeZFkuSjw78h4TomLulN93l7YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xs57qjC/o2vUL4xzoPCGby3uSI6yE0u1KgaASApH3zA=; b=d5kGLauWTp30vFmjuDbWSHwoOm99J8jVTZNkxKh43DKXRqq/cbOmM5o9iCBcchFfc321U2uNf+4S6I2uWqpkprgFbyWTy0oXgMwuKgA4Uyoj+gW7cqmMM5dcNsEKRJ9df57bn9+uffXmbQU7DKlBsG5rx7vuHdNHAP0G/aqj66IDIKJ/jeL4yrp4jadlvw1pA5aRA/K5Sx6KmLVfCgoKnQtUbXE593KiDw8dAgiZCv+1DW3OzCjZWQ8BddYylRq1m2dQrU0ADY33cFNrbm0o0MatKWqP+MAqNMlFT1i5tbjRKyozbf8daQ0lPt8iZrJ/SIzkJRSVIxz7mPtOrBMOxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xs57qjC/o2vUL4xzoPCGby3uSI6yE0u1KgaASApH3zA=; b=JmIbiyiN283QcXiMce8l/Mf2mlgiLR34N3PTgPBMTvMNUMRsz/rgjZ8hD4M//7uLlsn5vfBQDlUA5+DkVKomzNJPZ/FoW/4Uq0HfeNhIaBECrKVQdhoYEVdhwMFRRqT7wWNdxLWjGSrPQ6RKnFIWpqwah5Y1dbqtMBR28TyqSn0= Received: from VE1PR08MB5006.eurprd08.prod.outlook.com (10.255.159.31) by VE1PR08MB5245.eurprd08.prod.outlook.com (20.179.31.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2327.24; Wed, 9 Oct 2019 05:54:15 +0000 Received: from VE1PR08MB5006.eurprd08.prod.outlook.com ([fe80::40ed:7ed3:90cf:ece5]) by VE1PR08MB5006.eurprd08.prod.outlook.com ([fe80::40ed:7ed3:90cf:ece5%3]) with mapi id 15.20.2305.023; Wed, 9 Oct 2019 05:54:15 +0000 From: "james qian wang (Arm Technology China)" To: Mihail Atanassov CC: "dri-devel@lists.freedesktop.org" , David Airlie , Liviu Dudau , Russell King , Maxime Ripard , "linux-kernel@vger.kernel.org" , nd , Sean Paul Subject: Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints Thread-Topic: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints Thread-Index: AQHVfmX7+sBzYHhR8EiYyRUjNjETpw== Date: Wed, 9 Oct 2019 05:54:15 +0000 Message-ID: <20191009055407.GA3082@jamwan02-TSP300> References: <20191004143418.53039-4-mihail.atanassov@arm.com> In-Reply-To: <20191004143418.53039-4-mihail.atanassov@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mutt/1.10.1 (2018-07-13) x-originating-ip: [113.29.88.7] x-clientproxiedby: HK2PR0401CA0002.apcprd04.prod.outlook.com (2603:1096:202:2::12) To VE1PR08MB5006.eurprd08.prod.outlook.com (2603:10a6:803:113::31) Authentication-Results-Original: spf=none (sender IP is ) smtp.mailfrom=james.qian.wang@arm.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email X-MS-Office365-Filtering-Correlation-Id: 62ddde36-cd9a-4c55-dfb0-08d74c7d251f X-MS-Office365-Filtering-HT: Tenant X-MS-TrafficTypeDiagnostic: VE1PR08MB5245:|VE1PR08MB5245:|VI1PR08MB3856: x-ms-exchange-transport-forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true x-ms-oob-tlc-oobclassifiers: OLM:1060;OLM:1060; x-forefront-prvs: 018577E36E X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(346002)(366004)(376002)(396003)(39860400002)(136003)(199004)(189003)(33716001)(54906003)(81156014)(81166006)(99286004)(8676002)(25786009)(8936002)(71190400001)(71200400001)(86362001)(5024004)(256004)(14454004)(14444005)(33656002)(316002)(58126008)(478600001)(4326008)(6862004)(5660300002)(6246003)(1076003)(30864003)(486006)(476003)(6512007)(66556008)(66476007)(64756008)(66946007)(6486002)(6636002)(2906002)(7736002)(66066001)(305945005)(66446008)(6436002)(229853002)(9686003)(6116002)(3846002)(26005)(186003)(76176011)(52116002)(102836004)(386003)(6506007)(55236004)(11346002)(446003);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB5245;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gOekTMqfOQ/DS4WgsHQxywjCboVD+82WS8P0JHVNtZSutl4xLNIet6fwisKLoXlF4fDUHKyf9SuSeCDiF5wnqS3crO7sr2lmSxsUR8AFZq9uMiLkQHXzKYpEJwcFF+b7ZMKdqOYWsrGiLdmvZSL+dsb2pkWSnXFpYzxNlP132tQXY/lXx/14TfW68i3Tv/GYjKgU3F4UfLUlLvDKLR3C0Cd42vcVIM0TNwoxE2OTxjMJzJQjVgIvWvH1IdUJHW6k6LsayROcvvG+eI1yNojQ1W95feAJexqYq5TrEG3MSAVawM8mEKK9jfir7qKVu/83/Qo7Lxt0BveLUdPQ6FII67CBWfl2qwH7tlPqm1LbzYghYWL5CiJswTPCYSx9VeELT+MQQuQLDgZNZVVR4630jyQOKWxY+Xj1ZyTxh3TCPsQ= Content-Type: text/plain; charset="us-ascii" Content-ID: <6636E9631376EA46B83E0EA87169D253@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5245 Original-Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=james.qian.wang@arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT040.eop-EUR03.prod.protection.outlook.com X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(7916004)(396003)(39860400002)(346002)(376002)(136003)(189003)(199004)(47776003)(316002)(5660300002)(14454004)(58126008)(186003)(1076003)(26826003)(36906005)(2906002)(66066001)(22756006)(97756001)(50466002)(6636002)(70206006)(478600001)(386003)(102836004)(76176011)(3846002)(6506007)(23726003)(6116002)(99286004)(54906003)(33656002)(70586007)(30864003)(26005)(14444005)(5024004)(6862004)(8676002)(8746002)(8936002)(63350400001)(81166006)(81156014)(356004)(11346002)(126002)(476003)(86362001)(6246003)(446003)(7736002)(107886003)(336012)(229853002)(4326008)(25786009)(46406003)(486006)(6486002)(9686003)(6512007)(305945005)(33716001)(76130400001);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB3856;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:TempError;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1; X-MS-Office365-Filtering-Correlation-Id-Prvs: e7318fbb-8286-4b33-65a4-08d74c7d1e0e NoDisclaimer: True X-Forefront-PRVS: 018577E36E X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CgYm2+CLEKyqju3UJs71LQOiq5Klq5yDqUcS+5CIMt/+PTHqI0UoHyACgPh8MOICPDmSMTNc1Ki2F5ePZU77W99DSi64tI1KFdCYyhYp2Ch7RVqbC7SAF7ttk9dTpQz+UmJvjTczKRNuqzlgpRE5RQ0ZGdtn4TxbouLaTo4yHz3YO0UsqBT/aNhfpKVwuyCdvQWJwO8lZuxA1YtEIhWdyhPc37STOFvXUZgarrnXKbO8uzWAaQFdfjRD0e5ZjUO6+5Ml36YXmvdwMwem44m+di/nHmEVrwuOwjjTVXenI9Wg4yfvwjZIp786VgAi1BjI6lS3qs6/nMN4pzAhVt6sWjXhnhoBGLq9zrItZqAeYVNVpED6WQRC5FyHoQOlUgQsudlo+1etLgvPF0A4hneVrR6ONr/2a/CmIdRB+/s5VgI= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Oct 2019 05:54:27.2312 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 62ddde36-cd9a-4c55-dfb0-08d74c7d251f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3856 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 04, 2019 at 02:34:42PM +0000, Mihail Atanassov wrote: > To support transmitters other than the tda998x, we need to allow > non-component framework bridges to be attached to a dummy drm_encoder in > our driver. >=20 > For the existing supported encoder (tda998x), keep the behaviour as-is, > since there's no way to unbind if a drm_bridge module goes away under > our feet. >=20 > Signed-off-by: Mihail Atanassov > --- > .../gpu/drm/arm/display/komeda/komeda_dev.h | 5 + > .../gpu/drm/arm/display/komeda/komeda_drv.c | 58 ++++++-- > .../gpu/drm/arm/display/komeda/komeda_kms.c | 133 +++++++++++++++++- > .../gpu/drm/arm/display/komeda/komeda_kms.h | 5 + > 4 files changed, 187 insertions(+), 14 deletions(-) >=20 > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gp= u/drm/arm/display/komeda/komeda_dev.h > index e392b8ffc372..64d2902e2e0c 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h > @@ -176,6 +176,11 @@ struct komeda_dev { > =20 > /** @irq: irq number */ > int irq; > + /** @has_components: > + * > + * if true, use the component framework to bind/unbind driver > + */ > + bool has_components; > =20 > /** @lock: used to protect dpmode */ > struct mutex lock; > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gp= u/drm/arm/display/komeda/komeda_drv.c > index 9ed25ffe0e22..34cfc6a4c3e4 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c > @@ -10,6 +10,8 @@ > #include > #include > #include > +#include > +#include > #include "komeda_dev.h" > #include "komeda_kms.h" > =20 > @@ -69,18 +71,35 @@ static int compare_of(struct device *dev, void *data) > return dev->of_node =3D=3D data; > } > =20 > -static void komeda_add_slave(struct device *master, > - struct component_match **match, > - struct device_node *np, > - u32 port, u32 endpoint) > +static int komeda_add_slave(struct device *master, > + struct komeda_drv *mdrv, > + struct component_match **match, > + struct device_node *np, > + u32 port, u32 endpoint) > { > struct device_node *remote; > + struct drm_bridge *bridge; > + int ret =3D 0; > =20 > remote =3D of_graph_get_remote_node(np, port, endpoint); > - if (remote) { > + if (!remote) > + return 0; > + > + if (komeda_remote_device_is_component(np, port, endpoint)) { > + mdrv->mdev.has_components =3D true; > drm_of_component_match_add(master, match, compare_of, remote); > - of_node_put(remote); > + goto exit; > + } > + > + bridge =3D of_drm_find_bridge(remote); > + if (!bridge) { > + ret =3D -EPROBE_DEFER; > + goto exit; > } > + > +exit: > + of_node_put(remote); > + return ret; > } > =20 > static int komeda_platform_probe(struct platform_device *pdev) > @@ -89,6 +108,7 @@ static int komeda_platform_probe(struct platform_devic= e *pdev) > struct component_match *match =3D NULL; > struct device_node *child; > struct komeda_drv *mdrv; > + int ret; > =20 > if (!dev->of_node) > return -ENODEV; > @@ -101,14 +121,27 @@ static int komeda_platform_probe(struct platform_de= vice *pdev) > if (of_node_cmp(child->name, "pipeline") !=3D 0) > continue; > =20 > - /* add connector */ > - komeda_add_slave(dev, &match, child, KOMEDA_OF_PORT_OUTPUT, 0); > - komeda_add_slave(dev, &match, child, KOMEDA_OF_PORT_OUTPUT, 1); > + /* attach any remote devices if present */ > + ret =3D komeda_add_slave(dev, mdrv, &match, child, > + KOMEDA_OF_PORT_OUTPUT, 0); > + if (ret) > + goto free_mdrv; > + ret =3D komeda_add_slave(dev, mdrv, &match, child, > + KOMEDA_OF_PORT_OUTPUT, 1); > + if (ret) > + goto free_mdrv; > } > =20 > dev_set_drvdata(dev, mdrv); > =20 > - return component_master_add_with_match(dev, &komeda_master_ops, match); > + return mdrv->mdev.has_components > + ? component_master_add_with_match( > + dev, &komeda_master_ops, match) > + : komeda_bind(dev); > + > +free_mdrv: > + devm_kfree(dev, mdrv); > + return ret; > } > =20 > static int komeda_platform_remove(struct platform_device *pdev) > @@ -116,7 +149,10 @@ static int komeda_platform_remove(struct platform_de= vice *pdev) > struct device *dev =3D &pdev->dev; > struct komeda_drv *mdrv =3D dev_get_drvdata(dev); > =20 > - component_master_del(dev, &komeda_master_ops); > + if (mdrv->mdev.has_components) > + component_master_del(dev, &komeda_master_ops); > + else > + komeda_unbind(dev); > =20 > dev_set_drvdata(dev, NULL); > devm_kfree(dev, mdrv); > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gp= u/drm/arm/display/komeda/komeda_kms.c > index 03dcf1d7688f..6eb52d1b20a0 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c > @@ -6,6 +6,7 @@ > */ > #include > #include > +#include > =20 > #include > #include > @@ -14,6 +15,8 @@ > #include > #include > #include > +#include > +#include > #include > #include > =20 > @@ -267,6 +270,130 @@ static void komeda_kms_mode_config_init(struct kome= da_kms_dev *kms, > config->helper_private =3D &komeda_mode_config_helpers; > } > =20 > +static void komeda_encoder_destroy(struct drm_encoder *encoder) > +{ > + drm_encoder_cleanup(encoder); > +} > + > +static const struct drm_encoder_funcs komeda_dummy_enc_funcs =3D { > + .destroy =3D komeda_encoder_destroy, > +}; > + > +bool komeda_remote_device_is_component(struct device_node *local, > + u32 port, u32 endpoint) > +{ > + struct device_node *remote; > + char const * const component_devices[] =3D { > + "nxp,tda998x", I really don't think put this dummy_encoder into komeda is a good idea. And I suggest to seperate this dummy_encoder to a individual module which will build the drm_ridge to a standard drm encoder and component based module, which will be enable by DT, totally transparent for komeda. BTW: I really don't like such logic: distingush the SYSTEM configuration by check the connected device name, it's hard to maintain and code sharing, and that's why NOW we have the device-tree. Thanks James > + }; > + int i; > + bool ret =3D false; > + > + remote =3D of_graph_get_remote_node(local, port, endpoint); > + if (!remote) > + return false; > + > + /* Coprocessor endpoints are always component based. */ > + if (port !=3D KOMEDA_OF_PORT_OUTPUT) { > + ret =3D true; > + goto exit; > + } > + > + for (i =3D 0; i < ARRAY_SIZE(component_devices); ++i) { > + if (of_device_is_compatible(remote, component_devices[i])) { > + ret =3D true; > + goto exit; > + } > + } > + > +exit: > + of_node_put(remote); > + return ret; > +} > + > +static int komeda_encoder_attach_bridge(struct komeda_dev *mdev, > + struct komeda_kms_dev *kms, > + struct drm_encoder *encoder, > + struct device_node *np) > +{ > + struct device_node *remote; > + struct drm_bridge *bridge; > + u32 crtcs =3D 0; > + int ret =3D 0; > + > + if (komeda_remote_device_is_component(np, KOMEDA_OF_PORT_OUTPUT, 0)) > + return 0; > + > + remote =3D of_graph_get_remote_node(np, KOMEDA_OF_PORT_OUTPUT, 0); > + if (!remote) > + return 0; > + > + bridge =3D of_drm_find_bridge(remote); > + if (!bridge) { > + ret =3D -EINVAL; > + goto exit; > + } > + > + crtcs =3D drm_of_find_possible_crtcs(&kms->base, remote); > + > + encoder->possible_crtcs =3D crtcs ? crtcs : 1; > + > + ret =3D drm_encoder_init(&kms->base, encoder, > + &komeda_dummy_enc_funcs, DRM_MODE_ENCODER_TMDS, > + NULL); > + if (ret) > + goto exit; > + > + ret =3D drm_bridge_attach(encoder, bridge, NULL); > + if (ret) > + goto exit; > + > +exit: > + of_node_put(remote); > + return ret; > +} > + > +static int komeda_encoder_attach_bridges(struct komeda_kms_dev *kms, > + struct komeda_dev *mdev) > +{ > + int i, err; > + > + for (i =3D 0; i < kms->n_crtcs; i++) { > + err =3D komeda_encoder_attach_bridge( > + mdev, kms, > + &kms->encoders[i], mdev->pipelines[i]->of_node); > + if (err) > + return err; > + } > + > + return 0; > +} > + > +static int komeda_kms_attach_external(struct komeda_kms_dev *kms, > + struct komeda_dev *mdev) > +{ > + int err; > + > + if (mdev->has_components) { > + err =3D component_bind_all(mdev->dev, kms); > + if (err) > + return err; > + } > + > + err =3D komeda_encoder_attach_bridges(kms, mdev); > + if (err) > + return err; > + > + return 0; > +} > + > +static void komeda_kms_detach_external(struct komeda_dev *mdev, > + struct drm_device *drm) > +{ > + if (mdev->has_components) > + component_unbind_all(mdev->dev, drm); > +} > + > int komeda_kms_init(struct komeda_kms_dev *kms, struct komeda_dev *mdev) > { > struct drm_device *drm; > @@ -301,7 +428,7 @@ int komeda_kms_init(struct komeda_kms_dev *kms, struc= t komeda_dev *mdev) > if (err) > goto cleanup_mode_config; > =20 > - err =3D component_bind_all(mdev->dev, kms); > + err =3D komeda_kms_attach_external(kms, mdev); > if (err) > goto cleanup_mode_config; > =20 > @@ -332,7 +459,7 @@ int komeda_kms_init(struct komeda_kms_dev *kms, struc= t komeda_dev *mdev) > drm->irq_enabled =3D false; > mdev->funcs->disable_irq(mdev); > free_component_binding: > - component_unbind_all(mdev->dev, drm); > + komeda_kms_detach_external(mdev, drm); > cleanup_mode_config: > drm_mode_config_cleanup(drm); > komeda_kms_cleanup_private_objs(kms); > @@ -351,7 +478,7 @@ void komeda_kms_fini(struct komeda_kms_dev *kms) > drm_atomic_helper_shutdown(drm); > drm->irq_enabled =3D false; > mdev->funcs->disable_irq(mdev); > - component_unbind_all(mdev->dev, drm); > + komeda_kms_detach_external(mdev, drm); > drm_mode_config_cleanup(drm); > komeda_kms_cleanup_private_objs(kms); > drm->dev_private =3D NULL; > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.h b/drivers/gp= u/drm/arm/display/komeda/komeda_kms.h > index e81ceb298034..c2856e19d092 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.h > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.h > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > =20 > @@ -123,6 +124,7 @@ struct komeda_kms_dev { > int n_crtcs; > /** @crtcs: crtcs list */ > struct komeda_crtc crtcs[KOMEDA_MAX_PIPELINES]; > + struct drm_encoder encoders[KOMEDA_MAX_PIPELINES]; > }; > =20 > #define to_kplane(p) container_of(p, struct komeda_plane, base) > @@ -184,4 +186,7 @@ void komeda_crtc_handle_event(struct komeda_crtc *k= crtc, > int komeda_kms_init(struct komeda_kms_dev *kms, struct komeda_dev *mdev)= ; > void komeda_kms_fini(struct komeda_kms_dev *kms); > =20 > +bool komeda_remote_device_is_component(struct device_node *local, > + u32 port, u32 endpoint); > + > #endif /*_KOMEDA_KMS_H_*/