From: Stephen Hemminger <stephen@networkplumber.org>
To: Flavia Musatescu <flavia.musatescu@intel.com>
Cc: dev@dpdk.org, "John W. Linville" <linville@tuxdriver.com>,
stable@dpdk.org, ciwillia@brocade.com
Subject: Re: [dpdk-dev] [PATCH] net/af_packet: improve Tx statistics accuracy
Date: Wed, 9 Oct 2019 10:26:09 -0700 [thread overview]
Message-ID: <20191009102609.2961290a@hermes.lan> (raw)
In-Reply-To: <1570634949-26819-1-git-send-email-flavia.musatescu@intel.com>
On Wed, 9 Oct 2019 16:29:09 +0100
Flavia Musatescu <flavia.musatescu@intel.com> wrote:
> + if (sendto(pkt_q->sockfd, NULL, 0, MSG_DONTWAIT, NULL, 0) == -1 &&
> + errno != ENOBUFS) {
> + /* Error sending.
> + * When sendto call fails and ENOBUFS error is being set
> + * some of the packets are actually successfully transmitted.
> + * There is no available count of those packets, so in order
> + * to make the statistics more accurate, all of the previously
> + * enqueued packets will be considered successful, even though
> + * this is not entirely correct.
> + */
Agree with the change, but please keep only add a small code comment.
Long comments are a personal pet peeve, it also tends to standout as
"some different developer who had an issue left this comment"
next prev parent reply other threads:[~2019-10-09 17:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 15:29 [dpdk-dev] [PATCH] net/af_packet: improve Tx statistics accuracy Flavia Musatescu
2019-10-09 17:26 ` Stephen Hemminger [this message]
2019-10-10 17:34 ` [dpdk-dev] [PATCH v2] " Flavia Musatescu
2019-10-10 18:35 ` Stephen Hemminger
2019-10-11 17:13 ` Musatescu, Flavia
2019-10-17 11:51 ` [dpdk-dev] [PATCH v3] " Flavia Musatescu
2019-10-18 14:24 ` [dpdk-dev] [PATCH v4] " Flavia Musatescu
2019-10-18 15:15 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-10-21 18:15 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009102609.2961290a@hermes.lan \
--to=stephen@networkplumber.org \
--cc=ciwillia@brocade.com \
--cc=dev@dpdk.org \
--cc=flavia.musatescu@intel.com \
--cc=linville@tuxdriver.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.