From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM Date: Wed, 9 Oct 2019 12:45:31 +0200 Message-ID: <20191009104531.GW16989@phenom.ffwll.local> References: <20190725105132.22545-2-noralf@tronnes.org> <20191001123636.GA8351@ziepe.ca> <1fffe7b1-a738-a9e3-ea5f-9d696cb98650@tronnes.org> <20191001134555.GB22532@ziepe.ca> <75055e2d-44f7-0cba-4e41-537097b73c3c@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-x542.google.com (mail-ed1-x542.google.com [IPv6:2a00:1450:4864:20::542]) by gabe.freedesktop.org (Postfix) with ESMTPS id E502A6E974 for ; Wed, 9 Oct 2019 10:45:35 +0000 (UTC) Received: by mail-ed1-x542.google.com with SMTP id h2so1585866edn.3 for ; Wed, 09 Oct 2019 03:45:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <75055e2d-44f7-0cba-4e41-537097b73c3c@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: sam@ravnborg.org, hdegoede@redhat.com, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jason Gunthorpe , Maxime Ripard , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMDEsIDIwMTkgYXQgMDQ6MDc6MzhQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IEhpIGRybS1taXNjIG1haW50YWluZXJzLAo+IAo+IEkgaGF2ZSBqdXN0IGFwcGxp ZWQgYSBwYXRjaCB0byBkcm0tbWlzYy1uZXh0IHRoYXQgYXMgaXQgdHVybnMgb3V0IHNob3VsZAo+ IGhhdmUgYmVlbiBhcHBsaWVkIHRvIC1maXhlcyBmb3IgdGhpcyAtcmMgY3ljbGUuCj4gCj4gU2hv dWxkIEkgY2hlcnJ5IHBpY2sgaXQgdG8gZHJtLW1pc2MtbmV4dC1maXhlcz8KCll1cCwgY2hlcnJ5 IHBpY2sgYW5kIHJlZmVyZW5jZSB0aGUgY29tbWl0IHRoYXQncyBhbHJlYWR5IGluIC1uZXh0IChp biBjYXNlCml0IGNyZWF0ZXMgY29uZmxpY3RzIGRvd24gdGhlIHJvYWQgdGhhdCByZWZlcmVuY2Ug bWFrZXMgdGhlIG1lc3MgZWFzaWVyIHRvCnVuZGVyc3RhbmQpLgoKPiAoSSBrbm93IHRoZXJlJ3Mg YSBmbG93Y2hhcnQgaW4gdGhlIGRvY3MgYnV0IEkndmUgbmV2ZXIgcmVhbGx5IHVuZGVyc3Rvb2QK PiBpdC4pCgpVc3VhbGx5IGJ1Z2ZpeGVzIGZvciBrZXJuZWwgcmVsZWFzZXMgc2hvdWxkIGxhbmQg aW4gZHJtLW1pc2MtbmV4dC1maXhlcyBvcgpkcm0tbWlzYy1maXhlcy4gQnV0IGNoZXJyeS1waWNr aW5nIG92ZXIgaW4gY2FzZSBvZiBtaXN0YWtlcyBpcyBvayB0b28uCi1EYW5pZWwKCj4gCj4gTm9y YWxmLgo+IAo+IERlbiAwMS4xMC4yMDE5IDE1LjQ1LCBza3JldiBKYXNvbiBHdW50aG9ycGU6Cj4g PiBPbiBUdWUsIE9jdCAwMSwgMjAxOSBhdCAwMzoyODo0NlBNICswMjAwLCBOb3JhbGYgVHLDuG5u ZXMgd3JvdGU6Cj4gPj4KPiA+Pgo+ID4+IERlbiAwMS4xMC4yMDE5IDE0LjM2LCBza3JldiBKYXNv biBHdW50aG9ycGU6Cj4gPj4+IE9uIFRodSwgSnVsIDI1LCAyMDE5IGF0IDEyOjUxOjMwUE0gKzAy MDAsIE5vcmFsZiBUcsO4bm5lcyB3cm90ZToKPiA+Pj4+IFRoaXMgbWFrZXMgdGhlIHRpbnkgZHJp dmVycyB2aXNpYmxlIGJ5IGRlZmF1bHQgd2l0aG91dCBoYXZpbmcgdG8gZW5hYmxlIGEKPiA+Pj4+ IGtub2IuCj4gPj4+Pgo+ID4+Pj4gU2lnbmVkLW9mZi1ieTogTm9yYWxmIFRyw7hubmVzIDxub3Jh bGZAdHJvbm5lcy5vcmc+Cj4gPj4+PiBSZXZpZXdlZC1ieTogSGFucyBkZSBHb2VkZSA8aGRlZ29l ZGVAcmVkaGF0LmNvbT4gdG8gaXQgb25jZQo+ID4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9NYWtlZmls ZSAgICAgICAgfCAgMiArLQo+ID4+Pj4gIGRyaXZlcnMvZ3B1L2RybS90aW55ZHJtL0tjb25maWcg fCAzNyArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0KPiA+Pj4+ICAyIGZpbGVzIGNo YW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQo+ID4+Pgo+ID4+PiBCaXNl Y3Rpb24gc2F5cyB0aGlzIHBhdGNoICgyOGM0N2UxNmVhMmExOWFkYjQ3ZmUyYzE4MmNiZDYxY2I4 NTQyMzdjKQo+ID4+PiBicmVha3Mga2NvbmZpZyBzdHVmZiBpbiB2NS40LXJjIGJ5IGNyZWF0aW5n IGNpcmN1bGFyCj4gPj4+IGRlcGVuZGVuY2llcy4gQ291bGQgc29tZW9uZSBzZW5kIGEgLXJjIHBh dGNoIHRvIGZpeCB0aGlzIHBsZWFzZT8KPiA+Pj4KPiA+Pj4gVEhJTktQQURfQUNQSSAoZGVmaW5l ZCBhdCBkcml2ZXJzL3BsYXRmb3JtL3g4Ni9LY29uZmlnOjQ4NCksIHdpdGggZGVmaW5pdGlvbi4u Lgo+ID4+PiAuLi5kZXBlbmRzIG9uIEZCX1NTRDEzMDcgKGRlZmluZWQgYXQgZHJpdmVycy92aWRl by9mYmRldi9LY29uZmlnOjIyNTkpLCB3aXRoIGRlZmluaXRpb24uLi4KPiA+Pj4gLi4uZGVwZW5k cyBvbiBGQiAoZGVmaW5lZCBhdCBkcml2ZXJzL3ZpZGVvL2ZiZGV2L0tjb25maWc6MTIpLCB3aXRo IGRlZmluaXRpb24uLi4KPiA+Pj4gLi4uZGVwZW5kcyBvbiBEUk1fS01TX0ZCX0hFTFBFUiAoZGVm aW5lZCBhdCBkcml2ZXJzL2dwdS9kcm0vS2NvbmZpZzo3OSksIHdpdGggZGVmaW5pdGlvbi4uLgo+ ID4+PiAuLi5kZXBlbmRzIG9uIERSTV9LTVNfSEVMUEVSIChkZWZpbmVkIGF0IGRyaXZlcnMvZ3B1 L2RybS9LY29uZmlnOjczKSwgd2l0aCBkZWZpbml0aW9uLi4uCj4gPj4+IC4uLmRlcGVuZHMgb24g VElOWURSTV9SRVBBUEVSIChkZWZpbmVkIGF0IGRyaXZlcnMvZ3B1L2RybS90aW55ZHJtL0tjb25m aWc6NTEpLCB3aXRoIGRlZmluaXRpb24uLi4KPiA+Pj4gLi4uZGVwZW5kcyBvbiBUSEVSTUFMIChk ZWZpbmVkIGF0IGRyaXZlcnMvdGhlcm1hbC9LY29uZmlnOjYpLCB3aXRoIGRlZmluaXRpb24uLi4K PiA+Pj4gLi4uZGVwZW5kcyBvbiBTRU5TT1JTX05QQ003WFggKGRlZmluZWQgYXQgZHJpdmVycy9o d21vbi9LY29uZmlnOjEyODUpLCB3aXRoIGRlZmluaXRpb24uLi4KPiA+Pj4gLi4uZGVwZW5kcyBv biBIV01PTiAoZGVmaW5lZCBhdCBkcml2ZXJzL2h3bW9uL0tjb25maWc6NiksIHdpdGggZGVmaW5p dGlvbi4uLgo+ID4+PiAuLi5kZXBlbmRzIG9uIFRISU5LUEFEX0FDUEkgKGRlZmluZWQgYXQgZHJp dmVycy9wbGF0Zm9ybS94ODYvS2NvbmZpZzo0ODQpLCB3aXRoIGRlZmluaXRpb24uLi4KPiA+Pj4g Li4uZGVwZW5kcyBvbiBBQ1BJX1ZJREVPIChkZWZpbmVkIGF0IGRyaXZlcnMvYWNwaS9LY29uZmln OjE5MyksIHdpdGggZGVmaW5pdGlvbi4uLgo+ID4+PiAuLi5kZXBlbmRzIG9uIEFDRVJfV01JIChk ZWZpbmVkIGF0IGRyaXZlcnMvcGxhdGZvcm0veDg2L0tjb25maWc6MTkpLCB3aXRoIGRlZmluaXRp b24uLi4KPiA+Pj4gLi4uZGVwZW5kcyBvbiBCQUNLTElHSFRfQ0xBU1NfREVWSUNFIChkZWZpbmVk IGF0IGRyaXZlcnMvdmlkZW8vYmFja2xpZ2h0L0tjb25maWc6MTQ0KSwgd2l0aCBkZWZpbml0aW9u Li4uCj4gPj4+IC4uLmRlcGVuZHMgYWdhaW4gb24gVEhJTktQQURfQUNQSSAoZGVmaW5lZCBhdCBk cml2ZXJzL3BsYXRmb3JtL3g4Ni9LY29uZmlnOjQ4NCkKPiA+Pj4KPiA+Pgo+ID4+IFdvdWxkIHRo aXMgY29tbWl0IGZpeCB0aGlzIGJ5IGFueSBjaGFuY2U6Cj4gPj4KPiA+PiBkcm0vdGlueTogS2Nv bmZpZzogUmVtb3ZlIGFsd2F5cy15IFRIRVJNQUwgZGVwLiBmcm9tIFRJTllEUk1fUkVQQVBFUgo+ ID4+IGh0dHBzOi8vY2dpdC5mcmVlZGVza3RvcC5vcmcvZHJtL2RybS1taXNjL2NvbW1pdC8/aWQ9 ZGZlZjk1OTgwM2M3MjhjNjE2YWQyOWIwMDhjZDkxYjM0NDZhOTkzYQo+ID4gCj4gPiBZZXMsIHRo YW5rIHlvdSwgY2FuIHNvbWVvbmUgc2VuZCB0aGlzIHRvIC1yYyB0byB1bmJyZWFrIDUuND8KPiA+ IAo+ID4gSmFzb24KPiA+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D309C47404 for ; Wed, 9 Oct 2019 10:45:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C78DD2133F for ; Wed, 9 Oct 2019 10:45:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="gOh0Ame+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730339AbfJIKpi (ORCPT ); Wed, 9 Oct 2019 06:45:38 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:33580 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbfJIKpi (ORCPT ); Wed, 9 Oct 2019 06:45:38 -0400 Received: by mail-ed1-f67.google.com with SMTP id c4so1599807edl.0 for ; Wed, 09 Oct 2019 03:45:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=6+XvDcKE2RU3GarFMY6VFWF5e0vqSLtQ1WSp/MxdvAE=; b=gOh0Ame+9n5xA+JyzEumEbwhcF1sWB3ZNPV4KTv2mW1kph+Ebri0o4bV02T8jtXDRR J+f+5LbjnmqKFqIz1sDF96Cj0BrmfyhOLrosPja6sx/hqLaZOUI020WNSzpiBSBy2PbL 2SB/swB2haCopFqm+jdn5U/g9HgbyD0os75Bs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=6+XvDcKE2RU3GarFMY6VFWF5e0vqSLtQ1WSp/MxdvAE=; b=qwSJrQ5IGK21ADHeCGFOUcrJkJcjyWYxr8yus6ZQ+gZunEqeN1UpjYRycVX7/CCmNA FiC0o9w+jZfek1LzZcqnqLReZ+OB4YaLTSwCKDLw/XtLVGEe7tlgpqHwvIMGSaqfTUmo gPPWYmjmAmXCLYUWYJTf45Nz9kJJcGdUnkXYX3IxKxfRw2ggWl/TMSi9Q03yMz7kqzfd GUrnIUx9eq+iaUlyFzBrjGHgEdv9iJ/c0zv0lSaG8G5NWaQRPnhhGtoT3wwetYoE/zae imj07mn/cyJNMOth337ePm6Yx4axQZFiHvvvNiCRVfSytM4mMUc2WgSP0JUPgodsMLh6 X9nA== X-Gm-Message-State: APjAAAUpQ4jB4NCJ/N3TUteKfiKIbuJHuJltM5u/2F7FyRvwzIivCqJN SLb2fy7y9WRBqf1jDr2L9ICtWw== X-Google-Smtp-Source: APXvYqypf8TUWCjOC1hqek7KsLpkZOQhKyoafQfZ3yoK7AHqD4tOQfjVJl8fSNIoCuMXhrJPXSLG4g== X-Received: by 2002:a17:906:218a:: with SMTP id 10mr2138984eju.38.1570617934430; Wed, 09 Oct 2019 03:45:34 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id u30sm292574edd.18.2019.10.09.03.45.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2019 03:45:33 -0700 (PDT) Date: Wed, 9 Oct 2019 12:45:31 +0200 From: Daniel Vetter To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: Jason Gunthorpe , Maarten Lankhorst , Maxime Ripard , Sean Paul , dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch, sam@ravnborg.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [1/3] drm/tinydrm/Kconfig: Remove menuconfig DRM_TINYDRM Message-ID: <20191009104531.GW16989@phenom.ffwll.local> Mail-Followup-To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Jason Gunthorpe , Maarten Lankhorst , Maxime Ripard , Sean Paul , dri-devel@lists.freedesktop.org, sam@ravnborg.org, hdegoede@redhat.com, linux-kernel@vger.kernel.org References: <20190725105132.22545-2-noralf@tronnes.org> <20191001123636.GA8351@ziepe.ca> <1fffe7b1-a738-a9e3-ea5f-9d696cb98650@tronnes.org> <20191001134555.GB22532@ziepe.ca> <75055e2d-44f7-0cba-4e41-537097b73c3c@tronnes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <75055e2d-44f7-0cba-4e41-537097b73c3c@tronnes.org> X-Operating-System: Linux phenom 5.2.0-2-amd64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 01, 2019 at 04:07:38PM +0200, Noralf Trønnes wrote: > Hi drm-misc maintainers, > > I have just applied a patch to drm-misc-next that as it turns out should > have been applied to -fixes for this -rc cycle. > > Should I cherry pick it to drm-misc-next-fixes? Yup, cherry pick and reference the commit that's already in -next (in case it creates conflicts down the road that reference makes the mess easier to understand). > (I know there's a flowchart in the docs but I've never really understood > it.) Usually bugfixes for kernel releases should land in drm-misc-next-fixes or drm-misc-fixes. But cherry-picking over in case of mistakes is ok too. -Daniel > > Noralf. > > Den 01.10.2019 15.45, skrev Jason Gunthorpe: > > On Tue, Oct 01, 2019 at 03:28:46PM +0200, Noralf Trønnes wrote: > >> > >> > >> Den 01.10.2019 14.36, skrev Jason Gunthorpe: > >>> On Thu, Jul 25, 2019 at 12:51:30PM +0200, Noralf Trønnes wrote: > >>>> This makes the tiny drivers visible by default without having to enable a > >>>> knob. > >>>> > >>>> Signed-off-by: Noralf Trønnes > >>>> Reviewed-by: Hans de Goede to it once > >>>> drivers/gpu/drm/Makefile | 2 +- > >>>> drivers/gpu/drm/tinydrm/Kconfig | 37 +++++++++++++++++++-------------- > >>>> 2 files changed, 22 insertions(+), 17 deletions(-) > >>> > >>> Bisection says this patch (28c47e16ea2a19adb47fe2c182cbd61cb854237c) > >>> breaks kconfig stuff in v5.4-rc by creating circular > >>> dependencies. Could someone send a -rc patch to fix this please? > >>> > >>> THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition... > >>> ...depends on FB_SSD1307 (defined at drivers/video/fbdev/Kconfig:2259), with definition... > >>> ...depends on FB (defined at drivers/video/fbdev/Kconfig:12), with definition... > >>> ...depends on DRM_KMS_FB_HELPER (defined at drivers/gpu/drm/Kconfig:79), with definition... > >>> ...depends on DRM_KMS_HELPER (defined at drivers/gpu/drm/Kconfig:73), with definition... > >>> ...depends on TINYDRM_REPAPER (defined at drivers/gpu/drm/tinydrm/Kconfig:51), with definition... > >>> ...depends on THERMAL (defined at drivers/thermal/Kconfig:6), with definition... > >>> ...depends on SENSORS_NPCM7XX (defined at drivers/hwmon/Kconfig:1285), with definition... > >>> ...depends on HWMON (defined at drivers/hwmon/Kconfig:6), with definition... > >>> ...depends on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484), with definition... > >>> ...depends on ACPI_VIDEO (defined at drivers/acpi/Kconfig:193), with definition... > >>> ...depends on ACER_WMI (defined at drivers/platform/x86/Kconfig:19), with definition... > >>> ...depends on BACKLIGHT_CLASS_DEVICE (defined at drivers/video/backlight/Kconfig:144), with definition... > >>> ...depends again on THINKPAD_ACPI (defined at drivers/platform/x86/Kconfig:484) > >>> > >> > >> Would this commit fix this by any chance: > >> > >> drm/tiny: Kconfig: Remove always-y THERMAL dep. from TINYDRM_REPAPER > >> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=dfef959803c728c616ad29b008cd91b3446a993a > > > > Yes, thank you, can someone send this to -rc to unbreak 5.4? > > > > Jason > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch