From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9AFAC47404 for ; Wed, 9 Oct 2019 15:39:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C0467218DE for ; Wed, 9 Oct 2019 15:39:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570635568; bh=wEjkXEpo6a+ocQcIoxonVZQvVfCaphW+qJXwz5ZtMwc=; h=In-Reply-To:References:From:To:Cc:Subject:Date:List-ID:From; b=OjB9nu3XR/JvSBIBAZV6PYqkG6uiSUYq8TinPN9FnjqolL+U8a35XKPPwJ5f0aufa akvzSVMqJ/5o+elK/5o5zI2yiCuA//t6sfCf5YCki//LvBjEhDwssLg73E3PHrJ/SK ULxC4ovKCCMDUddbOkMJR+vH4RZErA9rWgls6cGI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730256AbfJIPj2 (ORCPT ); Wed, 9 Oct 2019 11:39:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:38038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729471AbfJIPj2 (ORCPT ); Wed, 9 Oct 2019 11:39:28 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3DC5D21848; Wed, 9 Oct 2019 15:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570635567; bh=wEjkXEpo6a+ocQcIoxonVZQvVfCaphW+qJXwz5ZtMwc=; h=In-Reply-To:References:From:To:Cc:Subject:Date:From; b=LIxH5q7g63SDPlNc7o1USkQ3yX/1C539AVpTxoDWueAXD2hFiYleI+iKtZ+1+DdB6 mllVpxnFN4LMCLsGYUvmUD4T9fAb9/oBCmILsu0KLEpK8H1C+Iv3ATiQW9k3yZ+15+ LL21Fvyqw1ZUgC9stZitovG1640810+YZgGK8hSU= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20191009060520.GA14506@onstation.org> References: <20191007014509.25180-1-masneyb@onstation.org> <20191007014509.25180-5-masneyb@onstation.org> <20191009022131.604B52070B@mail.kernel.org> <20191009060520.GA14506@onstation.org> From: Stephen Boyd To: Brian Masney Cc: robdclark@gmail.com, sean@poorly.run, bjorn.andersson@linaro.org, a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, jonathan@marek.ca, Linus Walleij Subject: Re: [PATCH RFC v2 4/5] ARM: dts: qcom: msm8974: add HDMI nodes User-Agent: alot/0.8.1 Date: Wed, 09 Oct 2019 08:39:26 -0700 Message-Id: <20191009153927.3DC5D21848@mail.kernel.org> Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Quoting Brian Masney (2019-10-08 23:05:20) > On Tue, Oct 08, 2019 at 07:21:30PM -0700, Stephen Boyd wrote: > > Quoting Brian Masney (2019-10-06 18:45:08) > > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/= qcom-msm8974.dtsi > > > index 7fc23e422cc5..af02eace14e2 100644 > > > --- a/arch/arm/boot/dts/qcom-msm8974.dtsi > > > +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi > > > @@ -1335,6 +1342,77 @@ > > > clocks =3D <&mmcc MDSS_AHB_CLK>; > > > clock-names =3D "iface"; > > > }; > > > + > > > + hdmi: hdmi-tx@fd922100 { > > > + status =3D "disabled"; > > > + > > > + compatible =3D "qcom,hdmi-tx-8974"; > > > + reg =3D <0xfd922100 0x35c>, > > > + <0xfc4b8000 0x60f0>; > > > + reg-names =3D "core_physical", > > > + "qfprom_physical"; > >=20 > > Is this the qfprom "uncorrected" physical address? If so, why can't this > > node use an nvmem to read whatever it needs out of the qfprom? >=20 > The MSM HDMI code is configured to look for this reg-name here: >=20 > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/msm/hdmi/h= dmi.c#L582 >=20 > There is a qcom,qfprom configured for this board in DTS, however its at > a different address range, so maybe there are multiple qfproms? >=20 > https://elixir.bootlin.com/linux/latest/source/arch/arm/boot/dts/qcom-msm= 8974.dtsi#L424 >=20 > msm8996.dtsi has the same style of configuration: >=20 > https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/qcom/m= sm8996.dtsi#L956 > https://elixir.bootlin.com/linux/latest/source/arch/arm64/boot/dts/qcom/m= sm8996.dtsi#L1736 >=20 There's only one qfprom and there's the address space that's "uncorrected" which is not supposed to be used and there's the space that is "corrected" and is supposed to be used. It looks like this is poking the uncorrected space and it should probably stop doing that and use the nvmem provider instead. Maybe someone with docs for this chip and 8996 can help confirm this. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH RFC v2 4/5] ARM: dts: qcom: msm8974: add HDMI nodes Date: Wed, 09 Oct 2019 08:39:26 -0700 Message-ID: <20191009153927.3DC5D21848@mail.kernel.org> References: <20191007014509.25180-1-masneyb@onstation.org> <20191007014509.25180-5-masneyb@onstation.org> <20191009022131.604B52070B@mail.kernel.org> <20191009060520.GA14506@onstation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191009060520.GA14506-1iNe0GrtECGEi8DpZVb4nw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Brian Masney Cc: freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, jonathan-eSc4qw6YbEQ@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linus Walleij , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org, daniel-/w4YWyX8dFk@public.gmane.org, sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org List-Id: dri-devel@lists.freedesktop.org UXVvdGluZyBCcmlhbiBNYXNuZXkgKDIwMTktMTAtMDggMjM6MDU6MjApCj4gT24gVHVlLCBPY3Qg MDgsIDIwMTkgYXQgMDc6MjE6MzBQTSAtMDcwMCwgU3RlcGhlbiBCb3lkIHdyb3RlOgo+ID4gUXVv dGluZyBCcmlhbiBNYXNuZXkgKDIwMTktMTAtMDYgMTg6NDU6MDgpCj4gPiA+IGRpZmYgLS1naXQg YS9hcmNoL2FybS9ib290L2R0cy9xY29tLW1zbTg5NzQuZHRzaSBiL2FyY2gvYXJtL2Jvb3QvZHRz L3Fjb20tbXNtODk3NC5kdHNpCj4gPiA+IGluZGV4IDdmYzIzZTQyMmNjNS4uYWYwMmVhY2UxNGUy IDEwMDY0NAo+ID4gPiAtLS0gYS9hcmNoL2FybS9ib290L2R0cy9xY29tLW1zbTg5NzQuZHRzaQo+ ID4gPiArKysgYi9hcmNoL2FybS9ib290L2R0cy9xY29tLW1zbTg5NzQuZHRzaQo+ID4gPiBAQCAt MTMzNSw2ICsxMzQyLDc3IEBACj4gPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y2xvY2tzID0gPCZtbWNjIE1EU1NfQUhCX0NMSz47Cj4gPiA+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY2xvY2stbmFtZXMgPSAiaWZhY2UiOwo+ID4gPiAgICAgICAgICAgICAgICAg ICAgICAgICB9Owo+ID4gPiArCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGhkbWk6IGhk bWktdHhAZmQ5MjIxMDAgewo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0 YXR1cyA9ICJkaXNhYmxlZCI7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBjb21wYXRpYmxlID0gInFjb20saGRtaS10eC04OTc0IjsKPiA+ID4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICByZWcgPSA8MHhmZDkyMjEwMCAweDM1Yz4sCj4gPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPDB4ZmM0YjgwMDAgMHg2MGYwPjsK PiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWctbmFtZXMgPSAiY29yZV9w aHlzaWNhbCIsCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgInFmcHJvbV9waHlzaWNhbCI7Cj4gPiAKPiA+IElzIHRoaXMgdGhlIHFmcHJvbSAidW5jb3Jy ZWN0ZWQiIHBoeXNpY2FsIGFkZHJlc3M/IElmIHNvLCB3aHkgY2FuJ3QgdGhpcwo+ID4gbm9kZSB1 c2UgYW4gbnZtZW0gdG8gcmVhZCB3aGF0ZXZlciBpdCBuZWVkcyBvdXQgb2YgdGhlIHFmcHJvbT8K PiAKPiBUaGUgTVNNIEhETUkgY29kZSBpcyBjb25maWd1cmVkIHRvIGxvb2sgZm9yIHRoaXMgcmVn LW5hbWUgaGVyZToKPiAKPiBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC9sYXRlc3Qv c291cmNlL2RyaXZlcnMvZ3B1L2RybS9tc20vaGRtaS9oZG1pLmMjTDU4Mgo+IAo+IFRoZXJlIGlz IGEgcWNvbSxxZnByb20gY29uZmlndXJlZCBmb3IgdGhpcyBib2FyZCBpbiBEVFMsIGhvd2V2ZXIg aXRzIGF0Cj4gYSBkaWZmZXJlbnQgYWRkcmVzcyByYW5nZSwgc28gbWF5YmUgdGhlcmUgYXJlIG11 bHRpcGxlIHFmcHJvbXM/Cj4gCj4gaHR0cHM6Ly9lbGl4aXIuYm9vdGxpbi5jb20vbGludXgvbGF0 ZXN0L3NvdXJjZS9hcmNoL2FybS9ib290L2R0cy9xY29tLW1zbTg5NzQuZHRzaSNMNDI0Cj4gCj4g bXNtODk5Ni5kdHNpIGhhcyB0aGUgc2FtZSBzdHlsZSBvZiBjb25maWd1cmF0aW9uOgo+IAo+IGh0 dHBzOi8vZWxpeGlyLmJvb3RsaW4uY29tL2xpbnV4L2xhdGVzdC9zb3VyY2UvYXJjaC9hcm02NC9i b290L2R0cy9xY29tL21zbTg5OTYuZHRzaSNMOTU2Cj4gaHR0cHM6Ly9lbGl4aXIuYm9vdGxpbi5j b20vbGludXgvbGF0ZXN0L3NvdXJjZS9hcmNoL2FybTY0L2Jvb3QvZHRzL3Fjb20vbXNtODk5Ni5k dHNpI0wxNzM2Cj4gCgpUaGVyZSdzIG9ubHkgb25lIHFmcHJvbSBhbmQgdGhlcmUncyB0aGUgYWRk cmVzcyBzcGFjZSB0aGF0J3MKInVuY29ycmVjdGVkIiB3aGljaCBpcyBub3Qgc3VwcG9zZWQgdG8g YmUgdXNlZCBhbmQgdGhlcmUncyB0aGUgc3BhY2UKdGhhdCBpcyAiY29ycmVjdGVkIiBhbmQgaXMg c3VwcG9zZWQgdG8gYmUgdXNlZC4gSXQgbG9va3MgbGlrZSB0aGlzIGlzCnBva2luZyB0aGUgdW5j b3JyZWN0ZWQgc3BhY2UgYW5kIGl0IHNob3VsZCBwcm9iYWJseSBzdG9wIGRvaW5nIHRoYXQgYW5k CnVzZSB0aGUgbnZtZW0gcHJvdmlkZXIgaW5zdGVhZC4gTWF5YmUgc29tZW9uZSB3aXRoIGRvY3Mg Zm9yIHRoaXMgY2hpcAphbmQgODk5NiBjYW4gaGVscCBjb25maXJtIHRoaXMuCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBs aXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVlZHJlbm8=